Commit Graph
100 Commits
Author SHA1 Message Date
Glenn Maynard e2ea72dbac internalize RageFileObj implementation functions 2004-12-10 03:14:01 +00:00
Glenn Maynard 2bf27c582c cleanup 2004-12-09 11:52:49 +00:00
Glenn Maynard ec22ffec62 stop passing ugly back-references to the RageFile to RageFileObj 2004-12-09 11:47:20 +00:00
Glenn Maynard b38e2e25f1 remove parent 2004-12-09 11:31:23 +00:00
Glenn Maynard bb94a3aaa1 cleanup: avoid parent access 2004-12-09 11:28:24 +00:00
Glenn Maynard a2f9bf586d propagate file driver errors normally 2004-12-09 11:17:57 +00:00
Glenn Maynard b2c7aec818 Remove ugly, brute-force Seek and GetFileSize implementations. Nothing uses them, and nothing ever should. 2004-12-09 11:10:27 +00:00
Glenn Maynard 269f0be457 cleanup 2004-12-09 10:48:57 +00:00
Glenn Maynard 6761eb7a51 remove Rewind() 2004-12-09 10:44:07 +00:00
Glenn Maynard c87fd69606 no, reomve Rewind() 2004-12-09 10:42:03 +00:00
Glenn Maynard cae7809e1c make Rewind() optional 2004-12-09 10:40:18 +00:00
Glenn Maynard ea820c77b2 Avoid RageFileObj::Seek; handle rewinds in Seek(). 2004-12-09 10:38:42 +00:00
Glenn Maynard 7ae0ad1533 remove RageFile::Rewind 2004-12-09 10:22:47 +00:00
Glenn Maynard 7085d480ec Remove RageFile::Rewind() calls. The original notion was that rewinding is
often simpler than seeking; that some drivers may only support rewinding;
and that, if supported, rewinding should never fail.  However, there's really
no reason for it to be a separate API call.
2004-12-09 08:59:24 +00:00
Glenn Maynard 335e8149d0 remove RageFileObj::SeekCur 2004-12-09 08:51:28 +00:00
Glenn Maynard fd7e23fce8 remove SeekCur 2004-12-09 08:47:24 +00:00
Glenn Maynard 6904cccf16 SeekCur 2004-12-09 08:46:18 +00:00
Glenn Maynard 00befb1c00 test set fix 2004-12-09 08:45:39 +00:00
Glenn Maynard fa2719a2c1 Remove RageFile::SeekCur(). It's just as easy to call Seek(Tell()), and
separating "seek from current position" doesn't do anything useful for
file drivers.
2004-12-09 08:36:08 +00:00
Glenn Maynard 6558f6f7de This comment is incorrect. deflateReset() doesn't leak; it resets the
object to a just-initialized state.  deflateEnd() is correct (no comment
needed for that; it's obvious, I don't know why I used deflateReset to
begin with).

zlib doesn't appear to do anything special with allocations; running
the following:

#include <zlib.h>
main()
{
	z_stream z; z.zalloc = NULL; z.zfree = NULL;
	inflateInit2( &z, -MAX_WBITS ); inflateReset( &z );
}

under Valgrind shows:

==17033== 7080 bytes in 1 blocks are possibly lost in loss record 1 of 1
==17033==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==17033==    by 0x1B91D4B4: zcalloc (in /usr/lib/libz.so.1.2.1.2)
==17033==    by 0x1B91D608: inflateInit2_ (in /usr/lib/libz.so.1.2.1.2)
==17033==    by 0x80485A4: main (in /home/glenn/a.out)
2004-12-09 04:07:14 +00:00
Glenn Maynard 268dafa582 update option names that are now identical to their StepMania.ini name 2004-12-07 10:06:44 +00:00
Glenn Maynard 8d0bf6039c simpler mechanism: doesn't require a separate function for each preference;
requires only one line in ScreenOptionsMasterPrefs, not two (still needs
appropriate metrics); doesn't require that the metric is in PrefsManager
2004-12-07 10:05:14 +00:00
Glenn Maynard 607c22fef9 add PrefsManager::GetPreferenceByName 2004-12-07 10:04:19 +00:00
Glenn Maynard 823eac2631 make g_ConfOptions a vector 2004-12-07 09:49:03 +00:00
Glenn Maynard dbb52c70d7 real fix for options 2004-12-07 09:22:38 +00:00
Glenn Maynard f7bb6ef29e grr, not quite 2004-12-07 08:32:29 +00:00
Glenn Maynard 8e57c4ca76 This should fix options menu crashes. Adding casts to the MOVE() macros
didn't make it work, since there was no cast overload to bool&, etc; it
just forced the (non-POD) type to that type, which resulted in the struct
being clobbered.
2004-12-07 08:28:24 +00:00
Glenn Maynard ed097b0a5d cleanups (working on cleaner ConfOption/Preference integration) 2004-12-07 02:47:21 +00:00
Glenn Maynard d3180e8690 cleanup 2004-12-07 02:42:50 +00:00
Glenn Maynard 63e2b2be99 move a couple preferences out of PrefsManager 2004-12-07 01:48:46 +00:00
Glenn Maynard a663219b8a move a couple preferences out of PrefsManager
- eventually, this will reduce the gargantuan PrefsManager
 - adding prefs doesn't require modifying PrefsManager.h and recompiling a lot
 - starting with these options because they aren't in ScreenOptionsMaster
2004-12-07 01:47:32 +00:00
Glenn Maynard ba929b8e71 move more common stuff out of the template class, so g_pvpSubscribers is
more useful
2004-12-07 01:44:17 +00:00
Glenn Maynard c37a82ed40 more general string<->value functions 2004-12-07 01:43:06 +00:00
Glenn Maynard d9cfe446ce fix preference names 2004-12-07 01:41:55 +00:00
Glenn Maynard bc07b82eed add Preference.h 2004-12-07 00:52:34 +00:00
Glenn Maynard 04e4406cbb move ScreenSystemLayer into Screens 2004-12-07 00:34:19 +00:00
Glenn Maynard dac3c2b978 update 2004-12-07 00:09:47 +00:00
Glenn Maynard 495a418884 Previously, the main mount loop was unlocking the thread and then immediately
re-locking it.  In some threads implementations (Linux 2.6), this causes the
mount thread to hog the lock, which causes SetMountThreadState to hang.  Move
the "check and delay" part of the mount thread outside of the lock, so other
threads have opportunity to get the lock.
2004-12-07 00:06:59 +00:00
Glenn Maynard 4bde245842 m_fd isn't used anymore 2004-12-06 23:47:23 +00:00
Glenn Maynard 11ea219e12 fix FreeAllLoadedFromProfiles possibly rarely missing some edits 2004-12-06 07:39:26 +00:00
Glenn Maynard c425d193ae new never returns null 2004-12-06 07:34:25 +00:00
Glenn Maynard 8428fc6cfc fix obscure memory leak 2004-12-06 07:32:29 +00:00
Glenn Maynard 0745485124 remove DisableRadar 2004-12-06 06:44:09 +00:00
Glenn Maynard 01e4acc8fe remove DISABLE_RADAR.
"DisableRadar=0     // turn this to 1 if you are experiencing trouble with the groove radar (voodoo3's)"

Theme metrics are not the correct place for dealing with driver bugs; users
can't be told to hack metrics.ini to make their system work.  (I havn't seen
any reports of problems here in a long time, anyway.)
2004-12-06 06:43:27 +00:00
Glenn Maynard 394982b461 fix "0 // foo" -> true 2004-12-06 06:41:31 +00:00
Glenn Maynard f0c9196995 fix Assertion '!actor.GetID().empty()' failed 2004-12-06 06:22:32 +00:00
Glenn Maynard aa2062e380 cleanup
fix hold notes on 2p side
2004-12-06 05:34:40 +00:00
Glenn Maynard 7e2adc093a simplify 2004-12-06 05:25:00 +00:00
Glenn Maynard 26d07ff58c simplify 2004-12-06 05:19:10 +00:00
Glenn Maynard ad8b7c19b7 cleanup 2004-12-06 05:17:56 +00:00
Glenn Maynard 18e70ed3c3 missing metric 2004-12-05 21:14:26 +00:00
Glenn Maynard 7a722d759e simplify 2004-12-05 21:11:51 +00:00
Glenn Maynard 02c637ca88 cleanup
remove SAFE_RELEASE
2004-12-05 21:09:31 +00:00
Glenn Maynard 13ed1ceb51 description 2004-12-05 20:58:04 +00:00
Glenn Maynard 0979c9dcee const 2004-12-04 21:20:02 +00:00
Glenn Maynard c02365242c different dialog tag 2004-12-04 21:17:04 +00:00
Glenn Maynard 6e7c6adea1 fix invalid pn value (which isn't actually used; just reducing StyleI use) 2004-12-04 11:09:32 +00:00
Glenn Maynard 29c5e8a9e1 Fix CODE_CANCEL_ALL_PLAYER_OPTIONS not working when the
last input isn't a style button (StyleI.player isn't valid in that case).

StyleI is tied to "columns"; it's only used in screens that deal with columns:
gameplay, editor, name entry.  Maybe we can derive it on demand in these
functions and not pass it around to dozens of functions that don't use it ...
2004-12-04 11:05:38 +00:00
Glenn Maynard 783e492b0b GetSecondaryMenuButtonName -> GetMenuButtonSecondaryFunction 2004-12-04 04:50:18 +00:00
Glenn Maynard bc9ad4169d remove m_szSecondaryFunction 2004-12-04 04:44:52 +00:00
Glenn Maynard 36d462ffd6 figure out secondary button names dynamically 2004-12-04 04:39:51 +00:00
Glenn Maynard d7a03bb37f fix style table glitches
const fixes
2004-12-04 04:30:39 +00:00
Glenn Maynard 12d5890ea9 add FOREACH_MenuButton 2004-12-04 03:50:26 +00:00
Glenn Maynard e3030248cb cleanup 2004-12-04 03:31:21 +00:00
Glenn Maynard 3961acc447 eliminating brute-force search for ticks 2004-12-03 23:50:20 +00:00
Glenn Maynard 573f8035b3 eliminating brute-force search 2004-12-03 23:43:35 +00:00
Glenn Maynard dbf1097d4d eliminating brute-force search 2004-12-03 23:39:50 +00:00
Glenn Maynard 2243ffa37c split this loop apart (working on eliminating brute-force search) 2004-12-03 23:33:06 +00:00
Glenn Maynard 08cb05e345 short-circuit ScreenGameplay::UpdateLights() 2004-12-03 23:31:35 +00:00
Glenn Maynard 2b3e145a30 split UpdateLights() from monster ScreenGameplay::Update() 2004-12-03 23:30:50 +00:00
Glenn Maynard 5f0f8a6d28 allow short-circuiting lights logic when lights are not in use 2004-12-03 23:26:59 +00:00
Glenn Maynard c9e523ef09 cleanup 2004-12-03 23:22:08 +00:00
Glenn Maynard b6bb0fca3c use column-specific names to rename "scratch" 2004-12-03 22:36:29 +00:00
Glenn Maynard cfefb6715b fix gcc compile 2004-12-03 21:52:27 +00:00
Glenn Maynard 364cb6cd20 fix Makefile 2004-12-03 21:50:02 +00:00
Glenn Maynard b383b5dd3a Reverse the column<->GameInput mapping; instead of allowing a button
to map to more than one column (useless), allow more than one button
to map to a column.  This allows handling both UP and DOWN inputs for
a single SCRATCH column.  (more work still needed for correct scratch
handling; also, due to the massive number of styles we have, some of these
entries may be incorrect)
2004-12-03 21:47:57 +00:00
Glenn Maynard abb6a73e4b simplify, fix ReCalculateRadarValuesAndLastBeat not updating on future
calls because m_fFirstBeat/LastBeat aren't reset to -1
2004-12-03 02:52:07 +00:00
Glenn Maynard 0d608c0806 Make sure the first BPM segment starts at beat 0.
round sample music for short songs to a measure, not 10 beats
2004-12-03 01:16:14 +00:00
Glenn Maynard b3339bb7f1 fix reading UTF-8 lyrics 2004-12-03 01:06:29 +00:00
Glenn Maynard 0d0cb39d75 use utf8_remove_bom 2004-12-03 01:04:31 +00:00
Glenn Maynard afcacbdf85 add utf8_remove_bom 2004-12-03 01:02:45 +00:00
Glenn Maynard 4e3cd6534a WITHOUT_NETWORKING fix 2004-12-03 00:24:42 +00:00
Glenn Maynard 2f27ba0f3e g++ compile fix 2004-12-03 00:22:20 +00:00
Glenn Maynard 82522540ba only cache course banners for courses that actually loaded 2004-12-02 23:04:15 +00:00
Glenn Maynard 873bf63992 cleanup 2004-12-01 20:42:15 +00:00
Glenn Maynard 5bf62b2bc8 don't output diagnostics when not used 2004-12-01 19:18:58 +00:00
Glenn Maynard 65ca46608d fix crash 2004-12-01 19:17:26 +00:00
Glenn Maynard d0c8c82245 cleanup 2004-12-01 03:08:59 +00:00
Glenn Maynard dcf0bb7ac8 move this stuff to where it belongs 2004-12-01 02:48:50 +00:00
Glenn Maynard fafdaedf0c InstallExceptionHandler 2004-12-01 02:45:14 +00:00
Glenn Maynard 494fb05a5c exceptions 2004-12-01 02:37:18 +00:00
Glenn Maynard 318a27fcab exceptions 2004-12-01 01:11:14 +00:00
Glenn Maynard c41cefe7fd compile fix 2004-12-01 01:09:20 +00:00
Glenn Maynard eaf68a4271 exceptions (untested) 2004-12-01 00:31:44 +00:00
Glenn Maynard debbe87224 exceptions 2004-12-01 00:23:13 +00:00
Glenn Maynard efe9fdb0f2 exceptions 2004-12-01 00:12:45 +00:00
Glenn Maynard 67d777f050 exceptions 2004-12-01 00:06:41 +00:00
Glenn Maynard cac8e02281 log play cursor history on underrun 2004-11-30 23:02:26 +00:00
Glenn Maynard 22812c0e7f exceptions 2004-11-30 22:21:50 +00:00
Glenn Maynard 227e8ee78b exceptions 2004-11-30 21:49:02 +00:00