Commit Graph

610 Commits

Author SHA1 Message Date
Steve Checkoway b3056eee1c Fix mines not being triggered when being held down (for the most part). It's still possible for mines to not be triggered if the input released after the mine has passed but before the next Update() frame. This is much tricker to deal with since we can't ask if the button was held down at some time in the past It is also much harder to detect than having held down the button for an entire measure and watched mines just not be hit.
This should also fix autoplay misses by telling Step() exactly which row was pressed.

There are also comments in there about possible bugs in the grading/key sounds but I didn't want to change those without getting input from other devs since it does change the way we grade "jack hammers."
2006-07-28 09:05:58 +00:00
Steve Checkoway b868d557f7 Merge HandleStep() with Step(). This has one functional change, when using auto play and the AI avoids a mine or misses a note, the message to send on a step isn't sent which makes more sense because a step is being judged as not having happened. 2006-07-28 07:12:27 +00:00
Steve Checkoway 787b5ad09a Cleanup. 2006-07-25 06:17:14 +00:00
Steve Checkoway f254abc777 Create one "now" RageTimer and just pass that around. 2006-07-25 05:31:22 +00:00
Steve Checkoway 20b45c5243 TapNotes are not huge structures but there are generally a lot of them and they do contain at least one nontrivial ctor so avoid making copies of them when possible. 2006-07-24 04:42:08 +00:00
Steve Checkoway 03f1e21df4 Spaces between arguments. 2006-07-24 00:14:04 +00:00
Steve Checkoway 73ce25c313 Spacing to make these easier to read. 2006-07-23 23:55:16 +00:00
Steve Checkoway aef5009bfc No, not really. 2006-07-23 23:49:52 +00:00
Steve Checkoway d671011285 Show a combo if showing judgment, not if showing the note field. 2006-07-23 23:48:14 +00:00
Steve Checkoway 36b1ff3df8 Don't make unnecessary copies. 2006-07-23 21:44:35 +00:00
Steve Checkoway b0496fbcb6 Split out HideNote. Make fewer copies of TapNotes. 2006-07-23 21:35:41 +00:00
Steve Checkoway 1b2f2b9cec Handle counting notes separately if the game type does that. 2006-07-23 21:12:39 +00:00
Steve Checkoway c690814aad Comment. I don't have time to fix this tonight. 2006-07-22 09:07:03 +00:00
Steve Checkoway a8aeb38a57 Fix ghost arrow flashes by handling those at the actual step but handle the scores during Update. 2006-07-22 09:01:19 +00:00
Josh Allen 6180a2762a remove ReportTiming 2006-07-22 03:19:58 +00:00
Josh Allen 74fd8211bb Fix float to bool warning 2006-07-22 00:54:17 +00:00
Josh Allen 83cbf811d3 HandleTapScore now sends all mine data to server 2006-07-21 16:03:09 +00:00
Steve Checkoway 9f1bb1e16f Simplify. 2006-07-21 08:01:28 +00:00
Steve Checkoway e8fc52e540 Simplify this. 2006-07-21 04:13:31 +00:00
Steve Checkoway 6124d987b1 Fix mine avoidance. 2006-07-21 04:07:19 +00:00
Josh Allen 4a10b6efca Mines need to be processed for dance points 2006-07-20 18:21:37 +00:00
Steve Checkoway 66012f7a35 Cleanup. 2006-07-20 08:50:16 +00:00
Steve Checkoway eb344e593b Fix ghost arrow flashes for the other players with combined note fields. 2006-07-20 08:42:47 +00:00
Steve Checkoway 93d8db14c7 Fix mines. Now they explode again. 2006-07-20 08:15:10 +00:00
Steve Checkoway 705d929106 Handle avoided mines. Hit mines are still broken. 2006-07-20 07:31:39 +00:00
Steve Checkoway 8292201ad6 Step scores are now handled during Update so make sure all Steps happen in Update before we check the rows so that we don't have to wait for the next frame. 2006-07-20 07:16:06 +00:00
Steve Checkoway 232a3c10b0 Nudge these together. 2006-07-20 06:42:25 +00:00
Steve Checkoway 4efb7c4078 Fix misses count twice. Do not assume that rows are judged in order. Do not judge a row more than once. The JudgedRows class acts like an array of bools (more or less), one per note row but is implemented as a circular buffer (more or less). Note that m_JudgedRows[i] will only return false one time. After that, it is assumed to have been judged. 2006-07-18 00:26:37 +00:00
Steve Checkoway 649cb46a15 Unused. 2006-07-17 02:59:35 +00:00
Steve Checkoway 807e24827c Keep a (nonconst) reference to a NoteData rather than owning the NoteData. Replace calls to Load( nd ) by making the changes to the underlying NoteData and calling Load().
(This breaks other code, commits coming.)
2006-07-17 00:54:19 +00:00
Steve Checkoway e1572442b3 cleanup 2006-07-16 03:14:26 +00:00
Glenn Maynard 0d678f4e4e cleanup. (current logic works well enough) 2006-07-15 00:41:35 +00:00
Steve Checkoway 743d2b9697 Change the api to take a NoteData and a row. Let the score keepers decide what they want to do with the row. 2006-07-14 04:19:30 +00:00
Glenn Maynard 91bd33887e thanks@broken sourceforge 2006-07-13 08:07:11 +00:00
Steve Checkoway 5c1e528e8b Load hold judgments. 2006-07-13 07:27:47 +00:00
Glenn Maynard 020d263cdd remove unused "BeginnerLabel" 2006-07-11 16:55:38 +00:00
Steve Checkoway 1aa51dd1d1 Change ScoreKeeper's api to take TapNotes instead of the scores. 2006-07-10 05:15:52 +00:00
Steve Checkoway c6ba8423b6 Change this interface to return the tap note itself, rather than just the result. 2006-07-10 04:29:19 +00:00
Steve Checkoway eb764177f1 Overlapping NoteFields is not an option. Revert. 2006-07-09 21:51:04 +00:00
Steve Checkoway 3d83bdf906 Allow one Player to share the NoteField of another Player. Also calculate the distance to the closest note or -1 if no note is close. 2006-07-09 20:20:57 +00:00
Glenn Maynard 7f463daafe remove experimental TotalError 2006-07-07 18:45:15 +00:00
Josh Allen 6c80e0fa5a Send mine data to the server. 2006-07-06 17:53:49 +00:00
Glenn Maynard 45582ee9fb support multiplayer 2006-07-01 02:19:44 +00:00
Glenn Maynard 6280cf2356 cleanup 2006-07-01 02:15:22 +00:00
Glenn Maynard 33b0b7bcc5 cleanup 2006-07-01 00:44:52 +00:00
Chris Danford 99a241e49c make holdjudgments small in mini/tiny 2006-06-11 21:26:38 +00:00
Glenn Maynard a3c3b4c24e fix crash at end of hold note in editor playback 2006-05-30 17:44:50 +00:00
Glenn Maynard ed18fe0e9b cleanup 2006-04-29 21:49:56 +00:00
Glenn Maynard 5c8ff23cfb unused 2006-04-29 21:22:16 +00:00
Glenn Maynard 0e8b156b38 no-op 2006-04-29 21:22:04 +00:00