end of the song" (intended for use with "PassMark", which
needs a better name). This isn't called "FailEndOfSong" to
avoid confusion, and was the prompting for renaming
FailEndOfSong.)
actually means "fail immediately, but you can play the rest
of the song anyway". Rename FAIL_END_OF_SONG to
FAIL_IMMEDIATE_CONTINUE, to reflect this better.
Regression to figure out a line through the user's step errors to minimize
that error. It then uses the slope of that line to fix the tempo and the
intercept to fix the offset. Stops are adjusted as if they were originally
calculated as a number of beats, ie the slope is also used to change
the stops.
Also fixed is a bug where the user doesn't get a chance to keep or
reject the sync changes when ESCing (ZZing) from a song.
R=glenn
move sync display/saving out of complicated ScreenGameplay
show sync UI in editor playback as well as gameplay
revert sync from in-memory backup, not from disk
move more functions into debug overlay
Merge ScreenGameplay::SM_NotesEnded code paths.
Replace FAIL_PASSMARK with PlayerOptions FailMark:
It's simpler: only one test (in SM_NotesEnded). It can be 1: changed easily:
say "80% FailMark" for BM; 2: set per-player, if some mode wants an easier
setting for easier difficulties; 3: changed during courses (if you really wanted to).
It coexists with fail types. In some BeatMania games, you have to be over 80%
at the end to pass, but you also fail immediately if the bar empties.
One thing to be careful of: since it coexists with fail types, setting FailOff doesn't
disable FailMark failing. If you want that, too, use "No FailMark".
The danger background works consistently. (If FailOff is set, the behavior is what
it was--no danger at all.)
NEW FEATURE: added autogen icon to select music
NEW FEATURE: toggle for easter eggs in Machine Options
NEW FEATURE: marvelous step timing togglable in Machine Options
NEW FEATURE: Grade AAAA (all marvelous)
CHANGE: Only show ScreenHowToPlay if at least one player chose easy
Chris Danford