actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,611 Commits 3 Branches 0 Tags
c425d193ae2a791104ff8aca5ce772362626c232
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Glenn Maynard c425d193ae new never returns null 2004-12-06 07:34:25 +00:00
Glenn Maynard 8428fc6cfc fix obscure memory leak 2004-12-06 07:32:29 +00:00
Glenn Maynard 0745485124 remove DisableRadar 2004-12-06 06:44:09 +00:00
Glenn Maynard 01e4acc8fe remove DISABLE_RADAR. 
"DisableRadar=0     // turn this to 1 if you are experiencing trouble with the groove radar (voodoo3's)"

Theme metrics are not the correct place for dealing with driver bugs; users
can't be told to hack metrics.ini to make their system work.  (I havn't seen
any reports of problems here in a long time, anyway.)
 2004-12-06 06:43:27 +00:00
Glenn Maynard 394982b461 fix "0 // foo" -> true 2004-12-06 06:41:31 +00:00
Glenn Maynard f0c9196995 fix Assertion '!actor.GetID().empty()' failed 2004-12-06 06:22:32 +00:00
Glenn Maynard aa2062e380 cleanup 
fix hold notes on 2p side
 2004-12-06 05:34:40 +00:00
Glenn Maynard 7e2adc093a simplify 2004-12-06 05:25:00 +00:00
Glenn Maynard 26d07ff58c simplify 2004-12-06 05:19:10 +00:00
Glenn Maynard ad8b7c19b7 cleanup 2004-12-06 05:17:56 +00:00
Glenn Maynard 18e70ed3c3 missing metric 2004-12-05 21:14:26 +00:00
Glenn Maynard 7a722d759e simplify 2004-12-05 21:11:51 +00:00
Glenn Maynard 02c637ca88 cleanup 
remove SAFE_RELEASE
 2004-12-05 21:09:31 +00:00
Glenn Maynard 13ed1ceb51 description 2004-12-05 20:58:04 +00:00
Glenn Maynard 0979c9dcee const 2004-12-04 21:20:02 +00:00
Glenn Maynard c02365242c different dialog tag 2004-12-04 21:17:04 +00:00
Glenn Maynard 6e7c6adea1 fix invalid pn value (which isn't actually used; just reducing StyleI use) 2004-12-04 11:09:32 +00:00
Glenn Maynard 29c5e8a9e1 Fix CODE_CANCEL_ALL_PLAYER_OPTIONS not working when the 
last input isn't a style button (StyleI.player isn't valid in that case).

StyleI is tied to "columns"; it's only used in screens that deal with columns:
gameplay, editor, name entry.  Maybe we can derive it on demand in these
functions and not pass it around to dozens of functions that don't use it ...
 2004-12-04 11:05:38 +00:00
Glenn Maynard 783e492b0b GetSecondaryMenuButtonName -> GetMenuButtonSecondaryFunction 2004-12-04 04:50:18 +00:00
Glenn Maynard bc9ad4169d remove m_szSecondaryFunction 2004-12-04 04:44:52 +00:00
Glenn Maynard 36d462ffd6 figure out secondary button names dynamically 2004-12-04 04:39:51 +00:00
Glenn Maynard d7a03bb37f fix style table glitches 
const fixes
 2004-12-04 04:30:39 +00:00
Glenn Maynard 12d5890ea9 add FOREACH_MenuButton 2004-12-04 03:50:26 +00:00
Glenn Maynard e3030248cb cleanup 2004-12-04 03:31:21 +00:00
Glenn Maynard 3961acc447 eliminating brute-force search for ticks 2004-12-03 23:50:20 +00:00
Glenn Maynard 573f8035b3 eliminating brute-force search 2004-12-03 23:43:35 +00:00
Glenn Maynard dbf1097d4d eliminating brute-force search 2004-12-03 23:39:50 +00:00
Glenn Maynard 2243ffa37c split this loop apart (working on eliminating brute-force search) 2004-12-03 23:33:06 +00:00
Glenn Maynard 08cb05e345 short-circuit ScreenGameplay::UpdateLights() 2004-12-03 23:31:35 +00:00
Glenn Maynard 2b3e145a30 split UpdateLights() from monster ScreenGameplay::Update() 2004-12-03 23:30:50 +00:00
Glenn Maynard 5f0f8a6d28 allow short-circuiting lights logic when lights are not in use 2004-12-03 23:26:59 +00:00
Glenn Maynard c9e523ef09 cleanup 2004-12-03 23:22:08 +00:00
Glenn Maynard b6bb0fca3c use column-specific names to rename "scratch" 2004-12-03 22:36:29 +00:00
Glenn Maynard cfefb6715b fix gcc compile 2004-12-03 21:52:27 +00:00
Glenn Maynard 364cb6cd20 fix Makefile 2004-12-03 21:50:02 +00:00
Glenn Maynard b383b5dd3a Reverse the column<->GameInput mapping; instead of allowing a button 
to map to more than one column (useless), allow more than one button
to map to a column.  This allows handling both UP and DOWN inputs for
a single SCRATCH column.  (more work still needed for correct scratch
handling; also, due to the massive number of styles we have, some of these
entries may be incorrect)
 2004-12-03 21:47:57 +00:00
Glenn Maynard abb6a73e4b simplify, fix ReCalculateRadarValuesAndLastBeat not updating on future 
calls because m_fFirstBeat/LastBeat aren't reset to -1
 2004-12-03 02:52:07 +00:00
Glenn Maynard 0d608c0806 Make sure the first BPM segment starts at beat 0. 
round sample music for short songs to a measure, not 10 beats
 2004-12-03 01:16:14 +00:00
Glenn Maynard b3339bb7f1 fix reading UTF-8 lyrics 2004-12-03 01:06:29 +00:00
Glenn Maynard 0d0cb39d75 use utf8_remove_bom 2004-12-03 01:04:31 +00:00
Glenn Maynard afcacbdf85 add utf8_remove_bom 2004-12-03 01:02:45 +00:00
Glenn Maynard 4e3cd6534a WITHOUT_NETWORKING fix 2004-12-03 00:24:42 +00:00
Glenn Maynard 2f27ba0f3e g++ compile fix 2004-12-03 00:22:20 +00:00
Glenn Maynard 82522540ba only cache course banners for courses that actually loaded 2004-12-02 23:04:15 +00:00
Glenn Maynard 873bf63992 cleanup 2004-12-01 20:42:15 +00:00
Glenn Maynard 5bf62b2bc8 don't output diagnostics when not used 2004-12-01 19:18:58 +00:00
Glenn Maynard 65ca46608d fix crash 2004-12-01 19:17:26 +00:00
Glenn Maynard d0c8c82245 cleanup 2004-12-01 03:08:59 +00:00
Glenn Maynard dcf0bb7ac8 move this stuff to where it belongs 2004-12-01 02:48:50 +00:00
Glenn Maynard fafdaedf0c InstallExceptionHandler 2004-12-01 02:45:14 +00:00
Glenn Maynard 494fb05a5c exceptions 2004-12-01 02:37:18 +00:00
Glenn Maynard 318a27fcab exceptions 2004-12-01 01:11:14 +00:00
Glenn Maynard c41cefe7fd compile fix 2004-12-01 01:09:20 +00:00
Glenn Maynard eaf68a4271 exceptions (untested) 2004-12-01 00:31:44 +00:00
Glenn Maynard debbe87224 exceptions 2004-12-01 00:23:13 +00:00
Glenn Maynard efe9fdb0f2 exceptions 2004-12-01 00:12:45 +00:00
Glenn Maynard 67d777f050 exceptions 2004-12-01 00:06:41 +00:00
Glenn Maynard cac8e02281 log play cursor history on underrun 2004-11-30 23:02:26 +00:00
Glenn Maynard 22812c0e7f exceptions 2004-11-30 22:21:50 +00:00
Glenn Maynard 227e8ee78b exceptions 2004-11-30 21:49:02 +00:00
Glenn Maynard ce1c9d35ed parameter 2004-11-30 21:44:22 +00:00
Glenn Maynard 876d741158 cleanup 2004-11-30 21:43:40 +00:00
Glenn Maynard 5e2abe41aa stubs 2004-11-30 21:42:04 +00:00
Glenn Maynard 27bf6903ce exceptions 2004-11-30 21:36:36 +00:00
Glenn Maynard 7d7c06eee4 exceptions 2004-11-30 21:17:13 +00:00
Glenn Maynard 4ec61b9812 exceptions 2004-11-30 21:11:33 +00:00
Glenn Maynard 29fa454150 exceptions 2004-11-30 20:52:25 +00:00
Glenn Maynard 85ca41e47c exceptions 2004-11-30 20:30:33 +00:00
Glenn Maynard 07acc3fad4 exception handling 2004-11-30 20:26:30 +00:00
Glenn Maynard 6f46898f69 make SetVideoMode not throw 2004-11-30 20:01:07 +00:00
Glenn Maynard 388fb41404 fix comment 2004-11-30 09:28:59 +00:00
Glenn Maynard e84e8f6a7a implement RageException::Throw without actually using exceptions 2004-11-30 09:08:32 +00:00
Glenn Maynard 547c086ac8 cleanup 2004-11-30 09:03:46 +00:00
Glenn Maynard 26ecd6b000 fix warnings 2004-11-30 08:57:45 +00:00
Glenn Maynard ae15aa0a1e throw -> RageException::Throw 2004-11-30 08:22:40 +00:00
Glenn Maynard a5ba0427d4 eliminating exception use 2004-11-30 08:20:57 +00:00
Glenn Maynard b6eba6ac8d start eliminating exception use; gcc apparently bloats exceptions to 
a degree that makes them not worth it
 2004-11-30 08:12:08 +00:00
Glenn Maynard 641ccdbd72 fix warnings (and style fixes) 2004-11-30 08:09:27 +00:00
Glenn Maynard 4c72e16e18 RageException::Throw is for user errors, used for errors that are meaningful on their own ("file corrupt") and probably meaningful to the user; these should never indicate internal logic errors 
FAIL_M is like a failed assertion, and dumps a crashinfo
 2004-11-30 07:58:07 +00:00
Glenn Maynard c5a1874234 probably fix DisplayBpms::BpmIsConstant problems 
const fixes
 2004-11-30 07:56:01 +00:00
Glenn Maynard b144644c7b wchar_t:wstring::char:string; fixes warning 2004-11-30 01:39:22 +00:00
Glenn Maynard 03e22da030 simplify 2004-11-30 01:26:56 +00:00
Glenn Maynard a207a57116 cleanup: 
use one line for header short description
 do not use "#pragma once"
 2004-11-27 02:33:03 +00:00
Glenn Maynard 21bbc0124d simplify 2004-11-26 23:14:35 +00:00
Glenn Maynard 855cae4f47 cleanup 2004-11-26 22:53:16 +00:00
Glenn Maynard 5ab845ce08 fix corruption 2004-11-26 22:48:29 +00:00
Glenn Maynard 151a61ef7a fix check 2004-11-26 21:13:55 +00:00
Glenn Maynard 722a0ad8b0 fall through after getting header 2004-11-26 21:10:41 +00:00
Glenn Maynard f74a35d45b "Addy" -> Address. 2004-11-26 21:00:05 +00:00
Glenn Maynard d19a2c6b69 I can't even guess why a RageFile enum value was hardcoded ... 
Don't call Flush(), Close() does that.
Stream output.
 2004-11-26 20:58:38 +00:00
Glenn Maynard 530c46b1b8 simplify 2004-11-26 20:52:08 +00:00
Glenn Maynard 5383707e3b remove some excess punctuation, eg. if( ( x == y ) ) 2004-11-26 20:49:18 +00:00
Glenn Maynard 9c2d06e150 string::find() result is a size_t, not an int 
unwrap conditional
return after error, or the output string will just be overwritten
 2004-11-26 20:48:06 +00:00
Glenn Maynard 4d98c72902 m_iResponceName -> m_sResponseName 
CString::find and CString::Find are not interchangeable; Find() is only
for compatibility, prefer find()
 2004-11-26 20:45:26 +00:00
Glenn Maynard 5a51991740 find does not return < 0 
reponce -> response
 2004-11-26 20:43:47 +00:00
Glenn Maynard be93eb845d scope/style cleanup 
if ReadData returns -1, be sure to not append(-1)
 2004-11-26 20:41:13 +00:00
Glenn Maynard 41d6f9ad2c m_iResponceCode -> m_iResponseCode 2004-11-26 20:37:59 +00:00
Glenn Maynard 82d76ea224 more style cleanups 2004-11-26 20:37:32 +00:00
Glenn Maynard 2c566f6391 Cleanup: instead of 
func
{
  if( x )
  {
   three pages of code
  }
}

do
func
{
  if( !x )
    return;
  three pages of code;
}

which reduces the indentation level and is easier to understand.
 2004-11-26 20:36:23 +00:00
Glenn Maynard cf54c6fea7 join all 
"headder" -> header
 2004-11-26 20:33:46 +00:00