Commit Graph

100 Commits

Author SHA1 Message Date
Thai Pangsakulyanont 248504f275 escape # in first keysound entry, fixed ADPCM reader and make PMS load more correctly.
- [NoteField] fix build warnings, and change the maximum number of displayed notes
  after the receptor to 64.
- [Player] fix build warnings.
- [NotesLoaderSSC, NotesWriterSSC] The MSD file reader seems to treat # that comes
  directly after : as new tag, and as many PMS and BMS files has keysounds which filename
  starts with #, so it looks like this: #KEYSOUNDS:#bgm.wav,01.wav,02.wav,..
  The MSD parser will see it as 2 different tags. So I added a backslash in front of the
  # sign if it's at the start when saving and remove it when loading.
- [RageSoundReader_WAV] ADPCM now works very well and doesn't return error when
  end of file is reached anymore.
- [Steps] Use BMS loader when loading the note data.
2011-11-11 18:40:34 +07:00
AJ Kelly 011b696bec fix assert 2011-11-10 23:19:08 -06:00
Jason Felds b86a82fb42 Fix issue 585: editor crash w/o saving.
This does not feel like a proper cure, but it does
stop the crashing.
2011-10-17 21:37:30 -04:00
Thai Pangsakulyanont c63809125a keep as many notes after the receptor on the screen as it could, but limit
it to 32. [we may need to fine-tune this number later, but now missed notes
no longer disappear on slow / stopped parts using speed/scroll segments]

Please note that this code might not work well with negative speeds/scrolls.
2011-09-19 12:50:18 +07:00
Mark Cannon 8099e25dcc stage 3 of TimingData changes: changed external interface, enforce encapsulation more strictly 2011-09-15 03:28:58 +00:00
Thai Pangsakulyanont be3094b5af merge.
a bit more about autokeysounds: when I add this RageSoundReader_Extend,
I'm not sure whether the "autokeysounds are delayed" bug will come back
or not. Someone on Windows please test it.
2011-09-14 12:28:16 +07:00
Thai Pangsakulyanont 8fdf42e2bb Add PlayerState::GetDisplayedPosition() and PlayerState::GetDisplayedTiming()
which returns the dispalyed position and timing (based on the timing display
switch in the editor), so less copy n paste in ArrowEffects and NoteField.
2011-09-14 12:20:42 +07:00
Jason Felds 16916a7d67 Right, display the goods on song timing.
Maybe we need to adjust the metrics used here.
2011-09-12 19:47:43 -04:00
Mark Cannon df9c4d8142 segment renovation stage 2: redefine TimingSegments as simple structs, standardize names and functions, use only rows for constructors (we'll limit allocation through TimingData::AddSegment in the near future) 2011-09-11 17:13:10 +00:00
Mark Cannon 0d4e43f9e3 stage 1 of TimingSegment cleanup: consolidate genericizable code in TimingData, use a proper variable name 2011-09-10 03:08:59 +00:00
AJ Kelly 4eb2fe5730 small cleanup 2011-08-24 12:54:30 -05:00
AJ Kelly 154aeff951 [NoteField] Added AreaHighlightColor metric. 2011-08-05 12:14:15 -05:00
Jason Felds 3efcc32a47 Missed a spot. 2011-07-28 10:07:29 -04:00
Jason Felds 5391b4c11d [timing] NoteField covered. 2011-07-27 23:11:34 -04:00
Jason Felds dbdab4759e [Xcode4] May as well fix switch warnings.
Still need some assistance for the linker error.
2011-07-20 11:11:04 -04:00
Jason Felds 88fca505a8 [timing] All that's left is the big one.
Hopefully.

...right, the JSON stuff. GAH.
2011-07-14 14:33:07 -04:00
Jason Felds 08d5f8f722 Add Miss Combo support in #COMBOS tag. 2011-07-09 02:28:15 -04:00
Jason Felds 2726f6df82 NOW Mini and Tiny are swapped properly. 2011-07-05 16:50:06 -04:00
Jason Felds 3115b5a438 Need eyes for couple edit stuff. 2011-07-03 15:10:00 -04:00
Jason Felds d06a14da52 Display the attacks in the editor. 2011-06-24 18:07:47 -04:00
Jason Felds 7a16ba9c0f Add two new noteskin metrics.
This properly resolves bug tracker issue 190.
2011-06-13 14:48:15 -04:00
Jason Felds c3c8753620 More prototype warning stuff.
I know these should be in the .h files,
but we can cover that later.
2011-06-12 19:20:43 -04:00
Jason Felds 0a7b9ce170 Some respect for OOP. (MasterPlayerNumber) 2011-06-06 20:40:11 -04:00
Thai Pangsakulyanont 687affa1e5 merge.
I seem to get an EXC_BAD_ACCESS error about libpng on app starting, so I don't know if the merge succeeded at all :<
2011-06-04 19:18:55 +07:00
Thai Pangsakulyanont 49042c4878 try to improve performance with scroll segments:
- optimize GetDisplayedBeat (seems to be a bottleneck here).
- make sure that fFirstBeatToDraw <= fBeat <= fLastBeatToDraw in IS_ON_SCREEN.
2011-06-04 19:02:45 +07:00
Jason Felds 172ecb8455 Trying different ordering here. 2011-06-01 12:15:13 -04:00
Jason Felds df6a00b53e Stops (and Delays) now templated.
This is all of them at this present time.

At some point in the future, we should make
DelaySegments separate from StopSegments.
2011-06-01 09:50:34 -04:00
Jason Felds 50e93045cc Scroll Segments Satisfied.
Just the Stops and Delays...in one segment.
Yeah, maybe those should be split up at some point.
2011-06-01 08:44:09 -04:00
Jason Felds f9eb6fb387 Speed Segments Satisfied. 2011-05-31 15:27:27 -04:00
Jason Felds b1eab10594 Time Signatures, the other big one. :D 2011-05-31 14:27:55 -04:00
Thai Pangsakulyanont 1d2dd19ab1 Yeah, BPM segments, big one :D 2011-05-31 23:41:39 +07:00
Jason Felds 714427f154 ComboSegments brought in.
Five to go I believe.
2011-05-31 11:45:25 -04:00
Jason Felds da73396895 Labels templated.
Six more to go.
2011-05-31 11:22:21 -04:00
Jason Felds 1fcf290571 Warps are properly templated.
Seven more to go I believe.
2011-05-31 10:59:18 -04:00
Jason Felds 8a315634dc Bring TickcountSegments to refactored level.
I wonder how many of the 8 will be claimed upon wakeup.
2011-05-31 01:20:22 -04:00
Jason Felds 1d3000e520 FakeSegments refactored.
Few things of note:

1) Slowly going away from hungarian notation.
2) Trying to respect public/private members.
2a) Yes, structs can work like this.
3) Trying to not require horizontal scrolling.

If anyone else wants a crack, go ahead:
we have 9 segments left. :)
2011-05-31 00:51:25 -04:00
Thai Pangsakulyanont d9f936190a [default -> scroll] merge 2011-05-25 22:56:26 +07:00
Thai Pangsakulyanont fe9573975c [scroll] 90% of scroll segments 2011-05-25 22:44:41 +07:00
Thai Pangsakulyanont 51229ad086 limit searching to 16 beats 2011-05-24 12:44:48 +07:00
Thai Pangsakulyanont 631bc3753d Revert "An attempt to make the arrows flash with the steps' timing. If it works then we can expand it to..... I don't know, lifebars?"
This reverts commit ab178b1e65.
2011-05-24 10:41:07 +07:00
Thai Pangsakulyanont 1d88598eaf Revert "finally got it to work with a another hack inside that hack."
This reverts commit 73459aae38.
2011-05-24 10:40:04 +07:00
Thai Pangsakulyanont bc35a75672 merge 2011-05-20 22:15:27 +07:00
Thai Pangsakulyanont 73459aae38 finally got it to work with a another hack inside that hack. 2011-05-20 22:15:01 +07:00
Jason Felds b074acc0cb Song timing can have warps again: show them. 2011-05-20 10:52:11 -04:00
Thai Pangsakulyanont ab178b1e65 An attempt to make the arrows flash with the steps' timing. If it works then we can expand it to..... I don't know, lifebars? 2011-05-20 21:33:42 +07:00
Jason Felds 1a41c32dd9 [splittiming] Better variable name.
ArrowEffects had a minor change, but the intent isn't up yet.
It needs to be so that when you go from the editor to the chart
for playing in Song Timing, it doesn't use the Step Timing.
2011-05-17 00:07:43 -04:00
Jason Felds 5206fa2c8c [splittiming] Show fake segments in editor. 2011-05-16 12:02:17 -04:00
Jason Felds c0e53205ea [splittiming] Don't show warps on Song Timing. 2011-05-16 11:54:58 -04:00
Thai Pangsakulyanont c11c8db883 [splittiming] it builds! time to merge. 2011-05-16 22:06:07 +07:00
Jason Felds e2766cf644 [splittiming] SpeedSegments run on Seconds now.
ScreenEdit's code probably needs to be redone.
At least, someone find a way to remove "Beats"
or "Seconds" from the text entry area.
2011-05-15 23:48:03 -04:00