Commit Graph
12656 Commits
Author SHA1 Message Date
Glenn Maynard bb94a3aaa1 cleanup: avoid parent access 2004-12-09 11:28:24 +00:00
Glenn Maynard a2f9bf586d propagate file driver errors normally 2004-12-09 11:17:57 +00:00
Glenn Maynard b2c7aec818 Remove ugly, brute-force Seek and GetFileSize implementations. Nothing uses them, and nothing ever should. 2004-12-09 11:10:27 +00:00
Glenn Maynard 269f0be457 cleanup 2004-12-09 10:48:57 +00:00
Glenn Maynard 6761eb7a51 remove Rewind() 2004-12-09 10:44:07 +00:00
Glenn Maynard c87fd69606 no, reomve Rewind() 2004-12-09 10:42:03 +00:00
Glenn Maynard cae7809e1c make Rewind() optional 2004-12-09 10:40:18 +00:00
Glenn Maynard ea820c77b2 Avoid RageFileObj::Seek; handle rewinds in Seek(). 2004-12-09 10:38:42 +00:00
Glenn Maynard 7ae0ad1533 remove RageFile::Rewind 2004-12-09 10:22:47 +00:00
Chris Danford 12d556c759 allow multiple, simultaneous prepared screens 2004-12-09 09:41:06 +00:00
Glenn Maynard 7085d480ec Remove RageFile::Rewind() calls. The original notion was that rewinding is
often simpler than seeking; that some drivers may only support rewinding;
and that, if supported, rewinding should never fail.  However, there's really
no reason for it to be a separate API call.
2004-12-09 08:59:24 +00:00
Glenn Maynard 335e8149d0 remove RageFileObj::SeekCur 2004-12-09 08:51:28 +00:00
Glenn Maynard fd7e23fce8 remove SeekCur 2004-12-09 08:47:24 +00:00
Glenn Maynard 6904cccf16 SeekCur 2004-12-09 08:46:18 +00:00
Glenn Maynard 00befb1c00 test set fix 2004-12-09 08:45:39 +00:00
Glenn Maynard fa2719a2c1 Remove RageFile::SeekCur(). It's just as easy to call Seek(Tell()), and
separating "seek from current position" doesn't do anything useful for
file drivers.
2004-12-09 08:36:08 +00:00
Chris Danford b6d711b3c1 Remove backgrounds on screens. Have one shared background that persists across screens. 2004-12-09 08:16:18 +00:00
Chris Danford 08964e340b remove ScreenGameOver code, replace with ScreenAttract 2004-12-09 04:20:09 +00:00
Glenn Maynard 6558f6f7de This comment is incorrect. deflateReset() doesn't leak; it resets the
object to a just-initialized state.  deflateEnd() is correct (no comment
needed for that; it's obvious, I don't know why I used deflateReset to
begin with).

zlib doesn't appear to do anything special with allocations; running
the following:

#include <zlib.h>
main()
{
	z_stream z; z.zalloc = NULL; z.zfree = NULL;
	inflateInit2( &z, -MAX_WBITS ); inflateReset( &z );
}

under Valgrind shows:

==17033== 7080 bytes in 1 blocks are possibly lost in loss record 1 of 1
==17033==    at 0x1B904EDD: malloc (vg_replace_malloc.c:131)
==17033==    by 0x1B91D4B4: zcalloc (in /usr/lib/libz.so.1.2.1.2)
==17033==    by 0x1B91D608: inflateInit2_ (in /usr/lib/libz.so.1.2.1.2)
==17033==    by 0x80485A4: main (in /home/glenn/a.out)
2004-12-09 04:07:14 +00:00
Charles Lohr 9a93860c6a Major memory leak fix regarding packages.
The reason that only some people were experiencing a major memory leak
was that it had to do with packages, a lot of devs don't use packages.

This leak could not be found through conventional methods, as zlib's ram
seems to be allocated from the global ram.
2004-12-09 02:09:32 +00:00
Josh Allen 0292eb99c1 Don't limit max players for net evaluation to 32. 2004-12-08 05:35:03 +00:00
Glenn Maynard 268dafa582 update option names that are now identical to their StepMania.ini name 2004-12-07 10:06:44 +00:00
Glenn Maynard 8d0bf6039c simpler mechanism: doesn't require a separate function for each preference;
requires only one line in ScreenOptionsMasterPrefs, not two (still needs
appropriate metrics); doesn't require that the metric is in PrefsManager
2004-12-07 10:05:14 +00:00
Glenn Maynard 607c22fef9 add PrefsManager::GetPreferenceByName 2004-12-07 10:04:19 +00:00
Glenn Maynard 823eac2631 make g_ConfOptions a vector 2004-12-07 09:49:03 +00:00
Glenn Maynard dbb52c70d7 real fix for options 2004-12-07 09:22:38 +00:00
Glenn Maynard f7bb6ef29e grr, not quite 2004-12-07 08:32:29 +00:00
Glenn Maynard 8e57c4ca76 This should fix options menu crashes. Adding casts to the MOVE() macros
didn't make it work, since there was no cast overload to bool&, etc; it
just forced the (non-POD) type to that type, which resulted in the struct
being clobbered.
2004-12-07 08:28:24 +00:00
Charles Lohr 295ae2d961 Oops. 2004-12-07 06:06:01 +00:00
Charles Lohr 9e8cbeb8df Verify that we won't call a method on a non-existant element.
This seems to be the root of a handfull of crashes.
2004-12-07 05:53:03 +00:00
Charles Lohr c3f154dd27 Hmm.. Maybe this'll fix it. 2004-12-07 03:24:14 +00:00
Glenn Maynard ed097b0a5d cleanups (working on cleaner ConfOption/Preference integration) 2004-12-07 02:47:21 +00:00
Glenn Maynard d3180e8690 cleanup 2004-12-07 02:42:50 +00:00
Glenn Maynard 63e2b2be99 move a couple preferences out of PrefsManager 2004-12-07 01:48:46 +00:00
Glenn Maynard a663219b8a move a couple preferences out of PrefsManager
- eventually, this will reduce the gargantuan PrefsManager
 - adding prefs doesn't require modifying PrefsManager.h and recompiling a lot
 - starting with these options because they aren't in ScreenOptionsMaster
2004-12-07 01:47:32 +00:00
Glenn Maynard ba929b8e71 move more common stuff out of the template class, so g_pvpSubscribers is
more useful
2004-12-07 01:44:17 +00:00
Glenn Maynard c37a82ed40 more general string<->value functions 2004-12-07 01:43:06 +00:00
Glenn Maynard d9cfe446ce fix preference names 2004-12-07 01:41:55 +00:00
Glenn Maynard bc07b82eed add Preference.h 2004-12-07 00:52:34 +00:00
Glenn Maynard 04e4406cbb move ScreenSystemLayer into Screens 2004-12-07 00:34:19 +00:00
Glenn Maynard dac3c2b978 update 2004-12-07 00:09:47 +00:00
Glenn Maynard 495a418884 Previously, the main mount loop was unlocking the thread and then immediately
re-locking it.  In some threads implementations (Linux 2.6), this causes the
mount thread to hog the lock, which causes SetMountThreadState to hang.  Move
the "check and delay" part of the mount thread outside of the lock, so other
threads have opportunity to get the lock.
2004-12-07 00:06:59 +00:00
Glenn Maynard 4bde245842 m_fd isn't used anymore 2004-12-06 23:47:23 +00:00
Chris Danford 0f2b0bd119 add checkpoints 2004-12-06 08:28:38 +00:00
Glenn Maynard 11ea219e12 fix FreeAllLoadedFromProfiles possibly rarely missing some edits 2004-12-06 07:39:26 +00:00
Glenn Maynard c425d193ae new never returns null 2004-12-06 07:34:25 +00:00
Glenn Maynard 8428fc6cfc fix obscure memory leak 2004-12-06 07:32:29 +00:00
Glenn Maynard 0745485124 remove DisableRadar 2004-12-06 06:44:09 +00:00
Glenn Maynard 01e4acc8fe remove DISABLE_RADAR.
"DisableRadar=0     // turn this to 1 if you are experiencing trouble with the groove radar (voodoo3's)"

Theme metrics are not the correct place for dealing with driver bugs; users
can't be told to hack metrics.ini to make their system work.  (I havn't seen
any reports of problems here in a long time, anyway.)
2004-12-06 06:43:27 +00:00
Glenn Maynard 394982b461 fix "0 // foo" -> true 2004-12-06 06:41:31 +00:00