fix "impossible to get 100% on a course that uses AddMines" by calculating RadarValues after applying mods
Trail::GetRadarValues needs to do caching. Performance is bad.
Merge ScreenGameplay::SM_NotesEnded code paths.
Replace FAIL_PASSMARK with PlayerOptions FailMark:
It's simpler: only one test (in SM_NotesEnded). It can be 1: changed easily:
say "80% FailMark" for BM; 2: set per-player, if some mode wants an easier
setting for easier difficulties; 3: changed during courses (if you really wanted to).
It coexists with fail types. In some BeatMania games, you have to be over 80%
at the end to pass, but you also fail immediately if the bar empties.
One thing to be careful of: since it coexists with fail types, setting FailOff doesn't
disable FailMark failing. If you want that, too, use "No FailMark".
The danger background works consistently. (If FailOff is set, the behavior is what
it was--no danger at all.)
Known Bugs: The only major bug i've experienced with this is for some reason the arrows continue past the grey bar even if you get great, perfect or marvellous. This doesn't affect the score though, I can't quite figure this one out.
Added: Hidden and Vanish codes for PIU.
Appearance PlayerOptions are now not mutually exclusive
Accel PlayerOptions are now not mutually exclusive
Most PlayerOptions linearly interpolate if changed during song
CHANGE: Reorganized options on Player Options screen
NEW FEATURE: New modifier: Acceleration-Land
NEW FEATURE: New modifier: Acceleration-Expand
NEW FEATURE: New modifier: Acceleration-Boomerang
CHANGE: Tweaked Acceleration-Wave for more of a challenge
CHANGE: Changed format NoteSkin tap graphic format. Existing NoteSkins will
need to update the tap graphic.
Chris Danford