NoteDataUtil::GetTotalHoldTicks() was not counting the last tick of
holds which ended on the last row of the song. Extended the range to
include the last row.
NoteDataUtil::GetTotalHoldTicks() was counting number of rows held, when
it should only count 1 regardless of number( at least to mimic pump )
Player::CrossedRows() was assuming a constant tick rate over the crossed
rows, leading to potentially inaccurate tick counts.
Pump holds were counting "HoldNote_Held" due to capitalization in the
metrics. Fixed metrics and made "IsGame" function case insensitive.
Added an HNS type to handle holds which are never initialized due to
missed taps. This fixes a long standing issue with
iCurPossibleDancePoints and allows themes to decide how to handled this
case.
I would've added commands but I'm not sure where they get run from (or
if they get run at all), so that's a job for later.
(Sourced from shakesoda/stepmania.)
It strictly depends on the size of the graphic since there's no commands that
can be run on the stream as far as I can tell.
(Sourced from shakesoda/stepmania.)
Themes can use these to implement custom per-profile data, such as
SpeedMods.txt. For memory cards, they will be executed while the card is
mounted and should read/write everything they will need at that point.
Also makes minor tweaks to the SetSong function and adds a SystemMessage to
display that no steps have been found. When this happens, the ScreenJukebox
will return to its PrevScreen.
This reverts commit 3739c36956.
That should be the last of the coin mode things. I will not let gimping the
game like this slip by. If you have a problem, I suggest forking.
AM's broken business model has nothing to do with us. Gimping coin modes won't
magically stop piracy, it will lead to more fragmentation in the community
than there already is (and there's a lot), and hurt adoption.
StepMania itself is a free game, but it's entirely within users rights granted
by the license to sell it. This is what you agree to by committing to it. It's
not our business if some choose to use their powers for less-than-good. If you
want to stop your content from being used with pay mode, we should think up
another way than ripping the whole damn thing out.
Colby Klein