Arthur Eubanks
995f0ea8c1
Change some RString methods to free functions
...
These ones aren't a std::string method. Doing this helps the RString to
std::string migration.
2025-05-17 14:02:12 -07:00
Arthur Eubanks
ecfcb11a00
Remove implicit conversion operator from RString to const char*
...
This is required for the RString to std::string migration.
Mostly automated from https://github.com/aeubanks/rewriter/blob/main/c_str.cc , with some manual intervention required for fixing up `a + b.c_str()` to `(a + b).c_str()`.
Added some overloads for some common global functions like sm_crash to reduce the number of changes required here.
2025-05-15 21:14:54 -07:00
Arthur Eubanks
c207d9e0a8
Add .clang-format
...
This tells clang-format what kind of style we want to format as, see
https://clang.llvm.org/docs/ClangFormatStyleOptions.html .
Set it based on Google style. We can iterate on details in the
future.
2025-04-26 16:21:11 -07:00
Arthur Eubanks
7e3ce11658
Clarify confusing RString comparison
...
This was actually a nullptr that got converted to an empty string
because of RString-specific code.
2025-04-23 22:34:16 -07:00
Arthur Eubanks
0ba8230b7e
Make Preference implicit conversion operator return a reference
...
Instead of copying. We can let the caller decide if they want to copy.
Also helps with #756 .
2025-04-23 21:17:50 -07:00
Arthur Eubanks
ebcd50679d
Include dependent headers harder
...
Prepares for changing some includes in StdString.h
2025-04-22 23:22:56 -07:00
Arthur Eubanks
5323bf998e
Replace confusing buffer calls in vssprintf
...
This is basically just resizing the buffer ahead of the vsnprintf, no
need for the extra Release/GetBuffer indirection.
2025-04-22 23:21:36 -07:00
Arthur Eubanks
9131dc6b68
Prefix some calls with std::
...
These depend on C++ argument dependent name lookup and won't work with
an upcoming cleanup.
2025-04-22 23:19:28 -07:00
Arthur Eubanks
9dc5cea91d
Use C++17 in LoadingWindowGtk
...
To match the rest of the build.
2025-04-22 23:19:03 -07:00
Arthur Eubanks
49393443da
Remote delta-note-pro
...
In #441 , people seem to be leaning toward removing the extra noteskin.
If people complain we can reinstate it.
2024-08-26 17:31:08 -07:00
Arthur Eubanks
238c034542
Swap red/blue notes in pump rhythm noteskin
...
PIU Pro uses blue notes for quarter notes and red notes for eighth
notes, but AFAIK nobody likes this color arrangement. Match all the
other 4 panel noteskins.
Keep around the old one as delta-note-pro.
2024-08-26 08:34:38 -07:00
Arthur Eubanks
adace28e57
Make zlib workaround for #107 apply everywhere
...
I missed zlib in #150 .
2024-04-20 19:38:19 -07:00
Arthur Eubanks
bdafbd4660
Fix some clang warnings
...
-Wunqualified-std-cast-call and -Wsign-compare.
2024-04-17 00:20:03 -07:00
Arthur Eubanks
d17f41b2c5
Fix groove radar value calculation
2023-10-24 13:59:58 -07:00
Arthur Eubanks
7f76a1f5b9
Make tomcrypt workaround for #107 apply everywhere
...
I'm seeing the same warning building with clang on Linux.
2023-10-24 13:59:08 -07:00
Arthur Eubanks
f8f6f12999
Add pump shortcut for closing current song folder
2023-01-31 21:31:52 -08:00
Arthur Eubanks
b88e81a8f5
Don't re-sort sections when sorting by length
...
Re-sorting causes oddities like
https://github.com/Simply-Love/Simply-Love-SM5/issues/362
2022-03-28 20:11:53 -07:00
aeubanks
bbafb49b3a
Don't force libc++ with clang ( #1984 )
...
Clang works with libstdc++.
2020-04-30 13:24:58 -07:00
aeubanks
e16017bd1a
Clean up InputHandler_SextetStream ( #1985 )
...
Before, this ended up calling a virtual method in the constructor,
which C++ does not allow, and I got weird crashes.
This removes a lot of unused code and gets rid of unnecessary abstractions.
2020-04-30 13:24:23 -07:00
Arthur Eubanks