Commit Graph
100 Commits
Author SHA1 Message Date
Glenn Maynard 5ab845ce08 fix corruption 2004-11-26 22:48:29 +00:00
Glenn Maynard 151a61ef7a fix check 2004-11-26 21:13:55 +00:00
Glenn Maynard 722a0ad8b0 fall through after getting header 2004-11-26 21:10:41 +00:00
Glenn Maynard f74a35d45b "Addy" -> Address. 2004-11-26 21:00:05 +00:00
Glenn Maynard d19a2c6b69 I can't even guess why a RageFile enum value was hardcoded ...
Don't call Flush(), Close() does that.
Stream output.
2004-11-26 20:58:38 +00:00
Glenn Maynard 530c46b1b8 simplify 2004-11-26 20:52:08 +00:00
Glenn Maynard 5383707e3b remove some excess punctuation, eg. if( ( x == y ) ) 2004-11-26 20:49:18 +00:00
Glenn Maynard 9c2d06e150 string::find() result is a size_t, not an int
unwrap conditional
return after error, or the output string will just be overwritten
2004-11-26 20:48:06 +00:00
Glenn Maynard 4d98c72902 m_iResponceName -> m_sResponseName
CString::find and CString::Find are not interchangeable; Find() is only
for compatibility, prefer find()
2004-11-26 20:45:26 +00:00
Glenn Maynard 5a51991740 find does not return < 0
reponce -> response
2004-11-26 20:43:47 +00:00
Glenn Maynard be93eb845d scope/style cleanup
if ReadData returns -1, be sure to not append(-1)
2004-11-26 20:41:13 +00:00
Glenn Maynard 41d6f9ad2c m_iResponceCode -> m_iResponseCode 2004-11-26 20:37:59 +00:00
Glenn Maynard 82d76ea224 more style cleanups 2004-11-26 20:37:32 +00:00
Glenn Maynard 2c566f6391 Cleanup: instead of
func
{
  if( x )
  {
   three pages of code
  }
}

do
func
{
  if( !x )
    return;
  three pages of code;
}

which reduces the indentation level and is easier to understand.
2004-11-26 20:36:23 +00:00
Glenn Maynard cf54c6fea7 join all
"headder" -> header
2004-11-26 20:33:46 +00:00
Glenn Maynard 9e46888c7d Style cleanups: don't overparenthesize, if( x ), not if ( x ) 2004-11-26 20:18:23 +00:00
Glenn Maynard 25d12ee6a4 fix warning 2004-11-26 20:15:50 +00:00
Glenn Maynard 166bb5b451 If you use code from someone else, list them, not where you got the code from. 2004-11-26 20:02:01 +00:00
Glenn Maynard 7caea1f23a cleanup (this stuff appears stubbed on xbox) 2004-11-26 19:58:36 +00:00
Glenn Maynard 07f7827cec typo 2004-11-26 19:47:26 +00:00
Glenn Maynard 83da2ee50f fix assert output 2004-11-26 19:45:03 +00:00
Glenn Maynard 2f77f403ef unused variable 2004-11-24 00:51:40 +00:00
Glenn Maynard 9bc770c83f FlushPosMapQueue optimization 2004-11-15 19:11:57 +00:00
Glenn Maynard cca289bcf9 remove unused stuff 2004-11-15 18:24:50 +00:00
Glenn Maynard ebf9981cfd compile fix 2004-11-15 18:18:07 +00:00
Glenn Maynard b89305d958 call SOUNDMAN->Shutdown 2004-11-15 05:25:57 +00:00
Glenn Maynard ca62f3d94f Add optional Shutdown() call, to shut down the driver before deleting
SOUNDMAN.

Remove g_DeletionMutex; no longer needed.
2004-11-15 05:22:39 +00:00
Glenn Maynard 9c3a20dfc1 remove playing_sounds 2004-11-15 05:19:38 +00:00
Glenn Maynard 4a615a8d1e remove GetPlayingSounds 2004-11-15 05:18:50 +00:00
Glenn Maynard 6e0a17d42c hack to not confuse GetCopies no longer needed 2004-11-15 05:15:51 +00:00
Glenn Maynard 36e7a78ea6 remove RegisterPlayingSound, UnregisterPlayingSound 2004-11-15 05:15:06 +00:00
Glenn Maynard e990931b61 remove GetCopies 2004-11-15 05:05:31 +00:00
Glenn Maynard 1ac14bb81b this is the only place that uses GetCopies; eliminate it 2004-11-15 05:04:35 +00:00
Glenn Maynard 4d2503c386 remove StopPlayingAllCopiesOfSound 2004-11-15 04:54:48 +00:00
Glenn Maynard de5c504191 RageSoundManager::StopPlayingSoundsForThisThread 2004-11-15 04:53:15 +00:00
Glenn Maynard f15246cba8 don't stop copies on stop and destruction; just the master copy
- this may come back, but if it does, the list of copied sounds should be stored inside RageSound itself
remove registration of playing sounds; the need is going away
2004-11-15 04:43:42 +00:00
Glenn Maynard 6bc25e56c2 disable "wait for sounds to stop before quitting" 2004-11-15 04:42:10 +00:00
Glenn Maynard c263c27fba remove StopPlayingSoundsForThisThread 2004-11-15 04:18:21 +00:00
Glenn Maynard 366970728b update 2004-11-15 03:25:47 +00:00
Glenn Maynard 1c9a87326a Move the default life meter to a metric. I'm not yet sure what the best
way to handle these are; metrics, different GamePrefs defaults per game, ...
2004-11-15 03:24:43 +00:00
Glenn Maynard 57002035fd cleanup 2004-11-14 21:04:09 +00:00
Glenn Maynard 8770ff7c8d fix error handling for mono sounds 2004-11-14 20:21:04 +00:00
Glenn Maynard 09b14c370e add PlayerOptions::ResetSavedPrefs 2004-11-14 05:25:30 +00:00
Glenn Maynard 4a246546a9 Save profile modifiers per gametype. Only reset saved modifiers when
loading profile modifiers, so we don't wipe out modifiers that aren't saved.
UsingProfileDefaultModifiers is gone; if an entry exists in the DefaultModifiers
list at all, UsingProfileDefaultModifiers is true.
2004-11-14 05:24:37 +00:00
Glenn Maynard 6e602f89c9 preload after resample, not before 2004-11-14 04:29:33 +00:00
Glenn Maynard c483fbbd1a foo 2004-11-13 22:26:31 +00:00
Glenn Maynard f7617415e6 split off GetCommonTagFromMapList 2004-11-13 22:23:51 +00:00
Glenn Maynard eeb0ac35fb fix crash 2004-11-13 22:19:21 +00:00
Glenn Maynard f93a43bdc4 Fix formatting again--please fix your editor ... 2004-11-13 21:54:06 +00:00
Glenn Maynard 8b3fafb139 stop putting garbage in the notes description
fix compile
2004-11-13 21:51:45 +00:00
Glenn Maynard f88624ef31 stop doing incorrect parsing on the title 2004-11-13 21:46:43 +00:00
Glenn Maynard d55dee1dd1 solo description is "solo", not "edit" 2004-11-13 21:42:15 +00:00
Glenn Maynard b5fac2eb05 s/FindLargestCommonSubstring/FindLargestInitialSubstring/
do it without lots of string copying/comparing
2004-11-13 21:17:27 +00:00
Glenn Maynard c0930b9c33 formatting 2004-11-13 21:08:19 +00:00
Glenn Maynard 07fd0101dc simplify 2004-11-13 21:07:10 +00:00
Glenn Maynard 2a92bc832a remove commonSubstrLen; clearer to just size() each time, and it's only
used in a few places
2004-11-13 21:01:09 +00:00
Glenn Maynard a4306e55bb fix warnings 2004-11-13 20:56:23 +00:00
Glenn Maynard 2de78dfd5d unused variable 2004-11-13 20:53:46 +00:00
Glenn Maynard 75f0dee79c fix up formatting 2004-11-13 20:48:28 +00:00
Glenn Maynard 7136b25289 fix m_bFilled not being set to false 2004-11-12 23:16:08 +00:00
Glenn Maynard e9ed9d20ee null string fix 2004-11-11 23:55:03 +00:00
Glenn Maynard c44818d9fd typo 2004-11-11 22:32:30 +00:00
Glenn Maynard e0ef0da9e9 fix song backgrounds, probably other things 2004-11-11 22:31:55 +00:00
Glenn Maynard 16aa98b5b2 fix m_LockedBy 2004-11-10 22:10:52 +00:00
Glenn Maynard 6146f9913a fix positioning 2004-11-10 22:07:22 +00:00
Glenn Maynard 6f82e9aad7 fix performance problems due to SCREEN_WIDTH being evaluated many times per frame, leading to many Lua compilations per frame 2004-11-10 10:23:58 +00:00
Glenn Maynard 28e0500534 fix WITHOUT_NETWORKING 2004-11-10 08:36:34 +00:00
Glenn Maynard 425299cbd4 Some songs have different time signature tags in different difficulties;
cope with it by adjusting everything according to the primary version.

Attempt to detect when time signature tags are being used to tweak sync,
and convert them to BPM changes.  This is more accurate, prevents some
cases of being off by a couple rows from the beat, and fixes note coloring.
2004-11-08 22:27:34 +00:00
Glenn Maynard 422b1defb7 TimingData::MultiplyBPMInBeatRange 2004-11-08 22:24:18 +00:00
Glenn Maynard 2aa43ea93c allow concurrent file requests; we only need exclusive access for Mount/Unmount 2004-11-08 22:13:56 +00:00
Glenn Maynard acc6d10d7c Threadsafe FilenameDB: allows concurrent fill requests, so reading from
a CD (which may block for long periods of time) doesn't stop other threads
2004-11-08 21:55:00 +00:00
Glenn Maynard 1b7fbd69d6 unneeded now 2004-11-08 07:14:47 +00:00
Glenn Maynard 348c1a696e minor optimization: searching for a character in a string is faster than
searching for a substring
2004-11-08 07:12:17 +00:00
Glenn Maynard aef954a91b disable broken warning 2004-11-08 07:08:02 +00:00
Glenn Maynard 2fc38be71c _WIN32_WINNT 2004-11-08 05:54:39 +00:00
Glenn Maynard 7a8116c119 Play the ghost flash for all judgements; if a note skin doesn't want this,
disable it in metrics.
2004-11-08 04:05:46 +00:00
Glenn Maynard 6eb08e4140 RageEvent 2004-11-07 23:21:45 +00:00
Glenn Maynard 0330fa9e87 untested pthreads event implementation 2004-11-07 22:56:03 +00:00
Glenn Maynard 4de15ff3a7 untested thread events implementation for win32 2004-11-07 22:43:39 +00:00
Glenn Maynard c9596b9002 increase MAX_FNAMBUF 2004-11-07 22:42:07 +00:00
Glenn Maynard 6c7bd2a8ac grr 2004-11-07 07:12:44 +00:00
Glenn Maynard 9b43b3278b fix warning 2004-11-07 06:41:53 +00:00
Glenn Maynard c1ffc40f86 fix incorrect credit deduction when in free play + DelayedCreditReconcile 2004-11-07 01:11:26 +00:00
Glenn Maynard 32e799c41e half-doubles reading fixes 2004-11-07 00:58:43 +00:00
Glenn Maynard 072d41aada Fix "Assertion 'iNumTapsInRow > 0' failed" if attack notes happen to slip
into the data.  (They aren't generally used yet, and not recommended since
they may change significantly, but they occasionally end up in data, so let's
not crash.)
2004-11-06 23:31:03 +00:00
Glenn Maynard c8a252ee77 fix m_FinishedRequests not being cleared on Abort() 2004-11-06 03:21:19 +00:00
Glenn Maynard 639afd0bfd memory optimization: sizeof(Trail) * NUM_STEPS_TYPES * NUM_DIFFICULTIES adds up.
This will cause Trail*s returned from GetTrail to become invalid when the trail
cache is invalidated.
2004-11-05 08:54:09 +00:00
Glenn Maynard 3d084e2a2c move stats formatting to RageDisplay, so renderers can add custom stats 2004-11-05 04:15:06 +00:00
Glenn Maynard e0b211aca6 fix MessageX metric not being used 2004-11-05 03:51:13 +00:00
Glenn Maynard cc034a65aa fix GradePercent saving 2004-11-05 02:09:48 +00:00
Glenn Maynard 12652ed750 try utf-8 first 2004-11-05 00:38:51 +00:00
Glenn Maynard 5390cea922 fix txtin/txtout memleaks
iconv and CString are both 8-bit clean; maintain that
error checks
2004-11-04 23:24:16 +00:00
Glenn Maynard 24614c9bc4 error check 2004-11-04 23:00:20 +00:00
Glenn Maynard 9f06afa9a4 Err ... 2004-11-04 22:56:22 +00:00
Glenn Maynard e3b9a4bacc flush the sound to the write position, not the play position 2004-11-04 00:20:48 +00:00
Glenn Maynard 26faea2615 Revert. FLUSHING was defined by me, so it's not possible for me to have
misconceptions about what it means.  :)  Probable real fix in a moment
(that doesn't cause us to waste resources mixing silence).
2004-11-04 00:19:18 +00:00
Glenn Maynard feae525a63 we have music for keyed songs, even if we have no BGM track 2004-11-04 00:03:51 +00:00
Glenn Maynard 6ff519cd50 Better difficulty detection.
Prefer to read global stats from DIFFICULTY_NORMAL.
Fix songs that have differing 02 tags across files.
2004-11-03 09:35:10 +00:00
Glenn Maynard d581ae240e fix row 0 being skipped 2004-11-03 08:22:20 +00:00
Glenn Maynard d398a38094 Load all BMS data into a map, then parse. Removes extra re-parsing,
fixes stop and BPM changing, fixes stop/BPM change interactions with
time sig changing.
2004-11-03 06:54:05 +00:00