ffc66719f7
cleanup
2006-11-21 03:48:12 +00:00
c86c218522
MessageToString -> MessageIDToString
2006-11-14 04:26:38 +00:00
e87789da7c
Rename XToString2 to XToString.
2006-10-15 00:09:18 +00:00
04bff6bc1d
Use XToString2.
2006-10-15 00:00:22 +00:00
f18cb36048
don't AtEval these args
2006-10-11 02:41:24 +00:00
de6ca466d2
more enum standardization
2006-10-07 04:39:48 +00:00
8a4ddd1515
Invalid
2006-10-07 04:13:43 +00:00
e531249704
naming cleanups
2006-09-26 20:49:10 +00:00
f806ec5936
StepsType_Invalid
2006-09-26 20:28:46 +00:00
f567a0fd28
cleanup arg order
2006-09-26 08:54:54 +00:00
d7e64dc979
Simplify. PushStack was only calling Push and possibly generating a function for each enumerated type which in the end only called Push. Rename PopStack -> Pop to be symmetric with Push.
2006-09-21 07:06:18 +00:00
d04a5920fa
LuaExpression -> LuaReference
2006-09-21 02:09:44 +00:00
b1ccf2e5ff
The correct syntax for theme metrics is "class::name".
2006-09-17 05:37:42 +00:00
6ea2a41b00
Cleanup RageException::Throw(). Do not use ssprintf() inside of Throw() and do not pass it bare error messages. Use RageException::Throw( "%s", sError.c_str() ); instead. Be consistent with quoting file names "%s" and theme metrics as "%s : %s". Try to make them complete English sentences when possible.
2006-09-17 01:19:19 +00:00
45e5f76af0
when there's a sensible error handling path, prefer to use it instead of asserting
2006-09-07 04:26:59 +00:00
685e2e7412
Split part of OptionRow::GetThemedItemText into OptionRowHandler::GetThemedItemText.
...
(OptionRowHandler handles low-level option sets, including row and option
titles; OptionRow handles ScreenOption-specific parts, like "NextRow".)
2006-09-01 04:54:15 +00:00
e6d1712c27
move OptionRowDefinition into OptionRowHandler
...
(want OptionRowHandler to be easily usable without OptionRow; ORH is
really part of ORD, not OptionRow)
2006-09-01 04:37:39 +00:00
3f468cb30a
move OptionTitle into OptionRowHandler
2006-09-01 04:29:24 +00:00
1a42ad7d4e
simplify
2006-08-31 23:06:22 +00:00
7ac45c24e4
save Preferred, Stage, Song, and Current modifiers separately. This eliminates the fragile mods store/restore.
2006-08-05 02:38:05 +00:00
9843feb01f
make invalid conf types non-fatal
2006-07-05 02:39:47 +00:00
418b41ab22
add OptionRowHandler* MakeSimple( const MenuRowDef &mr )
2006-06-12 22:51:43 +00:00
268624f8ec
Minor spacing cleanup.
2006-05-20 05:40:09 +00:00
c7b6b038c5
fix assert if P2 doesn't match any options and P1 is active
2006-03-24 18:16:28 +00:00
e5da1a542a
fix AV preloading SPlayerOptions when no course selected
2006-03-01 21:37:49 +00:00
9ac8082f3a
more useful warning
2006-02-28 21:45:46 +00:00
977689ac83
Annoying: allow OptionRowHandlers to specify what they reloaded, and
...
don't re-create things if we've only changed what's enabled. Use this
with the Lua interface, by making EnabledForPlayers a function returning
a table instead of a table.
2006-02-27 05:43:39 +00:00
b492263f82
closer to a fixed Reload
2006-02-26 21:32:52 +00:00
2de0170202
fix ReloadRowMessages ignored
2006-02-26 09:37:37 +00:00
30bc09ee74
fix speed line
2006-02-18 03:18:58 +00:00
7f821e8cfc
CString -> RString
2006-01-22 01:00:06 +00:00
b52e776f36
remove def param; use m_Def
2006-01-19 03:43:29 +00:00
bc138aa563
def is always m_Def
2006-01-19 03:36:06 +00:00
e3798432d4
implement OptionRowHandlerListSteps::Reload
2006-01-18 06:44:13 +00:00
32b83fbc00
move similar code together, in hopes of nudging them together later
2006-01-18 03:18:03 +00:00
6adbf26fb3
Give each "list" type its own class, and create them in OptionRowHandlerUtil::Make.
...
- The metrics-visible "list" type should only be used for items that actually
use ScreenOptionsMaster lists. The fact that the others use the same class
for convenience is an implementation detail.
- Each type can have its own Reload() method, if appropriate.
2006-01-18 02:56:41 +00:00
1f3b71f3b1
move SelectExactlyOne and GetOneSelection into a namespace
2006-01-18 02:00:22 +00:00
9b37d8966c
LoadInternal doesn't call Init()
2006-01-18 00:09:37 +00:00
b1cfe1bb72
unify m_Def.Init
2006-01-18 00:09:11 +00:00
2b172e7f7c
Remove defOut param; it's always m_Def.
2006-01-18 00:06:25 +00:00
04a702ea22
cleanup
2006-01-17 23:26:49 +00:00
1e4c5cabe0
add OptionRowHandlerUtil::MakeNull
2006-01-17 20:39:56 +00:00
85d654a306
remove unused parameter; simplify
2006-01-17 20:36:29 +00:00
d1126e82b3
fix base not called
2006-01-17 20:19:04 +00:00
a629be2800
style
2006-01-17 06:51:22 +00:00
b1c4fc168a
cleanup
2006-01-16 22:38:53 +00:00
9f50c2aa5f
cleanup
2006-01-16 22:22:29 +00:00
e23bebcfa3
Init() is only called by Load(); merge calls. Call it before setting m_cmds.
2006-01-15 23:10:50 +00:00
0e4e3aa932
These code paths all call Init() and defOut.Init, including
...
the fall-through case. Merge them. (They're all a little
wrong: they clear m_cmds, which causes a crash later in
ImportOption on the error case, which is what I'm really
trying to fix ...)
2006-01-15 23:03:31 +00:00
cb4739ff31
Use ApplyCommitsScreens. This is simpler, and eliminates one of the
...
few remaining uses of "NEXT_SCREEN" (deviations from the Screen path)
and nonstandard "SM_GoToNextScreen".
2006-01-15 08:04:40 +00:00
Glenn Maynard