actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity
33,814 Commits 3 Branches 0 Tags
2d9db9790581cbbcf4395ebc2ebc0abc32cf4d19
Commit Graph

190 Commits

Author SHA1 Message Date
Colby Klein 31713ac253 Merge pull request #136 from sigatrev/Autoplay-Roll-Combo 
fix for AutoPlay increase combo with "RollBodyIncreasesCombo"
 2014-04-24 05:06:35 -07:00
Colby Klein ee87494252 Merge pull request #137 from sigatrev/TickHolds 
Attempted fix of Tick Holds
 2014-04-24 05:06:20 -07:00
sigatrev c4f7aab9a1 Attempted fix of Tick Holds 
NoteDataUtil::GetTotalHoldTicks() was not counting the last tick of
holds which ended on the last row of the song. Extended the range to
include the last row.

NoteDataUtil::GetTotalHoldTicks() was counting number of rows held, when
it should only count 1 regardless of number( at least to mimic pump )

Player::CrossedRows() was assuming a constant tick rate over the crossed
rows, leading to potentially inaccurate tick counts.

Pump holds were counting "HoldNote_Held" due to capitalization in the
metrics. Fixed metrics and made "IsGame" function case insensitive.
 2014-04-23 21:45:37 -05:00
sigatrev 5e517e1de1 fix for AutoPlay increase combo with "RollBodyIncreasesCombo" 
per issue #125
 2014-04-23 16:10:15 -05:00
sigatrev a3b38117b5 make early judgments broadcast when judgment is triggered 
judgments triggered early were not broadcasting the judgment message
until their row crossed
 2014-04-20 14:27:43 -05:00
Colby Klein 6298a0b950 Merge pull request #94 from sigatrev/MissedHold 
HNS_Missed
 2014-03-16 13:20:12 -07:00
sigatrev 343511f4c3 HNS_Missed 
Added an HNS type to handle holds which are never initialized due to
missed taps. This fixes a long standing issue with
iCurPossibleDancePoints and allows themes to decide how to handled this
case.
 2014-03-16 11:36:40 -05:00
AJ Kelly 95343dc27b Merge pull request #71 from sigatrev/MineTracks 
added iTrack to mine judgment message
 2014-03-07 14:11:54 -06:00
sigatrev f6d44ae85b hold judgment positions with mini 
they weren't scaled to handle the zoom.
 2014-03-03 20:46:47 -06:00
sigatrev 43f9fd70ca added iTrack to mine judgment message 
more information is better.
 2014-03-03 20:37:13 -06:00
Devin J. Pohly da5eb84730 Player: broadcast StepPN message (compat) 
For backwards compatibility, broadcast the old StepP1/2 message in
addition to the new Step message.  New themes, charts, etc. should of
course use the new message with parameters.
 2014-02-20 10:59:49 -05:00
Ben "root" Anderson 82a7184822 Fix ImmediateHoldLetGo 2013-12-20 20:18:42 -06:00
Ben "root" Anderson b61e8783b5 Kill tickholds right away 2013-12-20 19:57:19 -06:00
Ben "root" Anderson 48df0fc0d2 Botched the positioning of this comment, oops 2013-12-19 18:21:09 -06:00
Ben "root" Anderson ee84f9263c Make hold checkpoints a struct Game member, not a metric. It CANNOT be a metric because it affects max DP. 2013-12-19 18:06:07 -06:00
Ben "root" Anderson b4cfbf029c Revert "Don't send HNS_Held / HNS_LetGo when using checkpoint holds" 
This reverts commit 18a0c818cd.

Those events are used for more than just life and scoring.
 2013-12-11 18:53:11 -06:00
Ben "root" Anderson 18a0c818cd Don't send HNS_Held / HNS_LetGo when using checkpoint holds 2013-12-11 18:19:19 -06:00
Flameshadowxeroshin d59b7fd0c0 Don't send combo messages on mine judgments if they don't change combo 2013-11-30 01:41:19 -06:00
AJ Kelly 90fe50a064 add NumTracks param to hold Judgment message 
For SSC compat.  This parameter is redundant, and themers should use
GAMESTATE:GetCurrentStyle():ColumnsPerPlayer() instead.
 2013-09-22 05:13:12 -04:00
Devin J. Pohly 2844703b60 Adjust indentation 
No-op.
 2013-09-07 17:30:52 -04:00
Devin J. Pohly 366cfae8b9 Fix the LastSeen logic for autokeysounds 
We were never actually setting iLastSeenRow, so the if statement wasn't
meaningful anyway.
 2013-09-07 17:28:19 -04:00
Devin J. Pohly 63a31d41d8 Revert "fix visual glitch on autoplay rolls" 
This reverts commit 48975f7f1d.

Fixed one visual glitch but introduced a weirder one.  Revert.
 2013-09-07 16:56:00 -04:00
Devin J. Pohly 48975f7f1d fix visual glitch on autoplay rolls 
When there were tap notes on the same row as the start of a roll, autoplaying
the roll would result in the receptors on other tracks to glow.  This was
because the Step() call would use the roll's head row for a parameter, which
included the other notes.  This changes that parameter to -1 to automatically
use the current row in the song, which makes more sense anyway.

Fixes bug 241.
 2013-08-29 17:04:22 -04:00
Jason Felds 0259af5c80 Prevent possible crash noticed during testing. 2013-07-04 22:54:38 -04:00
Devin J. Pohly 028de88b50 Revert "a shot in the dark." 
This reverts commit 0bd052ed17.

Broke build.
 2013-06-03 12:46:57 -04:00
Flameshadowxeroshin 0bd052ed17 a shot in the dark. 2013-06-02 20:45:26 -05:00
Flameshadowxeroshin 640626e155 make it work 2013-05-29 00:13:09 -05:00
Flameshadowxeroshin 8945797fee Phantom hold fix retry 2013-05-28 23:59:30 -05:00
Jason Felds 76cc364d43 Remove Random Vanish randomizing. 
The mod is still in for "compatibility" sake.
 2013-05-26 00:03:33 -04:00
Devin J. Pohly 9fb376fdad Revert "hold fix: try again?" 
This reverts commit 0ef9b81e02.
 2013-05-22 13:47:36 -07:00
Flameshadowxeroshin 0ef9b81e02 hold fix: try again? 2013-05-16 21:07:00 -05:00
Devin J. Pohly 3f94afafdd Revert "test: try to fix "phantom holds" when JudgeHoldNotesOnSameTogether is enabled" 
This reverts commit 6999f94d38.

This was causing a crash when warping past holds at the end of a chart.
 2013-05-16 21:21:40 -04:00
Flameshadowxeroshin 6999f94d38 test: try to fix "phantom holds" when JudgeHoldNotesOnSameTogether is enabled 2013-05-14 22:54:20 -05:00
Jason Felds 20d94d4b7e Cat is back in the bag. Revert commits. 
A-mods need to be tested more.

...and this is what happens when you forget to
stash changes before a merge. Lesson learned.
 2013-04-19 21:49:55 -04:00
Jason Felds 489a9312fc Forced a merge. Should be good. 2013-04-18 22:58:30 -04:00
Devin J. Pohly 4eb8d72325 Player: add column as a parameter to StepMessage 2013-02-04 22:25:54 -05:00
Jason Felds 1b8da256e1 Fix warp/mine stutter that could take place. 
Fixes commit 535ef4d: thanks phantom.
 2013-02-03 14:14:05 -05:00
Devin J. Pohly 106838cf64 fix warning about const float 2013-01-31 13:35:39 -05:00
Devin J. Pohly 1a150b96d5 Player: remove fake loop, simplify hopo logic 2013-01-25 18:18:13 -05:00
Jason Felds 7bbeb689db Another batch of gotos gone. 
Using the fake infinite loop style to avoid the
(stupid) windows constant evaluation pedantic warning.
 2013-01-24 23:07:16 -05:00
Devin J. Pohly ce507b9800 use empty TimingData in Steps to signify fallback on Song timing. 
This required using the new Steps::GetTimingData function and the allowEmpty
parameter to TimingData::TidyUpData when appropriate, as well as clearing the
TimingData to remove step timing rather than coping the song timing over it.

Fixes some odd editor behavior when changing song timing, and is overall a
slightly less hacky way of doing things.
 2013-01-23 14:51:18 -05:00
Devin J. Pohly bd0e2074ad replace ASSERT(0) with useful fail messages 2012-12-27 16:59:35 -05:00
Jason Felds 1fc16698ba War on -Werror, part 12: explicit bool usage. 
It may save a few cycles, but it's best to be
explicit on boolean operations, especially with
ASSERT.
 2012-12-27 11:38:53 -05:00
Jason Felds bddbed7e7e war on -Werror, part 11: const int -> float loss. 
Had to work around the inline static const int rule
to do it, but at least there is no data loss now.
 2012-12-27 11:13:41 -05:00
Jason Felds e86aeb66a8 war on -Werror, part 10: more informals. 2012-12-27 11:01:51 -05:00
Devin J. Pohly 7aac8c5ae3 war on -Werror, part 2: unused variables and dead code 2012-12-26 20:35:02 -05:00
AJ Kelly 3ca54f1000 [Player] Keysounds now respect the volume settings. Sourced from hanubeki-modified-sm-ssc rev. 16fc5b714582 [hanubeki] 2012-03-28 19:24:27 -05:00
Jason Felds 73cc1bdaae [sm5a2futures -> default] Not that much changed... 
Mainly minor stuff. Time this gets brought in.

The other multi chain branches...
unsure of their fate. May need to be redone again
since not everyone is happy with its progress.
 2012-03-18 22:05:07 -04:00
AJ Kelly 753cdae2fc [Player] Changed default Hold window to 0.250f like in 3.9; not sure when or why it got changed. 2012-03-04 21:42:43 -06:00
Jason Felds 08d3abbe44 New branch: [sm5a2futures] 
Want to make sure we don't cause conflicts for future 1a builds.

This commit: change the sentinel for launching attacks immediately.

This way, songs with negative gaps can have attacks work here.

Thanks to Saturn for the assist.
 2012-02-23 22:50:03 -05:00