Commit Graph
23479 Commits
Author SHA1 Message Date
Glenn Maynard f4136c72e6 simplify 2006-11-02 06:47:48 +00:00
Glenn Maynard 083c20497c use LuaThreadVariable 2006-11-02 06:12:48 +00:00
Glenn Maynard dab10ec033 const 2006-11-02 05:47:32 +00:00
Glenn Maynard 524b2418c7 use LuaThreadVariable 2006-11-02 05:42:47 +00:00
John Bauer 592c27996d Originally, the AdjustSync class always saved to disk, even in edit mode.
In edit mode, though, AdjustSync should only save to memory, giving the
user a chance to save later.  This change adds a SongChanged message
to the MessageManager.  Making the ScreenEdit class listen to this
message allows the AdjustSync class to mark a song as dirty rather than
saving it to disk when in edit mode.

R=steve chekoway
2006-11-02 05:30:02 +00:00
John Bauer db38f88c39 In ScreenEdit, figure out whether a song is dirty or not by keeping track
of a m_bDirty bit, not by reusing the m_bHasUndo bit.  This fixes two bugs:
1) Save & revert wouldn't clear the dirty bit before
2) Some operations such as tempo and stop changes wouldn't make
the song dirty

R=Steve Chekoway
2006-11-02 04:57:17 +00:00
Glenn Maynard 39c60364be remove global 2006-11-02 04:54:39 +00:00
Glenn Maynard 32820b65e3 use LuaThreadVariable 2006-11-02 04:36:05 +00:00
Glenn Maynard a3e5c4dae1 shorthand 2006-11-02 04:33:26 +00:00
Glenn Maynard 816d3f1155 prefer preincrement 2006-11-02 04:28:16 +00:00
Glenn Maynard 854b259ef1 Replace actor parameters with thread variables.
This is to provide parameters to loading Actor definitions, in a way that
does not need to be explicitly propagated to nested definitions; I want
loading a sub-definition to remain a simple function call with no mandatory
(prescribed) parameters.  This provides a general context to pass information
to Lua about what it's loading, such as LoadingScreen.

These are scoped to the running thread, unlike global variables.  This prevents
possible threading problems.

All thread variables are scoped: set a variable, do something, unset it; when
finished, all thread variables are unset.

These are no longer available after load.  By design, to use these later,
use upvalues:

local color = lua.GetVar("color");
return Def.Quad {
    OnCommand=cmd(diffuse,color);
}
2006-11-02 04:23:19 +00:00
Glenn Maynard 1e21152174 fix compile 2006-11-02 03:47:02 +00:00
Glenn Maynard 4cdec422c1 add lua 2006-11-02 03:34:56 +00:00
Steve Checkoway d571048d2b This is overkill for such a simple operation. Doing it this way should optimize to a single add and it doesn't have any of the problems associated with breaking aliasing rules. 2006-11-01 11:30:41 +00:00
Steve Checkoway cf3a76b600 Doing these conversions through a union is not safe either but more to the point, it isn't what's happening here. 2006-11-01 11:19:52 +00:00
Steve Checkoway e3e5cf77e5 Don't include Foreach.h in RageUtil.h which does not use it. Instead, include it in the individual files that actually use it. 2006-11-01 11:18:46 +00:00
Steve Checkoway b7493d25f7 Style. 2006-11-01 10:58:59 +00:00
Steve Checkoway f241645ff5 Unneeded. 2006-11-01 10:58:29 +00:00
Steve Checkoway 30d9410b65 Unneeded. 2006-11-01 10:45:51 +00:00
Steve Checkoway c0a119bf10 Unneeded. 2006-11-01 10:34:20 +00:00
Steve Checkoway 5f851a47ca Make GetApplicableFiles() static and don't create a loader unless it can load from that directory. 2006-11-01 10:09:13 +00:00
Steve Checkoway a9e04a845a Unused. 2006-11-01 09:42:44 +00:00
Steve Checkoway 0276292b9f Revert. The encoding concerns brought up on the mailing have not been addressed. 2006-11-01 08:45:29 +00:00
Glenn Maynard 00b1b7af74 simplify 2006-11-01 05:42:15 +00:00
Steve Checkoway b5e66c2712 "Foo\tBar - Baz" should be parsed as title = "Foo", subtitle = "Bar - Baz", not title = "Foo\tBar", subtitle = "- Baz" 2006-10-31 10:24:24 +00:00
Glenn Maynard 708fa0166e move lock into pImpl 2006-10-31 01:23:25 +00:00
Glenn Maynard a7c785394a fix on/off symmetry (off hides, on didn't unhide) 2006-10-31 00:11:32 +00:00
Glenn Maynard 1c6528b61b revert. Don't use the "remove things randomly until it seems to work"
approach to fixing bugs.
2006-10-31 00:09:48 +00:00
John Bauer 6b02440547 Fixed: problem where ScreenMapControllers would be blank the second
time the user loads the page
2006-10-30 15:09:17 +00:00
Chris Danford 499444645c fix "search for nearest row finds already judged rows"
TNS_None on strum miss, not TNS_HitMine.  This was filling NoteData with tons of new notes
2006-10-30 12:59:15 +00:00
Steve Checkoway 9ef4cf40e0 Scale GetTotalPossibleStepsSeconds() by fMusicRate. Fixes ComboGraph and GraphDisplay when using a different music rate. 2006-10-30 10:00:43 +00:00
Steve Checkoway 796aa48ba2 Fix life meter. 2006-10-30 09:23:58 +00:00
Steve Checkoway 021a4eb3aa ScreenEvaluationSummary is nearly the same as ScreenEvaluationStage. The Summary screen was not drawing correctly though. Just use the same Bar(Possible|Acutal).* as SEStage. 2006-10-30 08:59:34 +00:00
Steve Checkoway 5ba98d2584 unused. 2006-10-30 08:38:47 +00:00
Chris Danford 1b4387a7d9 add HoldActiveIsAddLayer 2006-10-30 03:04:41 +00:00
Jason Felds 4dc82ae097 Fix up the #SMxxx tag output (thanks xbskid). 2006-10-30 01:52:20 +00:00
Glenn Maynard f9496f96d9 remove another specialized "parse and evaluate string" 2006-10-29 20:52:25 +00:00
Glenn Maynard ff2b6f697c PrepareExpression only used in one place and simple; merge down 2006-10-29 20:48:02 +00:00
John Bauer 50a3420683 Fixed: Error dialog + blank line instead of "Insert Coin" on the
Config Key & Joystick Mappings page.

Still broken: exitting that page and reloading it causes a blank screen.
2006-10-29 12:29:49 +00:00
Steve Checkoway 53a0cd432e fix 2006-10-29 09:34:57 +00:00
Glenn Maynard 6b240f51ab revert. Self-consistency over blind emulation; no rationale was given
for this change.  (I'm sort of inclined to remove this entirely and do
something new, though ...)
2006-10-29 03:58:41 +00:00
Steve Checkoway 0e8a2ecd5b Fix brain dead g++ 4.0.1's inability to have private constants without declaring storage for them. 2006-10-28 08:21:21 +00:00
AJ Kelly ca674fc38d now that these are apparently a part of ScreenGameplay, revert to the old ones since they're less distracting. 2006-10-28 05:04:27 +00:00
Jason Felds 3a3102debe Use the real formula for normal mode, and our own for courses. 2006-10-28 04:03:52 +00:00
Chris Danford 3c3359c163 add Strum. This needs cleanup 2006-10-27 18:09:39 +00:00
Chris Danford 0b5f456a42 add PlayerInitCommand
add ShowBoard, ShowBeatBars
2006-10-27 10:20:43 +00:00
Chris Danford 17ca30a047 add fret/strum
add PlayerInitCommand
2006-10-27 10:19:08 +00:00
Chris Danford a1dac5f2fc add scrolling board 2006-10-27 10:14:23 +00:00
Chris Danford a1d9523b9c incremental linking fixes "linker never finishes" on my machine 2006-10-27 09:31:59 +00:00
Glenn Maynard da024345f3 cleanup 2006-10-27 05:53:23 +00:00