join on the first JoinInput; later (if more coins are input), join
on coin input if there's already a player joined. This means coin
inputs never join the first player, which implies that coin inputs
can only autojoin a player if it's in a place where players are supposed
to be joined.
This avoids problems with joining too early, eg. in Attract before
Reset.
The hack to LoadAllCommands when playing a command was leading to weird interactions: If a theme element contained an OnCommand, it would cause the rest of the commands defined in metrics to not be loaded.
Screens typically have two general simple models of transitioning;
either the menu elements transition out, or we drop a fade on top
of everything. The former leaves the background in place, the
latter doesn't. Transitioning is usually used when we're going
to a screen with the same background; fading is used otherwise.
(There are combinations of these, and more complex modes, but
these are the basics.)
Traditionally, cancelling has always wiped. It usually goes back
to the title menu, which rarely has the same background; and it's
an uncommon path, so it's not worth setting up a full transition
for. However, for cases where we don't go all the way back, this
is incorrect; it looks very strange to press escape in the options
submenu or the player options menu, and to have it wipe the screen.
I've dealt with this in the past by setting up a "cancel" transition
that simply runs "Off" and waits. That works, but it's a pain, since
the wait duration needs to line up with the length of the transition.
Instead, add a transition mode "CancelTransitionsOut" that causes
Cancel to run the Out transition directly. (This also plays the
start sound, due to a discrepency right now: with Out, it's the
screen's job to play the sound, but with Cancel, it's the transition's
job. Figure that out later ...)
Ultimately, we should be able to have full CancelCommand transitions
if we want, but the SWME TweenOnScreen/TweenOffScreen code transition
needs to be completed first (replacing individual transitions with a
single "On"/"Off" command).
Chris Danford