Commit Graph

83 Commits

Author SHA1 Message Date
Kyzentun fb1a251b7a Changed many places that used RageException to use ReportScriptError instead. Wrote ScreenOptionsExample.ini as documentation example for the OptionRow system. Rewrote gamecommands.txt to include all GameCommands. Fixed Commands::GetOriginalCommandString to insert the semicolons that separated the original commands. Changed nonsensical boolean |= true statements in GameCommand.cpp to just use =. Added protection to ReportScriptError to keep it from recursing through itself when an error occurs in error reporting. Added UseAbort option to ReportScriptError for places that want to use an AbortRetryIgnore dialog to query the user. Added ScriptErrorMessage for places that need to handle the warning/dialog part separately. Added logging flag to MESSAGEMAN so that all messages broadcast can be logged when desired. Changed OptionRowHandler::LoadInternal to return a boolean success value as part of error handling. 2014-07-12 14:59:10 -06:00
Dan Guzek 7d13a9963b allow button messages in SSM's SelectMenu
This allows themers to make use of SelectMenuInputMessageCommand even
if they have SelectMenuChangesDifficulty set to true in their Metrics.

Neither _fallback nor Default use SelectMenuInputMessageCommand and,
for that matter, no theme I'm aware of does (perhaps because it's
essentially inaccessible as it is).

I use this to detect if a player presses START while holding SELECT on
SSM.  This is possible with the existing code system, but that
CodeMessage does not fire until the player lets go of both buttons.
This allows the themer to check for that button combination more imm
ediately.
2014-06-01 21:28:17 -04:00
Kyzentun 0dfb131291 Created SongOptions Lua interface with a similar design to the PlayerOptions interface. Moved enums that were inside SongOptions out and made them Lua accessible. Removed sAutosyncType and associated things from AdjustSync.cpp because it was unused. Added DefaultNilArgs and FArgGTEZero to LuaBinding as helpers. Moved INTERFACE defines from PlayerOptions.cpp to OptionsBinding.h. 2014-05-03 19:27:32 -06:00
Devin J. Pohly 38c1e12a6f Fix crash when sorting in Oni mode 2013-05-30 21:06:52 -04:00
Devin J. Pohly ce507b9800 use empty TimingData in Steps to signify fallback on Song timing.
This required using the new Steps::GetTimingData function and the allowEmpty
parameter to TimingData::TidyUpData when appropriate, as well as clearing the
TimingData to remove step timing rather than coping the song timing over it.

Fixes some odd editor behavior when changing song timing, and is overall a
slightly less hacky way of doing things.
2013-01-23 14:51:18 -05:00
Devin J. Pohly d13ac7e7a2 modify Input() on screens to return boolean 2013-01-12 22:48:38 -05:00
Marcio Barrientos b39137e1be Stop the musicwheel when the optionslist is oppened, this fixes a bug when you call the optionslist using a custom code detector
Small fix in gamestate
2013-01-03 03:17:30 -06:00
Colby Klein 6bf3c9ed37 Fix mouse events being eaten on SSMusic. 2012-12-28 17:49:53 -08:00
Devin J. Pohly bd0e2074ad replace ASSERT(0) with useful fail messages 2012-12-27 16:59:35 -05:00
Jason Felds 1fc16698ba War on -Werror, part 12: explicit bool usage.
It may save a few cycles, but it's best to be
explicit on boolean operations, especially with
ASSERT.
2012-12-27 11:38:53 -05:00
Jason Felds e01537405f war on -Werror, part 8: more informals.
General guide: if the parameter name and its typings
match almost exactly, the name goes away.
Otherwise, it's commented out to allow for some
documentation.
2012-12-27 00:00:28 -05:00
Marcio Barrientos 072f096214 Only unchose steps if menutimer have more than 10 seconds, twoparttimerseconds and allowing to unchose the song makes a "infinite timer" bug 2012-11-26 15:16:00 -06:00
AJ Kelly 6504580576 [ScreenSelectMusic] Fix an issue where Control+<Letter> wouldn't work. 2012-07-10 01:39:02 -05:00
AJ Kelly ce4366e605 [ScreenSelectMusic] Added PlaySoundOnEnteringOptionsMenu metric (true/false). 2012-03-01 21:28:15 -06:00
Colby Klein 2e5d5f3697 Add some Lua bindings for the music wheel and items. 2011-12-20 01:47:49 -08:00
AJ Kelly 9793a08b16 [ScreenSelectMusic] Fixed Rave difficulties not being synced on late join. Fixes issue 577. 2011-11-06 16:44:23 -06:00
AJ Kelly 85d3acb651 a todo for later 2011-10-07 13:51:00 -05:00
AJ Kelly 5ed3a8a80e still want to get this working one day... 2011-09-07 21:00:49 -05:00
AJ Kelly 5238a51770 [ScreenSelectMusic] Added IdleCommentSeconds metric and "ScreenSelectMusic IdleComment" announcer sound. 2011-08-07 19:09:33 -05:00
AJ Kelly d20501c547 attempt to fix a crash when pressing ctrl+letter during the transition 2011-07-20 16:25:48 -05:00
Jason Felds dbdab4759e [Xcode4] May as well fix switch warnings.
Still need some assistance for the linker error.
2011-07-20 11:11:04 -04:00
Jason Felds 0a7b9ce170 Some respect for OOP. (MasterPlayerNumber) 2011-06-06 20:40:11 -04:00
Jason Felds 6e72870fd0 [default -> splittiming] Caught up. 2011-05-15 01:00:05 -04:00
AJ Kelly f1bc24160b remove old note, reorganize dead code slightly 2011-05-14 22:41:57 -05:00
Jason Felds f7d1b46f72 [splittiming] Bringing it down. (91) 2011-05-09 21:03:30 -04:00
AJ Kelly 054747b55c [ScreenSelectMusic] Added NullScoreString metric. 2011-05-02 17:15:41 -05:00
AJ Kelly e200734a6f another pedantic edit 2011-05-01 13:41:50 -05:00
AJ Kelly 6e6d541124 code cleanup 2011-05-01 13:30:53 -05:00
Jason Felds a9a98e6529 Line endings hate me now. 2011-04-29 15:03:05 -04:00
Marcio Barrientos c048e7598c Add a lua function to open the optionslist in ScreenSelectMusic
without the select button, OpenOptionsList(pn)
2011-04-28 18:40:02 -06:00
AJ Kelly dca2f976b2 [FadingBanner] Added BannerRoulette, BannerRandom, and Banner(Custom Item Name) commands. 2011-04-22 05:09:47 -05:00
AJ Kelly a14d760e0c [ScreenSelectMusic] Made score frame into an AutoActor, changed the filename from "score frame p1" to "ScoreFrame P1" for consistency with other elements. 2011-04-13 03:41:09 -05:00
AJ Kelly 6a458cc836 small comment changes 2011-04-03 16:00:46 -05:00
Jason Felds a085d0d1da Line endings...be normalized! 2011-03-17 01:47:30 -04:00
Jason Felds e9df4832f6 Bring shadowed variables back from the dark side.
Alright Colby, happy now?
2011-03-14 02:54:11 -04:00
AJ Kelly c28845a8dc Added custom MusicWheel items.
[ScreenSelectMusic] Add GetMusicWheel Lua binding.
2011-03-08 19:28:40 -06:00
AJ Kelly 7f31b13bb0 comment/cleanup 2011-03-02 21:17:40 -06:00
AJ Kelly 308325b54c still thinking about using the mousewheel to scroll the musicwheel 2011-02-23 12:47:05 -06:00
Jason Felds 9d13036e08 Add @briefs to the Luna classes.
Yeah...there was a lot. */
2011-02-19 12:26:18 -05:00
Jason Felds 00257e7995 Consistent semicolon use.
This is C++, not Python!
2011-02-18 20:40:51 -05:00
AJ Kelly 072b7059ff eventually, I'd like the mousewheel to scroll the MusicWheel. 2011-02-15 23:25:30 -06:00
AJ Kelly 49a7b15eb1 Add RouletteTimerSeconds metric to ScreenSelectMusic 2011-02-09 13:11:22 -06:00
AJ Kelly 9bee942eef screenshot bug is long gone, allow profiles to get loaded on player join on SelMusic again 2011-02-09 12:14:36 -06:00
AJ Kelly 0ebd8b8c80 slight edit of no real significance 2011-02-08 18:20:43 -06:00
AJ Kelly 4b66853e38 small nitpick 2011-02-08 02:13:31 -06:00
AJ Kelly 0d4a450040 small tab change 2011-02-08 01:33:55 -06:00
AJ Kelly 036b23e9d3 add Banners for various SortOrders. (Group and Recent not included for various reasons) 2010-12-23 22:31:52 -06:00
AJ Kelly bcf16846b5 revert change that caused crashes 2010-12-17 01:19:06 -06:00
Alberto Ramos 902d2d4368 small barely notable changes 2010-12-14 17:41:29 -07:00
AJ Kelly 62e4cac758 Make Ctrl+[letter] work as expected in Artist sort. original code by midiman, simplified by AJ; fixes issue 172. 2010-08-26 17:48:00 -05:00