Commit Graph

54 Commits

Author SHA1 Message Date
Kyzentun be64c240c3 Added Swap Up/Down option to Edit Alter Menu. 2014-08-30 00:47:07 -06:00
sigatrev 82cb4a198d Enums for TapNoteType, TapNoteSubType, and TapNoteSource
I intend to make additional useful information available on judgments,
such as TapNoteType and TapNoteSubType( for hold judgments ).

I am submitting this part as a separate pull request because it is more
generally applicable to anything TapNote related.
2014-08-02 00:38:48 -07:00
Kyzentun 1a18d64f09 Added revalidation scheme to NoteData's all_tracks_iterator so that it can be made valid again after the NoteData is transformed by something adding or removing steps. This fixes the crash on courses that use transform mods on the second song. ITG2's Getting Started is an example. 2014-08-02 00:38:38 -07:00
sigatrev c4f7aab9a1 Attempted fix of Tick Holds
NoteDataUtil::GetTotalHoldTicks() was not counting the last tick of
holds which ended on the last row of the song. Extended the range to
include the last row.

NoteDataUtil::GetTotalHoldTicks() was counting number of rows held, when
it should only count 1 regardless of number( at least to mimic pump )

Player::CrossedRows() was assuming a constant tick rate over the crossed
rows, leading to potentially inaccurate tick counts.

Pump holds were counting "HoldNote_Held" due to capitalization in the
metrics. Fixed metrics and made "IsGame" function case insensitive.
2014-04-23 21:45:37 -05:00
Ben "root" Anderson 6dcc227327 New NoteDataUtil to count hold ticks in a NoteData. Significant overhaul to make PossibleDancePoints consider hold ticks, using said function. 2013-12-19 23:46:01 -06:00
Devin J. Pohly 1bf8e07584 NoteDataUtil: I thought this control structure looked familiar... 2013-01-26 00:05:46 -05:00
Jason Felds dacb721e4b goto -> fake infinite. 2013-01-24 23:33:42 -05:00
Jason Felds 3ec76f4dc6 More goto removals. 2013-01-24 23:29:54 -05:00
Devin J. Pohly bd0e2074ad replace ASSERT(0) with useful fail messages 2012-12-27 16:59:35 -05:00
Jason Felds a15cbc431d War on -Werror, part 14: More hodgepodge. 2012-12-27 12:45:04 -05:00
Jason Felds 1f024cd739 [backwards] Switches in switches: need a break. 2011-10-16 16:43:20 -04:00
Jason Felds 68061b13c5 [backwards] Add appropriate comment for devs. 2011-10-16 16:33:33 -04:00
Jason Felds 142a62aa6e [backwards] Have Backwards fallback to Mirror.
Not all gametypes require Backwards: they will fall
through to Mirror. Otherwise, catch it here.
2011-10-16 15:50:13 -04:00
Jason Felds e8f95dd28e [backwards] Prepare PlayerOptions version. 2011-10-16 15:34:29 -04:00
Flameshadowxeroshin d8a7d837be change in wording 2011-10-06 22:47:33 +00:00
Jason Felds b69521c3c6 More accurate left, right, and mirror pump mods.
BIG thanks to Hudson Felker and Bill Shillito.
2011-10-04 00:53:33 -04:00
Jason Felds 02f20754f6 More accurate comment. 2011-09-10 21:54:42 -04:00
Jason Felds 992dbe665a If we have asserts/failures, may as well be clear. 2011-09-10 21:48:54 -04:00
Jason Felds fd5acb7ee9 Use our macros. 2011-09-10 21:33:00 -04:00
Jason Felds dbdab4759e [Xcode4] May as well fix switch warnings.
Still need some assistance for the linker error.
2011-07-20 11:11:04 -04:00
Jason Felds 807c933393 Revert back to how it was.
Going to take the cheap route for now.
2011-07-11 00:18:07 -04:00
Jason Felds 4b76e30a5a Experimental: taps to count TAPS only.
May need manual recache. May be reverted.
2011-07-10 23:15:33 -04:00
Jason Felds 32ee68dcf9 Don't have AutoKeysounds count for radar values.
Since this affects the loading of files, it's
time for another cache reload. *groan*
2011-06-20 19:13:46 -04:00
Jason Felds 3d155c9970 NOW I start moving prototypes to headers?
I need to be more consistent...gah, hungry.
2011-06-12 19:35:24 -04:00
Jason Felds fc9f07158a 99% fix scoring with warps and fakes.
Now all charts can seek 100%.

This does force yet another cache reload.

Hopefully it won't slow first loads too much.
2011-06-08 16:14:11 -04:00
Jason Felds 5c83d529ab Remove faulty shortcut code for hand calcs.
Unfortunately, to maintain accuracy, this
will invalidate the ca-- *beaten to the floor
with the nya cat*
2011-06-06 23:00:07 -04:00
Thai Pangsakulyanont 6ca0cd1e70 optimizations to NoteDataUtil::CalculateRadarValues, results in 3x faster loading. 2011-06-01 16:01:14 +07:00
Jason Felds b2a5a68b4a Super Shuffle works with fakes now. 2011-05-24 15:01:52 -04:00
Jason Felds 9cb41af5f4 [splittiming] All but ScreenEdit. (67) 2011-05-09 21:11:33 -04:00
Jason Felds 6ae77039c9 Consistent measure comments with internals.
For some time, we had the text file use // measure 1
when it was measure 0 internally.

As usual, revert if this is a bad idea. It's just bugging me.
2011-05-04 16:48:48 -04:00
Thai Pangsakulyanont 8d80ddedf2 Compress/Expand shall not break apart hold notes that overlaps the start/end marker. 2011-03-19 19:38:45 +07:00
Jason Felds 3c3618f28d Fix Compress/Expand Steps bug. 2011-03-17 15:13:30 -04:00
Jason Felds a085d0d1da Line endings...be normalized! 2011-03-17 01:47:30 -04:00
Thai Pangsakulyanont b21487b8fa fix some misaligned charts by making it ignore time signatures before notes.
for full explanation see the diff.
2011-03-16 17:44:54 +07:00
Thai Pangsakulyanont b26867a52c remove unused variables from PlaceAutoKeysound (5=>3) 2011-03-16 17:02:05 +07:00
Thai Pangsakulyanont 52c2629868 merge+fix NotesLoaderBMS.cpp 2011-03-15 21:57:04 +07:00
Jason Felds e9df4832f6 Bring shadowed variables back from the dark side.
Alright Colby, happy now?
2011-03-14 02:54:11 -04:00
Thai Pangsakulyanont c1f4967f1c merge
+ support o2mania style BMS (7 keys)
+ move notes to autokeysound when reducing tracks
2011-03-09 19:24:15 +07:00
Jason Felds 526a76dea4 Experiment: no stretch jumps for pump possible.
To the pump players: give this a shot please.
2011-03-06 19:16:24 -05:00
Jason Felds 3336840adf Factor out common code.
...how many more TapNotes can we squeeze in here anyway?
2011-02-28 10:23:27 -05:00
Jason Felds ccf92c7c1c Add No Lifts and No Fakes transform mods. 2011-02-28 10:02:23 -05:00
Jason Felds 86f3bf7e79 Radar branch: add Fakes wherever it made sense.
Need to check metrics, then ready to test.
2011-02-27 22:36:04 -05:00
Jason Felds 2c70b65711 Fix doxygen warnings.
The code seems to run fine, but please TEST THIS.
Revert this if required.
2011-02-19 00:48:42 -05:00
Jason Felds b4e45fe65b Comment fix. 2011-02-11 23:52:44 -05:00
Jason Felds 40f12aa61c Hack for the hack. Fix cache bug.
Maybe all notes should be assigned a player
number regardless of mode here: I do not feel
NoteDataUtil should depend on Style.h like this.
2011-01-02 12:00:25 -05:00
Jason Felds 1ff6313c65 Use hack to fix routine mode saving.
This could use some improvements probably.
2011-01-02 01:18:08 -05:00
Jason Felds 108b7cd097 Friendlier error message, showing the problem.
Of course, the problem now is how do we fix it...
2011-01-02 00:27:38 -05:00
AJ Kelly 382333ee23 hopefully make this crash message more informative 2010-12-30 23:29:52 -06:00
AJ Kelly 53a8a435ef remove unfinished karaoke mode 2010-08-19 21:24:35 -05:00
AJ Kelly a7da3658d1 fix up soft shuffle to not use a goto 2010-07-04 15:10:51 -05:00