b4e02821e8
Revert "Improve handling of errors in lua functions and speed up calls. ( #1427 )"
...
This reverts commit f10e3ae36a
2017-04-04 17:21:55 -07:00
f10e3ae36a
Improve handling of errors in lua functions and speed up calls. ( #1427 )
2017-04-04 11:36:23 -07:00
d496f8145c
Noteskin name in PlayerOptions needs to be compared case-insensitive when comparing PlayerOptions structures. The old code that used != probably relied on RString::operator!= misbehaving.
2015-11-05 21:56:43 -07:00
c4fed9747c
Fixed crash on no args to AddInputCallback. Clear steps for all players when deleting on ScreenEditMenu. Changed assert message in ApplyDerivedType to be useful. Fixed typos in OptionRowHandler message and EditHelpText.
2015-02-26 14:51:54 -07:00
3fb36af157
Separate styles for players. Notefields positioned between margins. Edit mode works for kickbox.
2014-12-09 22:27:00 -07:00
3945a4a34b
Improved three-key support. Default theme should be completely usable with three-key cabinets if ThreeKeyNavigation pref is true. Added ThreeKeyNavigation pref. ScreenOptions:NavigationMode metric now uses that pref to decide between normal and toggle modes. Added GoToFirstOnStart to OptionRowHandlerLua so an option row can control that behavior. Rewrote input for default's ScreenSelectProfile to use an input callback to take advantage of menu button mapping. Fixed inconsistent indentation in ORHL documentation.
2014-08-02 00:38:46 -07:00
4343a99ea9
Changed many parts of GameCommand to improve error reporting. Fixed GameCommand setpref to not set when loading the command. Minor fix to ScreenOptionsExample.ini to explain that SongInCurrentSongGroup is unusable. CommonMetrics, CourseContentsList, HoldJudgent, OptionRowHandler all have minor changes to fix crashes on malformed theme data.
2014-08-02 00:38:25 -07:00
5df80b6e0e
Changed many places that used RageException to use ReportScriptError instead. Wrote ScreenOptionsExample.ini as documentation example for the OptionRow system. Rewrote gamecommands.txt to include all GameCommands. Fixed Commands::GetOriginalCommandString to insert the semicolons that separated the original commands. Changed nonsensical boolean |= true statements in GameCommand.cpp to just use =. Added protection to ReportScriptError to keep it from recursing through itself when an error occurs in error reporting. Added UseAbort option to ReportScriptError for places that want to use an AbortRetryIgnore dialog to query the user. Added ScriptErrorMessage for places that need to handle the warning/dialog part separately. Added logging flag to MESSAGEMAN so that all messages broadcast can be logged when desired. Changed OptionRowHandler::LoadInternal to return a boolean success value as part of error handling.
2014-08-02 00:38:24 -07:00
cc548a8cb5
Moved error reporting to ScreenSystemLayer error.lua. ScreenSystemLayer overlay/default.lua restored to previous. Error messages are now broadcast with the ScriptError message instead of SystemMessage. Added show/hide error messages toggle and clear error messages to debug menu. Nuked ScreenConsoleOverlay for being unfinished and duplicating ScreenSystemLayer. Changed Actor:tween and Tween::CreateFromStack to use ReportScriptError on invalid tween params. Changed some OptionRowList things to use ReportScriptError on invalid metrics.
2014-08-02 00:38:21 -07:00
a74a49af78
Changed many uses of Dialog::OK and LOG->Warn to use ReportScriptError.
2014-08-02 00:38:18 -07:00
95fe1a17e9
Replaced every use of lua_call with RunScriptOnStack. Modified RunScriptOnStack to report an error to log and system message using a passed in context string. Modified every use of RunScriptOnStack to avoid crashing so that the reported error can be seen.
2014-08-02 00:38:17 -07:00
dcf819d297
Moved all sanity checking for OptionRowHandlerLua to a separate function so that a malformed row does not crash StepMania, and instead prints an error to the log file, and creates a row that does nothing. Added AllowAnything arg to CheckEnum.
2014-06-25 12:08:57 -06:00
045e9edcdd
Added ArbSpeedMods function for a better way of setting speed modifiers. Added NotifyHandlerOfSelection to OptionRowHandler to support this. Changed exceptions thrown by OptionRowHandlerLua into log warnings because crashing out is not helpful to themers. Fixed SetEnabledForPlayers in OptionRowHandlerLua to correctly read the PlayerNumber enum. Removed silly git add Docs/Themerdocs/Examples/OptionRowHandlerLua.lua and second check for ExportOnChange.
2014-06-19 06:41:18 -06:00
900d04e624
replace gotos with if blocks where appropriate
2013-01-25 17:57:03 -05:00
1fc16698ba
War on -Werror, part 12: explicit bool usage.
...
It may save a few cycles, but it's best to be
explicit on boolean operations, especially with
ASSERT.
2012-12-27 11:38:53 -05:00
e01537405f
war on -Werror, part 8: more informals.
...
General guide: if the parameter name and its typings
match almost exactly, the name goes away.
Otherwise, it's commented out to allow for some
documentation.
2012-12-27 00:00:28 -05:00
4f07a0ea8b
war on -Werror, part 7: start informal params.
...
I'm preserving our numbering Pohly. ;)
2012-12-26 23:23:59 -05:00
778ce8a288
[ScreenOptionsMaster] Added StepsRowLayoutType metric. (Valid values are ShowAllInRow or ShowOneInRow.)
2012-02-08 23:49:42 -06:00
3d8174dd03
Restore proper edit behavior sans metric.
...
...we seriously need a new way of doing this.
2011-07-14 10:59:59 -04:00
5bec1e3e76
Add comment.
...
This really seems like something that should be in lua.
2011-07-12 15:01:50 -04:00
e67324c5af
Add StepsUseChartName metric.
...
This is in ScreenOptionsMaster.
To the C++ guys: please don't yell at the goto.
2011-07-12 14:51:52 -04:00
da51e26d07
Standardize conversion processes.
...
Too many arguments for or against the many methods:
stick to one inside a common function.
This commit will force recompilation of many files.
2011-05-11 15:58:31 -04:00
a085d0d1da
Line endings...be normalized!
2011-03-17 01:47:30 -04:00
81ccc7daba
Quickly variables! Into the magic mirror!
2011-03-14 03:32:07 -04:00
f2e7954054
various cleanup/comment changes
2011-02-27 00:52:32 -06:00
d7caea9f0a
[OptionRow] Added GetLayoutType() and GetSelectType() Lua bindings.
2011-02-21 03:18:37 -06:00
0755d0f3b9
comment/whitespace editing
2011-02-09 17:42:16 -06:00
0a4323fd02
cleanup
2010-07-17 02:44:30 -05:00
b40f144f1a
small comment/cleanup
2010-07-03 18:07:17 -05:00
dca9182138
various cleanup and commenting
2010-03-14 19:46:05 -05:00
60b86919ba
[Player] CheckpointsFlashOnHold metric added (bool). also cleanup/comment/etc.
2010-02-24 02:40:36 -06:00
3e51544930
Initial commit.
2010-01-26 21:00:30 -06:00
80057f53cd
smsvn -> ssc-hg glue: rearrange directory structure
2013-06-10 15:38:43 -04:00
Colby Klein