90176a1f1c
Fix for code scanning alert: Multiplication result converted to larger type
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-05-25 00:29:25 -07:00
72b3590097
Fix for code scanning alert: Multiplication result converted to larger type
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-05-25 00:28:38 -07:00
44f5d8932a
Include <utility> for std::swap
2025-05-23 23:39:55 -05:00
7792a82e7a
OS-agnostic log warning for invalid sound driver entry.
2025-05-23 19:49:42 -07:00
45925badfd
Update Windows build flags
...
/MP2 limits the build processes to a maximum of 2. Many CPU's nowadays have more than two cores, so the integer specifier is removed so that the build is not artificially constrained to two cores.
/FS allows multiple compiler processes to write to the .pdb file; it should be used in conjunction with /MP to speed up the build.
/permissive- disables certain MSVC-specific extensions and follows the C standard more closely. Using this flag should help to ensure behavior matches gcc & clang a little more closely.
Note, /utf-8 does NOT build the program with Unicode support. It merely indicates to the compiler that the source files are using UTF-8 encoding.
2025-05-23 19:47:21 -07:00
71cb44bde3
Make SetThreadPrecedence return a std::string
2025-05-22 20:08:56 -07:00
6a29f651c7
Remove implicit conversion operator from RString to const char* (macOS)
...
Tested via CI (don't have a Mac).
2025-05-22 20:08:56 -07:00
0e00f57e45
sample udev rules to include hidapi
2025-05-22 11:42:50 -07:00
69f6a14935
additional HidDevice logging error conditions
2025-05-22 11:42:50 -07:00
36e2dcbce8
Bring LinuxPacDrive back as GenericHID lights driver
...
This is actually generalized old LinuxPacDrive driver. It kept here for backward
compatibility. So people have time to migrate on better new implementation.
Set LightsDriver to "PacDrive" to test the new driver.
GenericHID uses USB libusb_control_transfer to send data (4 bytes) over the wire where first 2 are
lights state. So any HID-like usb device can read the data and control lights.
2025-05-22 11:40:50 -07:00
c18e7a68ae
Add pack.ini file paths to error messages
2025-05-17 14:08:13 -07:00
995f0ea8c1
Change some RString methods to free functions
...
These ones aren't a std::string method. Doing this helps the RString to
std::string migration.
2025-05-17 14:02:12 -07:00
eaf6a24acf
Ensure CodeNames sizes are the same even on invalid codes
2025-05-17 13:03:41 -07:00
e1c91e66f0
Remove the +Alt message for autoplay -- this feature had been removed
2025-05-17 12:22:18 -07:00
a780bdb7be
Add Assist Clap text to the overlay
2025-05-17 12:19:21 -07:00
ecfcb11a00
Remove implicit conversion operator from RString to const char*
...
This is required for the RString to std::string migration.
Mostly automated from https://github.com/aeubanks/rewriter/blob/main/c_str.cc , with some manual intervention required for fixing up `a + b.c_str()` to `(a + b).c_str()`.
Added some overloads for some common global functions like sm_crash to reduce the number of changes required here.
2025-05-15 21:14:54 -07:00
25b57c13d5
Replace some lrint's with GetTimeSinceStartSeconds()
...
Optimization to avoid several stages of integer-to-float and float-to-integer by making use of GetTimeSinceStartSeconds().
2025-05-10 10:09:44 -07:00
d3ff9a0683
Replace GetRandomInt()
...
RageUtil already had a RandomInt function, this wasn't needed after all.
2025-05-10 09:27:05 -07:00
b7bafbef93
Added note about checking dwi chart length of at least 2 characters
2025-05-10 09:22:01 -07:00
977f83a16f
Bail out earlier when dealing with certain types of malformed DWI charts.
2025-05-10 09:22:01 -07:00
60f57cd337
Song::GetFileHash cleanup
...
Implement a range-based loop instead of a big list of if statements.
& prefer ssc to sm to all else
Song::GetFileHash: Fix indentation
2025-05-09 10:48:37 -07:00
e84b774166
Remove an expensive but low-importance log
...
We only see this if & when we shut down cleanly. It's not worth calculating every time we mix a sound into the buffer.
2025-05-09 10:25:12 -07:00
a4124aafe4
Unify practice mode song navigation with edit mode.
2025-05-09 10:09:05 -07:00
d428bbbcd4
Fix for Code scanning alert #40 "Unsigned difference expression compared to zero"
2025-05-06 15:44:15 -07:00
33a6912778
Code scanning alert #487 "Multiplication result converted to larger type"
...
My own fix, not auto-generated.
m_iChannels is implicitly promoted to size_t.
2025-05-06 15:43:38 -07:00
21e6498414
Resolve critical CWE-134 warning
...
Resolves CWE-134: Use of Externally-Controlled Format String by using c_str on the path variable and removing an invalid string concatenation.
2025-05-06 15:43:03 -07:00
f18dddd43e
Fix a malformed CHECKPOINT_M
...
It uses %s, but there is no variable passed to it, so it literally prints "Driver %s successfully made", this fixes that.
2025-05-03 22:42:19 -07:00
79f2e2e5ee
Revert "Fix two small RageFile bugs"
...
This reverts commit 5d2667add1
2025-05-03 07:54:02 -07:00
a517a3887c
Use std::call_once in ArchHooks_Win32Static
...
Makes use of this <mutex> feature to ensure the timer is only initialized once. Reduces clutter, and improves thread-safety.
2025-05-03 07:53:33 -07:00
a3eb3d8646
SaveScreenshot: remove unused timer
...
The timer is only used by the commented-out debug log methods, but the timer itself still runs. This removes the timer as well as the unused logs.
2025-05-01 13:10:30 -07:00
b5a2f86277
SaveScreenshot: Use const & in function header
...
Pass sPath by reference to avoid unnecessary copies.
2025-05-01 13:10:12 -07:00
16b3ba488d
SaveScreenshot: return the status boolean directly
...
Remake of PR #790 due to merge conflicts
2025-05-01 13:09:55 -07:00
64a1e3a49c
SaveScreenshot: remove unneeded boolean
2025-05-01 00:25:09 -07:00
dacf87fb3b
SaveScreenshot: improve error logging
...
The existing code uses repeated error messages at different points in the code, making debugging very difficult. This makes every step more unique for easier state tracking. Also changes trace to warn, to make it a little easier to spot failed screenshots in the log.
2025-05-01 00:23:53 -07:00
d50ad757cb
Remove useless alias
...
This used to be a different function than GetTimeSinceStart which returned a lower precision value but we don't do that anymore.
2025-04-29 21:42:37 -07:00
2bd541a927
Convert more smart pointers in the MovieTexture class.
2025-04-29 21:42:13 -07:00
a4978f4476
Convert the MovieDecoder used by the MovieTexture to a unique_ptr.
2025-04-29 21:42:13 -07:00
ab6d2ff3d0
columnCount -> columnCount_
...
Resolves MSVC compiler warning C4458 by renaming the class variables to columnCount_.
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4458
2025-04-29 21:40:54 -07:00
305a24196a
Make some constants constexpr, mark as float so MSVC doesn't print a warning about a double to float truncation
2025-04-29 21:40:54 -07:00
8dcb01f3ee
Remove COMPARE and COMPARE_FLOAT macros for equivalent if statements.
...
This is both for clarity, and to conform with the google c++ style
guide.
https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros
2025-04-29 21:37:45 -07:00
607b407007
Potential fix for code scanning alert no. 61: Multiplication result converted to larger type
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-04-29 21:32:34 -07:00
3a12adc56c
Pass a const char* instead of RString to RageException::Throw
...
For #781
2025-04-27 12:01:40 -07:00
c7d9938ec3
Potential fix for code scanning alert no. 60: Multiplication result converted to larger type
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-04-26 16:23:42 -07:00
04c58309b7
Remove a CPY macro from ActorMultiVertex
2025-04-26 16:21:39 -07:00
4ae1b79578
Rewrite constructor
...
The existing code looks like it's attempting to call another constructor, and seems to be creating a temporary object, which I don't think is the intention of the code.
2025-04-26 00:10:28 -07:00
dddba8bbda
Potential fix for code scanning alert no. 93: Unsigned difference expression compared to zero
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-04-25 16:55:35 -07:00
7e3ce11658
Clarify confusing RString comparison
...
This was actually a nullptr that got converted to an empty string
because of RString-specific code.
2025-04-23 22:34:16 -07:00
0ba8230b7e
Make Preference implicit conversion operator return a reference
...
Instead of copying. We can let the caller decide if they want to copy.
Also helps with #756 .
2025-04-23 21:17:50 -07:00
57935cee81
Increase check frequency, improve comment
2025-04-23 09:29:29 -07:00
744bfe7800
Global function CallEveryNFrames
...
Call a function every `n` frames.
2025-04-23 09:29:29 -07:00
Scott Brenner