Commit Graph
1764 Commits
Author SHA1 Message Date
Jason Felds 6f9730b6f9 Better comment. 2011-05-28 12:11:49 -04:00
Jason Felds 79113e7b41 No using scrolls in Song Timing. 2011-05-28 11:37:44 -04:00
Jason Felds 461deced3a Let's be doubly sure Survivals work.
If a themer uses a non-existant default noteskin...

...well, at this point we're not responsible I think.
2011-05-27 23:28:14 -04:00
Jason Felds 202728206d Expand on failure message. 2011-05-27 16:16:57 -04:00
Jason Felds 34d4fee067 Round 2...FIGHT! 2011-05-27 13:30:12 -04:00
Jason Felds 8782ac01bc Testing something with another player. 2011-05-27 13:14:33 -04:00
Jason Felds cfa48c388c Allow right shift key for rolls. 2011-05-27 12:49:42 -04:00
Jason Felds a4ebdcc8cc Added the LoopOnChartEnd metric for the editor.
Let the players decide whether to loop or not
when playing charts in the editor.
2011-05-27 12:43:14 -04:00
Jason Felds 40db083a53 Fix off by one error dealing with beat 0.
Hopefully nothing else broke.
2011-05-27 12:30:07 -04:00
Jason Felds 6588753328 Comment no longer needed. 2011-05-27 11:14:14 -04:00
Jason Felds 84b5cf192e Don't ignore those warnings! 2011-05-27 10:53:30 -04:00
Jason Felds 283afa4687 Log if a mod isn't loaded for some reason. 2011-05-27 10:42:47 -04:00
Jason Felds 6b4703d2ed Not a fan of plain ASSERTs. 2011-05-27 10:26:43 -04:00
Jason Felds 002ea6c11a I want others to read this comment.
Check the diff.
2011-05-27 10:12:19 -04:00
Jason Felds 78951b7f05 Introduce the MissComboIsPerRow metric.
Read the changelog for more details.
2011-05-26 22:22:55 -04:00
Jason Felds f01763598d Autosync Song + Split Timing = Happy Players! :D
The solution: use actual objects, not references.

Big thanks to Edgars Klepers for the hint.
2011-05-26 22:00:37 -04:00
Jason Felds 5838313614 Gotta love dereferencing. NOT! 2011-05-26 21:33:20 -04:00
Jason Felds 87246efd07 Still moving towards proper syncing.
Still...not getting where I need to.

Stepping away a bit more.
2011-05-26 19:19:41 -04:00
Jason Felds bb5012b283 Do some refactoring...but doesn't solve it.
Line 79 is the killer one.
It's supposed to be a vector of TimingData pointers.
Yet it compiles with the address reference.

...anyone here that can take a look?
2011-05-26 18:36:30 -04:00
Jason Felds 2d491fd0c0 Add ScrollSegment checks.
Also took care of scaling TimeSignatureSegments too.
2011-05-26 17:38:31 -04:00
Jason Felds a71eb1afd2 Reverting sync seems alright.
I think the rest is cleanup,
but class is starting soon,
so that will have to wait.
2011-05-26 15:38:15 -04:00
Jason Felds 4802ea678f Storing original timing data seems fine.
Let's see what's next...
2011-05-26 15:10:22 -04:00
Jason Felds 43f0fb96e1 Reactivate ed78fa2.
Hasn't caused problems yet, but haven't saved results either.

Next step...setting up original step timing and reverting.
2011-05-26 14:57:28 -04:00
Jason Felds 0270191fef We'll need the Steps to be included first. 2011-05-26 14:46:08 -04:00
Jason Felds 102a2e7a8e empty() test confirmed.
Now, time for the looping process.
2011-05-26 14:41:52 -04:00
Jason Felds c925e687fe So far, so good: no breakage.
Debugging confirmed that I should be able to use empty().

Let's take advantage of that before we get into step looping.
2011-05-26 14:35:54 -04:00
Jason Felds 3c43429f0d Add targeted comments.
I'll be honest: I don't know how well we can handle
Sync Tempo with Split Timing. Sync Song, we should aim for at least.
2011-05-26 14:19:13 -04:00
Jason Felds 17bea0aab7 Doxygen, restart of autosync split timing.
This time, take it a step at a time...
or try to anyway.
2011-05-26 14:11:11 -04:00
Jason Felds e99178c02d Signed vs unsigned warning. 2011-05-25 15:09:10 -04:00
Jason Felds 86e70e1a83 Bring in the scroll branch.
Sorry Saturn, but you have to re-cache this time.
2011-05-25 14:40:18 -04:00
Thai Pangsakulyanont 372540e3a4 Bringing Thai's fix in for Warps and Delays. 2011-05-26 01:12:41 +07:00
Thai Pangsakulyanont 8b159a9df7 make GetClosestNote and GetClosestNonEmptyRow seconds based, and not time-based. 2011-05-26 01:12:41 +07:00
Jason Felds 5f8353bdd0 Use Step Timing if steps are already on Splits. 2011-05-25 14:07:53 -04:00
Thai Pangsakulyanont 8f35c048b8 [scroll] mergefix 2011-05-25 23:48:34 +07:00
Thai Pangsakulyanont d9f936190a [default -> scroll] merge 2011-05-25 22:56:26 +07:00
Thai Pangsakulyanont fe9573975c [scroll] 90% of scroll segments 2011-05-25 22:44:41 +07:00
Jason Felds c5bbeb69ca Empty notes don't get judged (RandomVanish). 2011-05-24 22:14:59 -04:00
Jason Felds 8d2f1017e1 Enforce validation on TapNote types. 2011-05-24 22:13:22 -04:00
Jason Felds b3cebd2aaf No need to swap if it's the same column.
Still busted, but still stumped.
Doing what I can to optimize.
2011-05-24 21:29:51 -04:00
Jason Felds 2afdaf6705 Don't define a variable until it's needed.
Still suspect there's an issue here, but can't identify what.
2011-05-24 21:15:59 -04:00
Jason Felds ded36d6f19 I need to pull more often. 2011-05-24 15:02:16 -04:00
Jason Felds b2a5a68b4a Super Shuffle works with fakes now. 2011-05-24 15:01:52 -04:00
Thai Pangsakulyanont ccc66ccaeb disable editing wait and mode on a row without a speed segment. enabling it is no-op anyway. 2011-05-24 13:30:21 +07:00
Thai Pangsakulyanont ddbecd5de4 add a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warpsadd a comment about behavior of stops and delays in warps 2011-05-24 13:07:59 +07:00
Thai Pangsakulyanont 51229ad086 limit searching to 16 beats 2011-05-24 12:44:48 +07:00
Thai Pangsakulyanont 0533e742c5 a const is need on TimingData.cpp too 2011-05-24 12:29:55 +07:00
Thai Pangsakulyanont 5cde717547 GetDisplayedSpeedPercent should be const 2011-05-24 12:27:03 +07:00
Thai Pangsakulyanont aa0eb7f5d7 GetSpeedMultiplier in ArrowEffects becomes TimingData::GetDisplayedSpeedPercent.
We might need to use it later in other parts (NoteField).
2011-05-24 11:43:08 +07:00
Thai Pangsakulyanont 0994bd64bc fix crash in NotesLoaderBMS 2011-05-24 11:12:47 +07:00
Thai Pangsakulyanont e7df4edbe1 what? I don't really know what I'm doing here. 2011-05-24 10:47:16 +07:00