ScreenSelectPlayMode (formerly select style) has been renamed to ScreenSelectStyle.
ScreenSelectPlayStyle (formerly select play mode) has been renamed to ScreenSelectPlayMode.
[03 Gameplay] Renamed HoldJudgment commands to match the metrics names. Turned off fail combo in dance mode.
[metrics] re-hooked up HoldJudgment commands in Lua
[Course.cpp] HasTimedMods() now actually checks for timed mods (technically non-global) instead of being a clone of HasMods()
[Player.cpp] add MAX_HOLD_LIFE/[Player] MaxHoldLife metric
[ScreenGameplay] looking into places to put loading of replay data, perhaps?
[elsewhere] lots of cleanup, and I'm sure there's lots more to be done.
add a todo to ProductivityHelpers.
* Added new metric to cap the max life of a hold. No sanity checking yet: need a way to keep <= 1.
* Added more Pump specific behavior to lua.
* Fixed combo and hold judgment graphics due to it being defined twice.
Minor cleanup of the ProductivityHelpers is going to have to happen later on.
Note: not all of them seem to be working.
Rolls in particular will always cause an NG right now.
Assistance will be required.
Dance mode should be unaffected.
AJ Kelly