Commit Graph

54 Commits

Author SHA1 Message Date
Jason Felds 9f24627bf9 The big NULL replacement party part 1.
This is meant to be a safer alternative since
NULL can often be 0. Let's not rely on that.

And yes, I know this is a lot of files. This is
a safer thing to do in big commits vs for loops.
2013-05-03 23:01:54 -04:00
Flameshadowxeroshin 78d5be779f Add metric [Gameplay] UseInternalScoring.
Turn it off to prevent the game from touching custom scoring stuff. It is by default on.
2013-05-01 22:11:27 -05:00
Flameshadowxeroshin 1af058e2a1 One &pSteps->mTiming was still in the imported code. 2013-03-24 12:48:34 -05:00
Flameshadowxeroshin e3e04f349f bring in changes unrelated to new score mode that were removed in the previous commit. 2013-03-24 12:44:00 -05:00
Flameshadowxeroshin d57aafa857 revert ScoreKeeperNormal to when it had Extreme scoring 2013-03-24 12:43:32 -05:00
Devin J. Pohly ce507b9800 use empty TimingData in Steps to signify fallback on Song timing.
This required using the new Steps::GetTimingData function and the allowEmpty
parameter to TimingData::TidyUpData when appropriate, as well as clearing the
TimingData to remove step timing rather than coping the song timing over it.

Fixes some odd editor behavior when changing song timing, and is overall a
slightly less hacky way of doing things.
2013-01-23 14:51:18 -05:00
Colby Klein 13c795d019 Revert "dummy out internal scoring"
This reverts commit e1b2222336.

This is pretty much guaranteed to muck with themes.
2012-12-28 13:41:41 -08:00
Flameshadowxeroshin e1b2222336 dummy out internal scoring 2012-12-28 11:22:47 -06:00
Devin J. Pohly bd0e2074ad replace ASSERT(0) with useful fail messages 2012-12-27 16:59:35 -05:00
Jason Felds 1fc16698ba War on -Werror, part 12: explicit bool usage.
It may save a few cycles, but it's best to be
explicit on boolean operations, especially with
ASSERT.
2012-12-27 11:38:53 -05:00
Jason Felds e01537405f war on -Werror, part 8: more informals.
General guide: if the parameter name and its typings
match almost exactly, the name goes away.
Otherwise, it's commented out to allow for some
documentation.
2012-12-27 00:00:28 -05:00
Flameshadowxeroshin 7c7f974668 attempt fix for too many points. 2012-08-02 00:07:05 -05:00
Flameshadowxeroshin 4af1176545 Attempted addition of brand new scoring system. 2012-08-01 23:14:14 -05:00
AJ Kelly 700a8c7837 what the flying f... 2012-04-12 11:40:34 -05:00
Jason Felds a5ac3b0b2d [sm5a2futures] Guess this was a mistake.
Always ensure an internal scoring system is in
place to avoid these problems in the future.

Note: replace the internal scoring system at
some point to be simpler. Can't always rely
on the old style formulas in C++.
2012-02-25 12:15:47 -05:00
Flameshadowxeroshin 86b990a35d Let's actually fix lifts bug 2012-01-04 14:26:08 +00:00
Flameshadowxeroshin d8c04a91cf that was easy(tm) 2012-01-04 04:56:29 +00:00
Mark Cannon f0880d6fd2 fix memory leak in TimingData, remove unnecessary structure copies in ScoreKeeperNormal 2011-09-18 19:07:39 +00:00
Jason Felds 6f5ab98dec [timing] More respect of pointers.
Again going to trust virtual functions to do the right thing.
2011-07-14 23:15:48 -04:00
Jason Felds d7afb23f5a Can't forget checkpoints. 2011-07-09 14:07:13 -04:00
Jason Felds 55870b4f99 ...wait, it was this area, wasn't it? 2011-07-09 13:09:03 -04:00
Jason Felds 08d5f8f722 Add Miss Combo support in #COMBOS tag. 2011-07-09 02:28:15 -04:00
Jason Felds fc9f07158a 99% fix scoring with warps and fakes.
Now all charts can seek 100%.

This does force yet another cache reload.

Hopefully it won't slow first loads too much.
2011-06-08 16:14:11 -04:00
Jason Felds fec932e153 More prep work for better radar calculations. 2011-06-08 15:02:54 -04:00
Jason Felds 714427f154 ComboSegments brought in.
Five to go I believe.
2011-05-31 11:45:25 -04:00
Jason Felds 78951b7f05 Introduce the MissComboIsPerRow metric.
Read the changelog for more details.
2011-05-26 22:22:55 -04:00
Jason Felds 6e72870fd0 [default -> splittiming] Caught up. 2011-05-15 01:00:05 -04:00
AJ Kelly 62964d08ff make these two asserts more helpful 2011-05-14 22:06:14 -05:00
Jason Felds 77dbafe996 [splittiming] Found the other location.
Is there perhaps more to this? Hopefully not.
2011-05-14 20:13:46 -04:00
Jason Felds a32a03b2e9 [splittiming] Trying to restore #COMBOS. 2011-05-14 20:05:27 -04:00
Jason Felds f7d1b46f72 [splittiming] Bringing it down. (91) 2011-05-09 21:03:30 -04:00
Jason Felds 063208eea8 [sm130score] Restore old Course scoring for now.
This can be lua-ized later.
2011-04-12 02:29:57 -04:00
Jason Felds 0737437c81 [sm130score] No more checks for Custom Scoring.
Course Scoring will be for another time.
2011-04-10 03:42:14 -04:00
Jason Felds a813fc4603 [sm130score] Slowly eliminate preference var. 2011-04-10 03:37:13 -04:00
Jason Felds 2269b0d2d1 [sm130score] Big comment was an eyesore. 2011-04-10 03:01:56 -04:00
Jason Felds 7e2f7371a9 [sm130score] SetCurMaxScore via lua. 2011-04-10 02:55:16 -04:00
Jason Felds 9af85b48b1 [sm130score] Cleanup, lua prep. 2011-04-10 02:31:29 -04:00
Jason Felds 24e4e242e2 New branch from sm130futures: [sm130score]
Start migration from .ini to .lua scoring.
2011-04-10 02:09:10 -04:00
Jason Felds a085d0d1da Line endings...be normalized! 2011-03-17 01:47:30 -04:00
Jason Felds 650653b4d2 Multiple warning fixes dealing with casts.
Yes, I am using static_casts. Generally safer.
2011-03-14 02:09:58 -04:00
Jason Felds 994e7d9fa1 Combos branch: make checkpoints consistent.
A combination of #COMBOS and #TICKCOUNTS will be
needed to replicate some of the mission charts.
2011-03-05 00:33:18 -05:00
Jason Felds 4a19be0d05 Combos branch: allow for combo factors on hits. 2011-03-04 23:12:16 -05:00
Flameshadowxeroshin 1aab17e2e0 don't increase combo on AvoidMine if AvoidMineIncrementsCombo is false 2010-09-25 09:57:23 -05:00
Flameshadowxeroshin 2eb5365612 Actually commit the aforementioned metrics; add the metrics to fallback 2010-09-10 21:17:19 -05:00
AJ Kelly f024bbf5cf small cleanup 2010-06-27 19:52:01 -05:00
AJ Kelly 81921e2488 add [Gameplay] MaxScoreToIncrementMissCombo metric. 2010-05-26 00:07:34 -05:00
AJ Kelly 08ae114692 add lifts to a few things. (but not ScreenEvaluation DetailLines (yet). I may flip the switch on that before beta 3)
Profile:GetTotalLifts() Lua binding added.
2010-04-20 23:04:43 -05:00
AJ Kelly f68943191e Turns out this multiple toasty trigger thing is causing more problems than it solved. Back to the old implementation of a single toasty trigger for now.
update credits.
2010-03-27 10:27:52 -05:00
AJ Kelly 5ef1c42e3b ScoreKeeperNormal double shot.
1) convert toasty trigger from a single number to a Lua table. Only problem is, the toasty only triggers on the first one. Since this makes it equivalent to how it was set up before, I'm okay with this.
2) FSX submitted a patch that supposedly fixes the broken combo problem. I can't fully test this, so I'm committing it in the hopes that someone else tests it too.
----
Various theme fixes/changes as well.
2010-03-14 19:24:17 -05:00
AJ Kelly 02c7037721 sm-ssc v1.0 Public Beta 1 code changes 2010-03-01 00:44:39 -06:00