Commit Graph
100 Commits
Author SHA1 Message Date
Jason Felds 1c9e72440f Guess it needed these braces. 2013-04-30 22:16:43 -04:00
Jason Felds 9fea98296b Just two here. 2013-04-30 22:14:36 -04:00
Jason Felds dd5480c69f Few loops here. 2013-04-30 22:12:54 -04:00
Jason Felds 246d25ba60 Just one loop here. 2013-04-30 22:09:57 -04:00
Jason Felds 173b4590c7 Loops handled.
Hmm...is there a reason for the block surrounding those two?
2013-04-30 22:09:10 -04:00
Jason Felds f0d0ea27e6 More loops here. 2013-04-30 22:06:16 -04:00
Jason Felds 94fda00751 Another loop to squish. 2013-04-30 22:03:01 -04:00
Jason Felds e06d7e40bc This can be made const.
Anyone want to transplant this?
2013-04-30 22:00:20 -04:00
Jason Felds a1f671d06f Another two. 2013-04-30 21:57:33 -04:00
Jason Felds 9a0f7a93e2 Again with two. 2013-04-30 21:53:12 -04:00
Jason Felds 0f729945d2 Two loops here. 2013-04-30 21:25:00 -04:00
Jason Felds 1be48d1d93 Back to standard loopings. 2013-04-30 21:23:35 -04:00
Jason Felds 106166f3cc Make this O(n / 2). Or something like that.
This is designed to be transplantable.
2013-04-30 21:19:32 -04:00
Jason Felds 09c9ba234d Most items in UnlockManager handled.
I purposefully left one loop block alone.
2013-04-30 21:13:34 -04:00
Jason Felds 80da0ac974 More loops here. 2013-04-30 20:57:55 -04:00
Jason Felds fa3e09ce42 More loops.
TODO: Look into a proper "implode" function.
2013-04-30 20:54:15 -04:00
Jason Felds a6133c35c3 Some more loops.
Hmm...I think I see a refactoring opportunity.
2013-04-30 20:47:16 -04:00
Jason Felds ead42d5234 Update these loops. 2013-04-30 20:45:40 -04:00
Jason Felds 1be7ad9415 Address the loops. 2013-04-30 20:44:36 -04:00
Jason Felds e2ea061fdc Quickie loops. 2013-04-30 20:40:42 -04:00
Jason Felds 55024fa330 Just one loop here. 2013-04-30 20:38:24 -04:00
Jason Felds e689175fa6 One loop...lots of white sp--
no, stop bringing that joke back up.
2013-04-30 20:37:40 -04:00
Jason Felds c22abff76e Missed one. 2013-04-30 20:36:56 -04:00
Jason Felds 3171f15df2 I should be using + instead of += apparently.
Yay for ##c++ for pointing this out.
2013-04-30 20:36:04 -04:00
Jason Felds f265465096 More loops to utilize. 2013-04-30 20:34:50 -04:00
Jason Felds 23d0180b20 More loops to tackle. 2013-04-30 20:19:03 -04:00
Jason Felds abe2b65514 More loops. 2013-04-30 20:07:22 -04:00
Jason Felds 4dc2b5e636 More loops. 2013-04-30 20:01:58 -04:00
Jason Felds e7d0dccdae Player option loops. 2013-04-30 19:42:19 -04:00
Jason Felds 860b32da7c More for loops. 2013-04-30 19:38:43 -04:00
Jason Felds 8ff71f01f8 The command loops are handled. 2013-04-30 19:32:28 -04:00
Jason Felds 09d6203fea The rest of Song Manager's const loops.
I thought I saw some smart pointer opportunities in here.
2013-04-30 19:28:28 -04:00
Jason Felds 25840d5fa8 Only some of the loops.
The rest can be done after work.
2013-04-30 07:38:33 -04:00
Jason Felds e7f8a17118 Transplantable label to remove? 2013-04-30 00:00:33 -04:00
Jason Felds fcba4702cb Loops. 2013-04-30 00:00:18 -04:00
Jason Felds 6b4cd234ac More loops. 2013-04-29 23:58:43 -04:00
Jason Felds 310dff8b41 Another loop. 2013-04-29 23:57:31 -04:00
Jason Felds a8fb770907 Another simple loop. 2013-04-29 23:56:48 -04:00
Jason Felds 17c8afb190 Use an indexed loop instead. 2013-04-29 23:56:17 -04:00
Jason Felds 6465aefc1b Use the loops. 2013-04-29 23:53:47 -04:00
Jason Felds 4b039a5628 The loops here are handled. 2013-04-29 23:51:20 -04:00
Jason Felds b40bc42eda Back to loop control. 2013-04-29 23:48:12 -04:00
Jason Felds ca15d586fa Explicitly use at instead of the indexer.
libc++ requires this.
2013-04-29 23:38:07 -04:00
Jason Felds 48aaba8560 Explicitly call ToString(). libc++ requires this. 2013-04-29 23:37:45 -04:00
Jason Felds c07d4cf78f Let Mac OS X have goodies. 2013-04-29 23:37:10 -04:00
Jason Felds 71d993ee39 Don't include the internal header.
Use a standard header to include instead.
2013-04-29 19:17:30 -04:00
Jason Felds 9e7a9a76c7 Cover something on the windows side. 2013-04-28 23:42:20 -04:00
Jason Felds d28878ce0a Simple loop...or is it?
I wonder if a goodie can be utilized here.
2013-04-28 23:40:57 -04:00
Jason Felds f61d89f241 Simple loop. 2013-04-28 23:37:12 -04:00
Jason Felds c870660951 Loop / goodie combo. 2013-04-28 23:36:22 -04:00
Jason Felds 9447da4d31 Button loop. 2013-04-28 23:33:11 -04:00
Jason Felds db080e7d8e Loop / goodie combo. 2013-04-28 23:31:57 -04:00
Jason Felds 1214095193 Back to a simple one. 2013-04-28 23:29:23 -04:00
Jason Felds cec01c2a44 Ugh. Template classes. Forces recompilation.
Can't help it here.
2013-04-28 23:28:11 -04:00
Jason Felds 9311913f4a Don't feel like a goodie here. 2013-04-28 23:27:05 -04:00
Jason Felds de92c9ae45 Lots of loops and a goodie here.
I wonder if the last one could be used as a goodie.
2013-04-28 23:24:59 -04:00
Jason Felds b3126e1705 Use the standard library when possible. 2013-04-28 23:20:16 -04:00
Jason Felds fdb26b7121 Loops and a goodie. 2013-04-28 23:16:52 -04:00
Jason Felds 12796dfaf8 This one won't get accumulate. 2013-04-28 23:14:54 -04:00
Jason Felds 03a4ad8e53 Another loop / goodie. Needed a new header though. 2013-04-28 23:13:35 -04:00
Jason Felds bebfd47b26 Loop and goodie. 2013-04-28 23:09:45 -04:00
Jason Felds 02b409e374 Another writer. 2013-04-28 23:07:44 -04:00
Jason Felds 006fc227f8 There's a writer. 2013-04-28 23:06:31 -04:00
Jason Felds 6b36b267af Another simple one. 2013-04-28 23:03:06 -04:00
Jason Felds 4df86c1590 Just one loop here. 2013-04-28 23:02:10 -04:00
Jason Felds 23c80f9d31 Had to keep one loop the same. 2013-04-28 22:59:27 -04:00
Jason Felds bd8ba54bb0 Loops ahoy! 2013-04-28 22:57:05 -04:00
Jason Felds efd703c126 Standard loops this time. 2013-04-28 22:55:47 -04:00
Jason Felds 34277d80a4 Loops and a non mac goodie. 2013-04-28 22:54:22 -04:00
Jason Felds e6e471d2df Goodies! (Except for Mac) 2013-04-28 22:48:08 -04:00
Jason Felds 33872b3cbe Until Xcode behaves, the rest get the goodies. 2013-04-28 22:40:00 -04:00
Jason Felds 8479fbf522 Use the drop downs for selecting this. 2013-04-28 20:27:51 -04:00
Jason Felds 7c0709d522 And forgot to do it here. 2013-04-28 19:33:12 -04:00
Jason Felds fdc13c8ca7 Lion required for upcoming changes.
Assuming I can set them up right.
2013-04-28 19:28:43 -04:00
Jason Felds 0b6fb803ad Restore some sanity defaults.
This commit can be transplanted.
2013-04-28 19:24:20 -04:00
Jason Felds a7377009d0 Commit 7e1d266: lots of loops.
Going to try that any_of thing again.
2013-04-28 18:21:20 -04:00
Jason Felds 84f6a985fd More loops. 2013-04-28 18:11:37 -04:00
Jason Felds cbe8d8bf55 Replace most loops, remove one unneeded loop. 2013-04-28 18:08:09 -04:00
Jason Felds 9f431955f3 Another loop. 2013-04-28 18:03:24 -04:00
Jason Felds 132a301712 Use the standard for each instead.
It includes a way to deal with the "last song" case.
2013-04-28 18:01:47 -04:00
Jason Felds e4544bd3c1 Use the old style for now. 2013-04-28 17:57:11 -04:00
Jason Felds 6a7b567f82 More loops. 2013-04-28 17:54:43 -04:00
Jason Felds 609681649e Simple loops here. 2013-04-28 17:53:46 -04:00
Jason Felds dd00979309 Simple loop to handle. 2013-04-28 17:52:48 -04:00
Jason Felds 35c22dc21f Only process this loop if there is a notefield. 2013-04-28 17:52:06 -04:00
Jason Felds b82e7c18a2 Two for loops. 2013-04-28 17:50:52 -04:00
Jason Felds 2a7d290419 NoteField is handled. 2013-04-28 17:48:39 -04:00
Jason Felds d975984176 This one felt simpler. 2013-04-28 17:46:36 -04:00
Jason Felds 04b03f0b6e Handle the background changes. 2013-04-28 17:28:04 -04:00
Jason Felds 9a968a21f8 Okay, feel better about this. 2013-04-28 17:24:18 -04:00
Jason Felds b1b55a42f6 Wait...const did work? Have to fix the other. 2013-04-28 17:23:38 -04:00
Jason Felds 83dee17d2a Hmm: hard time with std::any_of in Xcode.
The other commit I was worried about worked fine though.

Go figure.
2013-04-28 17:19:26 -04:00
Jason Felds 4d01ff674d I thought it was only 10.6 and higher.
Now it is.
2013-04-28 17:11:24 -04:00
Jason Felds 1823419009 Attempt this commit on Xcode. 2013-04-28 17:04:22 -04:00
Jason Felds cb1b5f5fba Utilize std::any_of.
We have <algorithm>. Let's use it.
2013-04-28 16:50:41 -04:00
Jason Felds 201e355c12 Apply for each loops. 2013-04-28 16:46:25 -04:00
Jason Felds 181de94f3d Now the "simple" loops. 2013-04-28 16:43:50 -04:00
Jason Felds ce2cda0f85 Adjust all map loops remaining.
Two more macro loops to remove.
2013-04-28 16:42:03 -04:00
Jason Felds 581b119c5b Just use auto here. 2013-04-28 16:38:22 -04:00
Jason Felds 129e781005 Another map loop. 2013-04-28 16:34:16 -04:00