21e6498414
Resolve critical CWE-134 warning
...
Resolves CWE-134: Use of Externally-Controlled Format String by using c_str on the path variable and removing an invalid string concatenation.
2025-05-06 15:43:03 -07:00
f18dddd43e
Fix a malformed CHECKPOINT_M
...
It uses %s, but there is no variable passed to it, so it literally prints "Driver %s successfully made", this fixes that.
2025-05-03 22:42:19 -07:00
79f2e2e5ee
Revert "Fix two small RageFile bugs"
...
This reverts commit 5d2667add1
2025-05-03 07:54:02 -07:00
a517a3887c
Use std::call_once in ArchHooks_Win32Static
...
Makes use of this <mutex> feature to ensure the timer is only initialized once. Reduces clutter, and improves thread-safety.
2025-05-03 07:53:33 -07:00
a3eb3d8646
SaveScreenshot: remove unused timer
...
The timer is only used by the commented-out debug log methods, but the timer itself still runs. This removes the timer as well as the unused logs.
2025-05-01 13:10:30 -07:00
b5a2f86277
SaveScreenshot: Use const & in function header
...
Pass sPath by reference to avoid unnecessary copies.
2025-05-01 13:10:12 -07:00
16b3ba488d
SaveScreenshot: return the status boolean directly
...
Remake of PR #790 due to merge conflicts
2025-05-01 13:09:55 -07:00
64a1e3a49c
SaveScreenshot: remove unneeded boolean
2025-05-01 00:25:09 -07:00
dacf87fb3b
SaveScreenshot: improve error logging
...
The existing code uses repeated error messages at different points in the code, making debugging very difficult. This makes every step more unique for easier state tracking. Also changes trace to warn, to make it a little easier to spot failed screenshots in the log.
2025-05-01 00:23:53 -07:00
d50ad757cb
Remove useless alias
...
This used to be a different function than GetTimeSinceStart which returned a lower precision value but we don't do that anymore.
2025-04-29 21:42:37 -07:00
2bd541a927
Convert more smart pointers in the MovieTexture class.
2025-04-29 21:42:13 -07:00
a4978f4476
Convert the MovieDecoder used by the MovieTexture to a unique_ptr.
2025-04-29 21:42:13 -07:00
ab6d2ff3d0
columnCount -> columnCount_
...
Resolves MSVC compiler warning C4458 by renaming the class variables to columnCount_.
https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4458
2025-04-29 21:40:54 -07:00
305a24196a
Make some constants constexpr, mark as float so MSVC doesn't print a warning about a double to float truncation
2025-04-29 21:40:54 -07:00
8dcb01f3ee
Remove COMPARE and COMPARE_FLOAT macros for equivalent if statements.
...
This is both for clarity, and to conform with the google c++ style
guide.
https://google.github.io/styleguide/cppguide.html#Preprocessor_Macros
2025-04-29 21:37:45 -07:00
607b407007
Potential fix for code scanning alert no. 61: Multiplication result converted to larger type
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-04-29 21:32:34 -07:00
e5bb567b0b
Improve CMake caching
2025-04-29 20:31:40 -07:00
3a12adc56c
Pass a const char* instead of RString to RageException::Throw
...
For #781
2025-04-27 12:01:40 -07:00
c7d9938ec3
Potential fix for code scanning alert no. 60: Multiplication result converted to larger type
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-04-26 16:23:42 -07:00
04c58309b7
Remove a CPY macro from ActorMultiVertex
2025-04-26 16:21:39 -07:00
c207d9e0a8
Add .clang-format
...
This tells clang-format what kind of style we want to format as, see
https://clang.llvm.org/docs/ClangFormatStyleOptions.html .
Set it based on Google style. We can iterate on details in the
future.
2025-04-26 16:21:11 -07:00
4ae1b79578
Rewrite constructor
...
The existing code looks like it's attempting to call another constructor, and seems to be creating a temporary object, which I don't think is the intention of the code.
2025-04-26 00:10:28 -07:00
dddba8bbda
Potential fix for code scanning alert no. 93: Unsigned difference expression compared to zero
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-04-25 16:55:35 -07:00
69e33037ed
update README's url to Lua-for-ITGMania
2025-04-25 11:15:35 -07:00
7e3ce11658
Clarify confusing RString comparison
...
This was actually a nullptr that got converted to an empty string
because of RString-specific code.
2025-04-23 22:34:16 -07:00
0ba8230b7e
Make Preference implicit conversion operator return a reference
...
Instead of copying. We can let the caller decide if they want to copy.
Also helps with #756 .
2025-04-23 21:17:50 -07:00
57935cee81
Increase check frequency, improve comment
2025-04-23 09:29:29 -07:00
744bfe7800
Global function CallEveryNFrames
...
Call a function every `n` frames.
2025-04-23 09:29:29 -07:00
1435fc3e9a
Slow down frequency at which device strings are updated in controller mapping screen
...
Currently the input mapping screen asks for an updated list of button names every single frame. As this is a bit excessive, it's changed to run every 120ish frames.
2025-04-23 09:29:29 -07:00
bfa9d3f600
PeekDeltaTime() -> Ago()
...
Remove a useless alias.
2025-04-23 01:59:00 -07:00
ebcd50679d
Include dependent headers harder
...
Prepares for changing some includes in StdString.h
2025-04-22 23:22:56 -07:00
5323bf998e
Replace confusing buffer calls in vssprintf
...
This is basically just resizing the buffer ahead of the vsnprintf, no
need for the extra Release/GetBuffer indirection.
2025-04-22 23:21:36 -07:00
9131dc6b68
Prefix some calls with std::
...
These depend on C++ argument dependent name lookup and won't work with
an upcoming cleanup.
2025-04-22 23:19:28 -07:00
9dc5cea91d
Use C++17 in LoadingWindowGtk
...
To match the rest of the build.
2025-04-22 23:19:03 -07:00
774af7bd19
Update ArchHooks_Win32Static.cpp
...
Thanks to evbo from the ITC discord for pointing out this improvement. It does take bring the thread polling interval down from every 10ms to every 1ms.
2025-04-22 23:14:35 -07:00
ed5c87a10d
Use structured bindings
2025-04-22 22:26:39 -07:00
8524210969
Change vector of vector of strings arrayGroupSongDirs to a map so we know precisely which directories are valid.
2025-04-22 22:26:39 -07:00
5e4f5ae4e5
Update SanityCheckGroup to return whether the group has passed the check or not rather and log a warning if failed rather than exit the game.
2025-04-22 22:26:39 -07:00
1a2188e898
Precompute values & reserve memory in CreateFrameRects()
...
Reduce the number of calculations in nested loops, and reserve the needed amount of memory instead of relying on the vector to resize itself.
2025-04-22 22:18:23 -07:00
448a2be7cd
Add alias_ member to the Actor class.
2025-04-11 09:04:36 -07:00
8da765c3c6
CodeQL code scanning
2025-04-06 00:54:27 -07:00
5c2d745302
Fix looping logic when the final frame can't display.
...
Additionally, adjust the destruction order of the movie texture and
improve logging.
2025-04-03 23:00:06 -07:00
f4e61675d5
PLAYER_1->main_player_ when referencing player state in editmode.
2025-04-03 22:47:38 -07:00
2dc61769fc
Added logic to reset coins at startup
2025-03-30 09:51:47 -07:00
d6636c235b
Revert "Corrected order of hide light in player options"
...
This reverts commit 40e61bd32e
2025-03-30 08:18:42 -07:00
ecf7757bd3
swap to pragma for MSVC
2025-03-30 08:05:37 -07:00
ae294e7cfb
bitstruct pacdrive fix
2025-03-30 08:05:37 -07:00
44c156f8cf
Removed TODO in pacdrive
2025-03-27 22:36:29 -07:00
5cfa78c4dd
Cmake hidapi fixed conditional build
2025-03-27 22:36:29 -07:00
5d1383572d
Fixed mac build referencing wrong header
2025-03-27 22:36:29 -07:00
sukibaby