throwing parsing error up instead of swallowing it
This commit is contained in:
@@ -119,11 +119,9 @@ const createTestChange = (overwrites: Partial<Change> = {}): Change => {
|
|||||||
}
|
}
|
||||||
|
|
||||||
const createTestPURLs = (list: string[]): PackageURL[] => {
|
const createTestPURLs = (list: string[]): PackageURL[] => {
|
||||||
return list
|
return list.map(purl => {
|
||||||
.map(purl => {
|
return parsePURL(purl)
|
||||||
return parsePURL(purl)
|
})
|
||||||
})
|
|
||||||
.filter((purl): purl is PackageURL => purl !== undefined)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export {createTestChange, createTestPURLs}
|
export {createTestChange, createTestPURLs}
|
||||||
|
|||||||
+3
-3
@@ -70,7 +70,7 @@ export function octokitClient(token = 'repo-token', required = true): Octokit {
|
|||||||
return new Octokit(opts)
|
return new Octokit(opts)
|
||||||
}
|
}
|
||||||
|
|
||||||
export const parsePURL = (purlString: string): PackageURL | undefined => {
|
export const parsePURL = (purlString: string): PackageURL => {
|
||||||
try {
|
try {
|
||||||
return PackageURL.fromString(purlString)
|
return PackageURL.fromString(purlString)
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
@@ -78,12 +78,12 @@ export const parsePURL = (purlString: string): PackageURL | undefined => {
|
|||||||
(error as Error).message ===
|
(error as Error).message ===
|
||||||
`purl is missing the required "name" component.`
|
`purl is missing the required "name" component.`
|
||||||
) {
|
) {
|
||||||
//package-url-js does not support empty names, so will manually override it for deny-groups
|
//packageurl-js does not support empty names, so will manually override it for deny-groups
|
||||||
//https://github.com/package-url/packageurl-js/blob/master/src/package-url.js#L216
|
//https://github.com/package-url/packageurl-js/blob/master/src/package-url.js#L216
|
||||||
const purl = PackageURL.fromString(`${purlString}TEMP_NAME`)
|
const purl = PackageURL.fromString(`${purlString}TEMP_NAME`)
|
||||||
purl.name = ''
|
purl.name = ''
|
||||||
return purl
|
return purl
|
||||||
}
|
}
|
||||||
|
throw error
|
||||||
}
|
}
|
||||||
return undefined
|
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user