From c32a0148b317788b1e38449a1f1c900aefd3e5a3 Mon Sep 17 00:00:00 2001
From: Brandon Teng <bteng22@github.com>
Date: Tue, 16 Apr 2024 16:25:28 -0500
Subject: [PATCH] throwing parsing error up instead of swallowing it

---
 __tests__/fixtures/create-test-change.ts | 8 +++-----
 src/utils.ts                             | 6 +++---
 2 files changed, 6 insertions(+), 8 deletions(-)

diff --git a/__tests__/fixtures/create-test-change.ts b/__tests__/fixtures/create-test-change.ts
index e35a855..e6dc54e 100644
--- a/__tests__/fixtures/create-test-change.ts
+++ b/__tests__/fixtures/create-test-change.ts
@@ -119,11 +119,9 @@ const createTestChange = (overwrites: Partial<Change> = {}): Change => {
 }
 
 const createTestPURLs = (list: string[]): PackageURL[] => {
-  return list
-    .map(purl => {
-      return parsePURL(purl)
-    })
-    .filter((purl): purl is PackageURL => purl !== undefined)
+  return list.map(purl => {
+    return parsePURL(purl)
+  })
 }
 
 export {createTestChange, createTestPURLs}
diff --git a/src/utils.ts b/src/utils.ts
index caae214..38a99b9 100644
--- a/src/utils.ts
+++ b/src/utils.ts
@@ -70,7 +70,7 @@ export function octokitClient(token = 'repo-token', required = true): Octokit {
   return new Octokit(opts)
 }
 
-export const parsePURL = (purlString: string): PackageURL | undefined => {
+export const parsePURL = (purlString: string): PackageURL => {
   try {
     return PackageURL.fromString(purlString)
   } catch (error) {
@@ -78,12 +78,12 @@ export const parsePURL = (purlString: string): PackageURL | undefined => {
       (error as Error).message ===
       `purl is missing the required "name" component.`
     ) {
-      //package-url-js does not support empty names, so will manually override it for deny-groups
+      //packageurl-js does not support empty names, so will manually override it for deny-groups
       //https://github.com/package-url/packageurl-js/blob/master/src/package-url.js#L216
       const purl = PackageURL.fromString(`${purlString}TEMP_NAME`)
       purl.name = ''
       return purl
     }
+    throw error
   }
-  return undefined
 }