throwing parsing error up instead of swallowing it

This commit is contained in:
Brandon Teng
2024-04-16 16:25:28 -05:00
parent 67d0214607
commit c32a0148b3
2 changed files with 6 additions and 8 deletions
+3 -5
View File
@@ -119,11 +119,9 @@ const createTestChange = (overwrites: Partial<Change> = {}): Change => {
}
const createTestPURLs = (list: string[]): PackageURL[] => {
return list
.map(purl => {
return parsePURL(purl)
})
.filter((purl): purl is PackageURL => purl !== undefined)
return list.map(purl => {
return parsePURL(purl)
})
}
export {createTestChange, createTestPURLs}
+3 -3
View File
@@ -70,7 +70,7 @@ export function octokitClient(token = 'repo-token', required = true): Octokit {
return new Octokit(opts)
}
export const parsePURL = (purlString: string): PackageURL | undefined => {
export const parsePURL = (purlString: string): PackageURL => {
try {
return PackageURL.fromString(purlString)
} catch (error) {
@@ -78,12 +78,12 @@ export const parsePURL = (purlString: string): PackageURL | undefined => {
(error as Error).message ===
`purl is missing the required "name" component.`
) {
//package-url-js does not support empty names, so will manually override it for deny-groups
//packageurl-js does not support empty names, so will manually override it for deny-groups
//https://github.com/package-url/packageurl-js/blob/master/src/package-url.js#L216
const purl = PackageURL.fromString(`${purlString}TEMP_NAME`)
purl.name = ''
return purl
}
throw error
}
return undefined
}