Compare commits

..

29 Commits

Author SHA1 Message Date
Vallie Joseph 57f42e9cb9 updated package locks 2023-02-13 16:31:49 +00:00
Vallie Joseph 9912202f8d merge with main 2023-02-13 16:27:03 +00:00
Vallie Joseph 5d560f897b updating execfile to use arg array 2022-12-08 20:28:54 +00:00
Vallie Joseph e566d60a34 fixing linting issues 2022-12-08 19:50:32 +00:00
Vallie Joseph 3f2a760a30 updating test and io package 2022-12-08 05:38:33 +00:00
Vallie Joseph 4486413e9e reverting package-json 2022-12-08 05:23:59 +00:00
Vallie Joseph 54eeccaca4 fixing dev dependencies 2022-12-08 05:04:00 +00:00
Vallie Joseph 7c48491a6b fixing lerna ver 2022-12-08 04:58:07 +00:00
Vallie Joseph cb2df24799 Revert "Merge branch 'fhammerl/bump-workflows-node-versions' into vmjoseph/execFile-update"
This reverts commit 7d70dafa7e, reversing
changes made to 6ece840fda.
2022-12-08 04:44:48 +00:00
Vallie Joseph 7d70dafa7e Merge branch 'fhammerl/bump-workflows-node-versions' into vmjoseph/execFile-update 2022-12-08 04:37:45 +00:00
Vallie Joseph 6ece840fda Reverting lerna upgrade 2022-12-07 20:24:42 +00:00
Vallie Joseph 354cc5a718 adding updated toolcache package 2022-12-07 20:19:54 +00:00
Vallie Joseph 19d5d6138b updating release info 2022-12-07 18:49:57 +00:00
Vallie Joseph aee8700cae replacing exec with execFile for security 2022-12-07 18:19:23 +00:00
Vallie Joseph b56e7fcd67 testing commit 2022-12-07 18:11:37 +00:00
Ferenc Hammerl bc15eb10af Check npm version 2022-11-04 15:51:17 +00:00
Ferenc Hammerl 640db317cb Try node v14 2022-11-04 15:42:08 +00:00
Ferenc Hammerl 4e3720ed97 Remove npm patching 2022-11-04 11:31:58 +00:00
Ferenc Hammerl 086231c43a Update setup-node to v3 2022-11-04 11:26:42 +00:00
Ferenc Hammerl 92c2d702e5 Use checkout v3 2022-11-04 11:23:24 +00:00
Ferenc Hammerl 8550e77f38 Use node16 2022-11-04 11:23:04 +00:00
Ferenc Hammerl eda924b207 Fix formatting 2022-11-04 11:18:58 +00:00
Ferenc Hammerl dee747db33 Try older node version 2022-11-02 10:37:38 +00:00
Ferenc Hammerl 580da8ec8b Fix actions/cache 2022-11-01 19:29:59 +00:00
Ferenc Hammerl f8d90ef5be Fix glob audit 2022-11-01 17:13:58 +00:00
Ferenc Hammerl c147b96f55 Downgrade Lerna 2022-11-01 17:08:50 +00:00
Ferenc Hammerl a12b7eef44 Bump lerna major version 2022-11-01 17:06:59 +00:00
Ferenc Hammerl d4c6abaad1 Udpate npm versions 2022-11-01 17:01:13 +00:00
Ferenc Hammerl 698f089b86 Bump workflows node versions 2022-11-01 16:51:40 +00:00
6 changed files with 14 additions and 36 deletions
+1 -1
View File
@@ -29852,4 +29852,4 @@
"dev": true
}
}
}
}
+1 -1
View File
@@ -29,4 +29,4 @@
"ts-jest": "^27.0.5",
"typescript": "^3.9.9"
}
}
}
+2
View File
@@ -1,5 +1,7 @@
# @actions/io Releases
### 1.1.3
- [Fixed a security bug where we used child_proccess.exec instead of execFile for windows](https://github.com/actions/toolkit/pull/1255)
### 1.1.2
- Update `lockfileVersion` to `v2` in `package-lock.json [#1020](https://github.com/actions/toolkit/pull/1020)
+3 -3
View File
@@ -1,13 +1,13 @@
{
"name": "@actions/io",
"version": "1.1.2",
"version": "1.1.3",
"lockfileVersion": 2,
"requires": true,
"packages": {
"": {
"name": "@actions/io",
"version": "1.1.2",
"version": "1.1.3",
"license": "MIT"
}
}
}
}
+2 -2
View File
@@ -1,6 +1,6 @@
{
"name": "@actions/io",
"version": "1.1.2",
"version": "1.1.3",
"description": "Actions io lib",
"keywords": [
"github",
@@ -34,4 +34,4 @@
"bugs": {
"url": "https://github.com/actions/toolkit/issues"
}
}
}
+5 -29
View File
@@ -4,10 +4,7 @@ import * as path from 'path'
import {promisify} from 'util'
import * as ioUtil from './io-util'
// const exec = promisify(childProcess.exec)
const execFile = promisify(childProcess.execFile)
const spawn = childProcess.spawn
const subprocess = spawn('bad_command')
/**
* Interface for cp/mv options
@@ -129,34 +126,13 @@ export async function rmRF(inputPath: string): Promise<void> {
)
}
try {
const cmdPath = ioUtil.getCmdPath()
// const cmdPath = ioUtil.getCmdPath()
const cmdArgs = ['/s', '/q', `${inputPath}`]
if (await ioUtil.isDirectory(inputPath, true)) {
// deletes a dir then sets output to quiet
spawn(cmdPath, ['/s', '/c', 'rd "%inputPath%"'], {
shell: true,
env: {inputPath},
timeout: 500
})
subprocess.on('error', err => {
throw new Error(`Failed to delete ${inputPath}: ${err}`)
})
// await exec(`${cmdPath} /s /c "rd /s /q "%inputPath%""`, {
// env: {inputPath}
// })
await execFile('rd', cmdArgs)
} else {
// deletes a file then pipes output
spawn(cmdPath, ['/s', '/c', `del "%inputPath%"`], {
shell: false,
env: {inputPath},
timeout: 500
})
subprocess.on('error', err => {
throw new Error(`Failed to delete ${inputPath}: ${err}`)
})
// await exec(`${cmdPath} /s /c "del /f /a "%inputPath%""`, {
// env: {inputPath}
// })
const cmdArgsDel = ['/f', '/a', `${inputPath}`]
await execFile('del', cmdArgsDel)
}
} catch (err) {
// if you try to delete a file that doesn't exist, desired result is achieved