segment 98 mb with logs

.github/workflows/releases.yml

@@ -9,17 +9,11 @@ on:
 
 jobs:
   test:
-    outputs:
-      sha: ${{ steps.commit.outputs.sha }}
-      tag: ${{ steps.tag.outputs.tag }}
     runs-on: macos-latest
+
     steps:
       - name: setup repo
         uses: actions/checkout@v3
-      - id: commit
-        run: echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
-      - id: tag
-        run: echo "tag=@actions/${{ github.event.inputs.package }}@$(cat packages/${{ github.event.inputs.package }}/package.json | jq -r .version)" >> "$GITHUB_OUTPUT"
 
       - name: verify package exists
         run: ls packages/${{ github.event.inputs.package }}
@@ -83,26 +77,4 @@ jobs:
           curl -X POST -H 'Content-type: application/json' --data '{"text":":dance: Successfully published a new version of ${{ github.event.inputs.package }}"}' $SLACK_WEBHOOK
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK }}
-  tag:
-    name: "Tag ${{ needs.test.outputs.sha }} with ${{ needs.test.outputs.tag }}"
-    runs-on: "macos-latest"
-    needs: [test, publish]
-    steps:
-    - uses: actions/checkout@v3
-    - name: Create tag
-      uses: actions/github-script@v6
-      with:
-        script: |
-          github.rest.git.createRef({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            ref: 'refs/tags/${{ needs.test.outputs.tag }}',
-            sha: '${{ needs.test.outputs.sha }}'
-          })
-    - name: notify slack on failure
-      if: failure()
-      run: |
-        curl -X POST -H 'Content-type: application/json' --data '{"text":":pb__failed: Publish of ${{ github.event.inputs.package }} was successful, but failed to tag commit ${{ needs.test.outputs.sha }} with version ${{ needs.test.outputs.tag }}"}' $SLACK_WEBHOOK
-      env:
-        SLACK_WEBHOOK: ${{ secrets.SLACK }}
 

packages/cache/src/internal/downloadUtils.ts

@@ -242,7 +242,7 @@ export async function downloadCacheStorageSDK(
     // If the file exceeds the buffer maximum length (~1 GB on 32-bit systems and ~2 GB
     // on 64-bit systems), split the download into multiple segments
     // ~2 GB = 2147483647, beyond this, we start getting out of range error. So, capping it accordingly.
-    const maxSegmentSize = Math.min(2147483647, buffer.constants.MAX_LENGTH)
+    const maxSegmentSize = Math.min(102760447, buffer.constants.MAX_LENGTH)
     const downloadProgress = new DownloadProgress(contentLength)
 
     const fd = fs.openSync(archivePath, 'w')
@@ -275,7 +275,23 @@ export async function downloadCacheStorageSDK(
             'Aborting cache download as the download time exceeded the timeout.'
           )
         } else if (Buffer.isBuffer(result)) {
+          core.info(
+            `Segment offset before writing result to the file ${downloadProgress.segmentOffset}`
+          )
+          core.info(
+            `Download progress object before writing result ${JSON.stringify(
+              downloadProgress
+            )}`
+          )
           fs.writeFileSync(fd, result)
+          core.info(
+            `Segment offset after writing result to the file ${downloadProgress.segmentOffset}`
+          )
+          core.info(
+            `Download progress object after writing result ${JSON.stringify(
+              downloadProgress
+            )}`
+          )
         }
       }
     } finally {

packages/http-client/RELEASES.md

@@ -1,9 +1,5 @@
 ## Releases
 
-## 2.1.0
-- Add support for `*` and subdomains in `no_proxy` [#1355](https://github.com/actions/toolkit/pull/1355) [#1223](https://github.com/actions/toolkit/pull/1223)
-- Bypass proxy for loopback IP adresses [#1360](https://github.com/actions/toolkit/pull/1360))
-
 ## 2.0.1
 - Fix an issue with missing `tunnel` dependency [#1085](https://github.com/actions/toolkit/pull/1085)
 

packages/http-client/__tests__/proxy.test.ts

@@ -176,16 +176,11 @@ describe('proxy', () => {
     expect(bypass).toBeTruthy()
   })
 
+  // Do not match wildcard ("*") as per https://github.com/actions/runner/blob/97195bad5870e2ad0915ebfef1616083aacf5818/docs/adrs/0263-proxy-support.md
   it('checkBypass returns true if no_proxy is "*"', () => {
     process.env['no_proxy'] = '*'
     const bypass = pm.checkBypass(new URL('https://anything.whatsoever.com'))
-    expect(bypass).toBeTruthy()
-  })
-
-  it('checkBypass returns true if no_proxy contains comma separated "*"', () => {
-    process.env['no_proxy'] = 'domain.com,* , example.com'
-    const bypass = pm.checkBypass(new URL('https://anything.whatsoever.com'))
-    expect(bypass).toBeTruthy()
+    expect(bypass).toBeFalsy()
   })
 
   it('HttpClient does basic http get request through proxy', async () => {
@@ -242,31 +237,6 @@ describe('proxy', () => {
     expect(_proxyConnects).toHaveLength(0)
   })
 
-  it('HttpClient bypasses proxy for loopback addresses (localhost, ::1, 127.*)', async () => {
-    // setup a server listening on localhost:8091
-    const server = http.createServer((request, response) => {
-      response.writeHead(200)
-      request.pipe(response)
-    })
-    server.listen(8091)
-    try {
-      process.env['http_proxy'] = _proxyUrl
-      const httpClient = new httpm.HttpClient()
-      let res = await httpClient.get('http://localhost:8091')
-      expect(res.message.statusCode).toBe(200)
-      res = await httpClient.get('http://127.0.0.1:8091')
-      expect(res.message.statusCode).toBe(200)
-
-      // no support for ipv6 for now
-      expect(httpClient.get('http://[::1]:8091')).rejects.toThrow()
-
-      // proxy at _proxyUrl was ignored
-      expect(_proxyConnects).toEqual([])
-    } finally {
-      server.close()
-    }
-  })
-
   it('proxyAuth not set in tunnel agent when authentication is not provided', async () => {
     process.env['https_proxy'] = 'http://127.0.0.1:8080'
     const httpClient = new httpm.HttpClient()

packages/http-client/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@actions/http-client",
-  "version": "2.1.0",
+  "version": "2.0.1",
   "description": "Actions Http Client",
   "keywords": [
     "github",

packages/http-client/src/proxy.ts

@@ -25,11 +25,6 @@ export function checkBypass(reqUrl: URL): boolean {
     return false
   }
 
-  const reqHost = reqUrl.hostname
-  if (isLoopbackAddress(reqHost)) {
-    return true
-  }
-
   const noProxy = process.env['no_proxy'] || process.env['NO_PROXY'] || ''
   if (!noProxy) {
     return false
@@ -57,7 +52,6 @@ export function checkBypass(reqUrl: URL): boolean {
     .map(x => x.trim().toUpperCase())
     .filter(x => x)) {
     if (
-      upperNoProxyItem === '*' ||
       upperReqHosts.some(
         x =>
           x === upperNoProxyItem ||
@@ -72,13 +66,3 @@ export function checkBypass(reqUrl: URL): boolean {
 
   return false
 }
-
-function isLoopbackAddress(host: string): boolean {
-  const hostLower = host.toLowerCase()
-  return (
-    hostLower === 'localhost' ||
-    hostLower.startsWith('127.') ||
-    hostLower.startsWith('[::1]') ||
-    hostLower.startsWith('[0:0:0:0:0:0:0:1]')
-  )
-}