Update proxy.test.ts

packages/http-client/__tests__/proxy.test.ts

@@ -239,7 +239,7 @@ describe('proxy', () => {
 
   it('HttpClient bypasses proxy for loopback addresses (localhost, ::1, 127.*)', async () => {
     // setup a server listening on localhost:8091
-    const server = http.createServer(function(request, response) {
+    const server = http.createServer((request, response) => {
       response.writeHead(200)
       request.pipe(response)
     })
@@ -247,12 +247,14 @@ describe('proxy', () => {
     try {
       process.env['http_proxy'] = _proxyUrl
       const httpClient = new httpm.HttpClient()
-      const res: httpm.HttpClientResponse = await httpClient.get(
-        'http://localhost:8091'
-      )
+      let res = await httpClient.get('http://localhost:8091')
       expect(res.message.statusCode).toBe(200)
-      const body: string = await res.readBody()
-      expect(body).toEqual('')
+      res = await httpClient.get('http://127.0.0.1:8091')
+      expect(res.message.statusCode).toBe(200)
+
+      // no support for ipv6 for now
+      expect(httpClient.get('http://[::1]:8091')).rejects.toThrow()
+
       // proxy at _proxyUrl was ignored
       expect(_proxyConnects).toEqual([])
     } finally {

packages/http-client/src/proxy.ts

@@ -73,10 +73,11 @@ export function checkBypass(reqUrl: URL): boolean {
 }
 
 function isLoopbackAddress(host: string): boolean {
-  const hostUpper = host.toUpperCase()
+  const hostLower = host.toLowerCase()
   return (
-    hostUpper === 'LOCALHOST' ||
-    hostUpper.startsWith('127.') ||
-    hostUpper.startsWith('::1')
+    hostLower === 'localhost' ||
+    hostLower.startsWith('127.') ||
+    hostLower.startsWith('[::1]') ||
+    hostLower.startsWith('[0:0:0:0:0:0:0:1]')
   )
 }