Raw jq for actual version

Fix typo in releases.yml

.github/workflows/releases.yml

@@ -9,11 +9,17 @@ on:
 
 jobs:
   test:
+    outputs:
+      sha: ${{ steps.commit.outputs.sha }}
+      tag: ${{ steps.tag.outputs.tag }}
     runs-on: macos-latest
-
     steps:
       - name: setup repo
         uses: actions/checkout@v3
+      - id: commit
+        run: echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
+      - id: tag
+        run: echo "tag=@actions/${{ github.event.inputs.package }}@$(cat packages/${{ github.event.inputs.package }}/package.json | jq -r .version" >> "$GITHUB_OUTPUT"
 
       - name: verify package exists
         run: ls packages/${{ github.event.inputs.package }}
@@ -77,4 +83,26 @@ jobs:
           curl -X POST -H 'Content-type: application/json' --data '{"text":":dance: Successfully published a new version of ${{ github.event.inputs.package }}"}' $SLACK_WEBHOOK
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK }}
+  tag:
+    name: "Tag ${{ needs.test.outputs.sha }} with ${{ needs.test.outputs.tag }}"
+    runs-on: "macos-latest"
+    needs: [test, publish]
+    steps:
+    - uses: actions/checkout@v3
+    - name: Create tag
+      uses: actions/github-script@v6
+      with:
+        script: |
+          github.rest.git.createRef({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            ref: 'refs/tags/${{ needs.test.outputs.tag }}',
+            sha: '${{ needs.test.outputs.sha }}'
+          })
+    - name: notify slack on failure
+      if: failure()
+      run: |
+        curl -X POST -H 'Content-type: application/json' --data '{"text":":pb__failed: Publish of ${{ github.event.inputs.package }} was successful, but failed to tag commit ${{ needs.test.outputs.sha }} with version ${{ needs.test.outputs.tag }}"}' $SLACK_WEBHOOK
+      env:
+        SLACK_WEBHOOK: ${{ secrets.SLACK }}
 

.github/workflows/tag-test.yml

@@ -0,0 +1,46 @@
+name: Tag test
+
+on: push
+
+jobs:
+  test:
+    outputs:
+      sha: ${{ steps.commit.outputs.sha }}
+      tag: ${{ steps.tag.outputs.tag }}
+    runs-on: macos-latest
+    steps:
+      - name: setup repo
+        uses: actions/checkout@v3
+      - id: commit
+        run: echo "sha=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
+      - id: tag
+        run: echo "tag=@actions/http-client@$(cat packages/http-client/package.json | jq -r .version)-test-tag" >> "$GITHUB_OUTPUT"
+  publish:
+    runs-on: macos-latest
+    needs: test
+    steps:
+      - name: skip publish
+        run: echo "skip publish"
+  tag:
+    name: "Tag ${{ needs.test.outputs.sha }} with ${{ needs.test.outputs.tag }}"
+    runs-on: "macos-latest"
+    needs: [test, publish]
+    steps:
+    - uses: actions/checkout@v3
+    - name: Create tag
+      uses: actions/github-script@v6
+      with:
+        script: |
+          github.rest.git.createRef({
+            owner: context.repo.owner,
+            repo: context.repo.repo,
+            ref: 'refs/tags/${{ needs.test.outputs.tag }}',
+            sha: '${{ needs.test.outputs.sha }}'
+          })
+    # - name: notify slack on failure
+    # if: failure()
+    # run: |
+    #   curl -X POST -H 'Content-type: application/json' --data '{"text":":pb__failed: Publish of ${{ github.event.inputs.package }} was successful, but failed to tag commit ${{ needs.test.outputs.sha }} with version ${{ needs.test.outputs.tag }}"}' $SLACK_WEBHOOK
+    # env:
+    #   SLACK_WEBHOOK: ${{ secrets.SLACK }}
+

packages/http-client/__tests__/proxy.test.ts

@@ -176,16 +176,11 @@ describe('proxy', () => {
     expect(bypass).toBeTruthy()
   })
 
+  // Do not match wildcard ("*") as per https://github.com/actions/runner/blob/97195bad5870e2ad0915ebfef1616083aacf5818/docs/adrs/0263-proxy-support.md
   it('checkBypass returns true if no_proxy is "*"', () => {
     process.env['no_proxy'] = '*'
     const bypass = pm.checkBypass(new URL('https://anything.whatsoever.com'))
-    expect(bypass).toBeTruthy()
-  })
-
-  it('checkBypass returns true if no_proxy contains comma separated "*"', () => {
-    process.env['no_proxy'] = 'domain.com,* , example.com'
-    const bypass = pm.checkBypass(new URL('https://anything.whatsoever.com'))
-    expect(bypass).toBeTruthy()
+    expect(bypass).toBeFalsy()
   })
 
   it('HttpClient does basic http get request through proxy', async () => {

packages/http-client/src/proxy.ts

@@ -52,7 +52,6 @@ export function checkBypass(reqUrl: URL): boolean {
     .map(x => x.trim().toUpperCase())
     .filter(x => x)) {
     if (
-      upperNoProxyItem === '*' ||
       upperReqHosts.some(
         x =>
           x === upperNoProxyItem ||