Responded to PR feedback. Added commit hash to microsoft setup action.

This commit is contained in:
Edward Skrod
2020-04-08 10:17:52 -04:00
parent 703084fb8c
commit a3f957729c
+21 -13
View File
@@ -1,27 +1,35 @@
# This workflow will build, test and package a WPF desktop application built on .NET Core.
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
# This workflow will build, test and package a WPF desktop application
# built on .NET Core.
# To learn how to migrate your existing WPF application to .NET Core,
# refer to https://docs.microsoft.com/en-us/dotnet/desktop-wpf/migration/convert-project-from-net-framework
#
# To configure this workflow:
#
# 1. Configure environment variables
# GitHub sets default environment variables for every workflow run. Replace the variables relative to your
# project in the "env" section below.
# GitHub sets default environment variables for every workflow run.
# Replace the variables relative to your project in the "env" section below.
#
# 2. Signing
# Generate a signing certificate in the Windows Application Packaging Project or add an existing signing certificate
# to the project. Next, use PowerShell to encode the .pfx file using Base64 encoding by running the following Powershell
# script to generate the output string.
# Generate a signing certificate in the Windows Application
# Packaging Project or add an existing signing certificate to the project.
# Next, use PowerShell to encode the .pfx file using Base64 encoding
# by running the following Powershell script to generate the output string:
#
# $pfx_cert = Get-Content '.\SigningCertificate.pfx' -Encoding Byte
# [System.Convert]::ToBase64String($pfx_cert) | Out-File 'SigningCertificate_Encoded.txt'
#
# Open the output file, SigningCertificate_Encoded.txt, and copy the string inside. Then, add the string to the repo
# as a GitHub secret and name it "Base64_Encoded_Pfx."
# For more information on how to configure your signing certificate for this workflow, refer
# to https://github.com/microsoft/github-actions-for-desktop-apps#signing
# Open the output file, SigningCertificate_Encoded.txt, and copy the
# string inside. Then, add the string to the repo as a GitHub secret
# and name it "Base64_Encoded_Pfx."
# For more information on how to configure your signing certificate for
# this workflow, refer to https://github.com/microsoft/github-actions-for-desktop-apps#signing
#
# Finally, add the signing certificate password to the repo as a secret and name it "Pfx_Key."
# Finally, add the signing certificate password to the repo as a secret and name it "Pfx_Key".
# See "Build the Windows Application Packaging project" below to see how the secret is used.
#
# For more information on GitHub Actions, refer to https://github.com/features/actions
@@ -65,9 +73,9 @@ jobs:
with:
dotnet-version: 3.1.101
# Add MsBuild to the PATH: https://github.com/microsoft/setup-msbuild
# Add MSBuild to the PATH: https://github.com/microsoft/setup-msbuild
- name: Setup MSBuild.exe
uses: microsoft/setup-msbuild@v1.0.0
uses: microsoft/setup-msbuild@2008f912f56e61277eefaac6d1888b750582aa16
# Execute all unit tests in the solution
- name: Execute unit tests