actions/starter-workflows
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Get rid of quoting that breaks by default.

Browse Source 
it looks like someone tried to use '' to make a ' happen for the possessive tense of users. But that messes up the quoting:
issue-message: 'Message that will be displayed on users'' first issue'
pr-message: 'Message that will be displayed on users'' first pr'

It should be:
issue-message: 'Message that will be displayed on the first issue for that user'
pr-message: 'Message that will be displayed on the first pr for that user'

(this gets rid of the spurious quotes, but also doesn't introduce any grammatical errors)

It was a very bad impression to have a simple script designed to welcome folks be broken by default.
This commit is contained in:
Sheeri Cabral
2020-10-27 12:25:47 -04:00
parent b4fa2522d2
commit 5699eea8b2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
automation/greetings.yml
+2 -2
View File
@@ -9,5 +9,5 @@ jobs:
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: 'Message that will be displayed on users'' first issue'
pr-message: 'Message that will be displayed on users'' first pr'
issue-message: 'Message that will be displayed on users'
pr-message: 'Message that will be displayed on users'