Commit Graph
2 Commits
Author SHA1 Message Date
Patrick Mézard 7f6d38273e Unquote user:password in hosts (#569)
Before turning them into an authentication header, the user or password
supplied in hosts must be URL decoded.

The RFC https://tools.ietf.org/html/rfc3986 describes userinfo like:

  userinfo    = *( unreserved / pct-encoded / sub-delims / ":" )

and python documentation about urlparse says:

  The components are not broken up in smaller parts (for example, the
  network location is a single string), and % escapes are not expanded.

It is the caller job to unquote them before using them.

For instance, a character like "]" cannot be supplied in a host or
urllib will incorrectly interpret it using ipv6 syntax.

Fix #568
2017-04-13 15:10:40 +02:00
Patrick Mézard 6a88ec6eaa Fix documentation "Snapshot" index link (#419) 2016-10-10 15:02:02 +02:00