Allow lists for http_auth in RequestsHttpConnection

thanks nkvoll!
This commit is contained in:
Honza Kral
2013-10-02 00:42:38 +02:00
parent b0587071b6
commit 5fccd1e793
2 changed files with 6 additions and 1 deletions
+2 -1
View File
@@ -21,8 +21,9 @@ class RequestsHttpConnection(Connection):
super(RequestsHttpConnection, self).__init__(host= host, port=port, **kwargs)
self.session = requests.session()
if http_auth is not None:
if not isinstance(http_auth, tuple):
if not isinstance(http_auth, (tuple, list)):
http_auth = tuple(http_auth.split(':', 1))
http_auth = tuple(http_auth)
self.session.auth = http_auth
self.base_url = 'http%s://%s:%d%s' % (
's' if use_ssl else '',
+4
View File
@@ -79,6 +79,10 @@ class TestRequestsConnection(TestCase):
con = RequestsHttpConnection(http_auth='username:secret')
self.assertEquals(('username', 'secret'), con.session.auth)
def test_http_auth_list(self):
con = RequestsHttpConnection(http_auth=['username', 'secret'])
self.assertEquals(('username', 'secret'), con.session.auth)
def test_http_auth_tuple(self):
con = RequestsHttpConnection(http_auth=('username', 'secret'))
self.assertEquals(('username', 'secret'), con.session.auth)