eric sciple
d2f52a9043
## Problem In workflow YAML files, writing `if: foo == bar` shows an error because `foo` and `bar` are not valid contexts. However, the same invalid expression in an action.yml file showed no error. ## Solution Add expression validation for implicit `if` conditions in action.yml files, matching the behavior of workflow YAML validation. ## What's new 1. **Pre-if/post-if validation** (node and docker actions) - `pre-if: foo == bar` now shows error for unknown context - `post-if: unknownFunc()` now shows error for unknown function 2. **Composite step `if` validation** (fix) - Errors from `convertToIfCondition` were being lost due to call ordering - Now captured correctly by calling conversion before retrieving errors ## Why the refactor? The diff includes consolidating multiple validation loops into a single `validateAllTokens()` traversal. This matches the pattern used in workflow YAML validation (`additionalValidations`), making the code consistent between the two validation paths.
Language Services for GitHub Actions
This repository contains multiple npm packages for working with GitHub Actions workflow YAML files. See the README.md files in the individual package folders.
- expressions - Parser and evaluator for GitHub Actions Expressions
- workflow-parser - Parser for GitHub Actions Workflows
- languageservice - Language Service for GitHub Actions
- languageserver - Language Server for GitHub Actions, hosting the language service for LSP-compatible editors
- browser-playground - Browser-based playground for the language service
Documentation
- JSON Data Files - How the JSON data files are generated and maintained
Note
Thank you for your interest in this GitHub repo, however, right now we are not taking contributions.
We continue to focus our resources on strategic areas that help our customers be successful while making developers' lives easier. While GitHub Actions remains a key part of this vision, we are allocating resources towards other areas of Actions and are not taking contributions to this repository at this time. The GitHub public roadmap is the best place to follow along for any updates on features we’re working on and what stage they’re in.
We are taking the following steps to better direct requests related to GitHub Actions, including:
-
We will be directing questions and support requests to our Community Discussions area
-
High Priority bugs can be reported through Community Discussions or you can report these to our support team https://support.github.com/contact/bug-report.
-
Security Issues should be handled as per our security.md
We will still provide security updates for this project and fix major breaking changes during this time.
You are welcome to still raise bugs in this repo.