Remove unnecessary async functions

This commit is contained in:
Josh Gross
2023-03-16 13:24:49 -04:00
parent 26f5eeede9
commit 8312d857b9
2 changed files with 9 additions and 13 deletions
@@ -19,23 +19,21 @@ export const DEFAULT_RUNNER_LABELS = [
"self-hosted" "self-hosted"
]; ];
/* eslint-disable @typescript-eslint/require-await */
export const defaultValueProviders: ValueProviderConfig = { export const defaultValueProviders: ValueProviderConfig = {
needs: { needs: {
kind: ValueProviderKind.AllowedValues, kind: ValueProviderKind.AllowedValues,
get: needs get: context => Promise.resolve(needs(context))
}, },
"workflow-job-with": { "workflow-job-with": {
kind: ValueProviderKind.AllowedValues, kind: ValueProviderKind.AllowedValues,
get: async context => reusableJobInputs(context) get: context => Promise.resolve(reusableJobInputs(context))
}, },
"workflow-job-secrets": { "workflow-job-secrets": {
kind: ValueProviderKind.SuggestedValues, kind: ValueProviderKind.SuggestedValues,
get: async (context, existingValues) => reusableJobSecrets(context, existingValues) get: (context, existingValues) => Promise.resolve(reusableJobSecrets(context, existingValues))
}, },
"runs-on": { "runs-on": {
kind: ValueProviderKind.SuggestedValues, kind: ValueProviderKind.SuggestedValues,
get: async () => stringsToValues(DEFAULT_RUNNER_LABELS) get: () => Promise.resolve(stringsToValues(DEFAULT_RUNNER_LABELS))
} }
}; };
/* eslint-enable @typescript-eslint/require-await */
+5 -7
View File
@@ -1,15 +1,13 @@
import {WorkflowContext} from "../context/workflow-context"; import {WorkflowContext} from "../context/workflow-context";
import {Value} from "./config"; import {Value} from "./config";
export function needs(context: WorkflowContext): Promise<Value[]> { export function needs(context: WorkflowContext): Value[] {
if (!context.template) { if (!context.template) {
return Promise.resolve([]); return [];
} }
const uniquejobIDs = new Set(context.template.jobs.map(j => j.id)).values(); const uniquejobIDs = new Set(context.template.jobs.map(j => j.id)).values();
return Promise.resolve( return Array.from(uniquejobIDs)
Array.from(uniquejobIDs) .filter(x => x.value !== context.job?.id.value)
.filter(x => x.value !== context.job?.id.value) .map(x => ({label: x.value}));
.map(x => ({label: x.value}))
);
} }