From 8312d857b9d9f4075b5989f9d059fcc4e1ac481f Mon Sep 17 00:00:00 2001
From: Josh Gross <joshmgross@github.com>
Date: Thu, 16 Mar 2023 13:24:49 -0400
Subject: [PATCH] Remove unnecessary async functions

---
 languageservice/src/value-providers/default.ts | 10 ++++------
 languageservice/src/value-providers/needs.ts   | 12 +++++-------
 2 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/languageservice/src/value-providers/default.ts b/languageservice/src/value-providers/default.ts
index 3b7f20e..a5eb643 100644
--- a/languageservice/src/value-providers/default.ts
+++ b/languageservice/src/value-providers/default.ts
@@ -19,23 +19,21 @@ export const DEFAULT_RUNNER_LABELS = [
   "self-hosted"
 ];
 
-/* eslint-disable @typescript-eslint/require-await */
 export const defaultValueProviders: ValueProviderConfig = {
   needs: {
     kind: ValueProviderKind.AllowedValues,
-    get: needs
+    get: context => Promise.resolve(needs(context))
   },
   "workflow-job-with": {
     kind: ValueProviderKind.AllowedValues,
-    get: async context => reusableJobInputs(context)
+    get: context => Promise.resolve(reusableJobInputs(context))
   },
   "workflow-job-secrets": {
     kind: ValueProviderKind.SuggestedValues,
-    get: async (context, existingValues) => reusableJobSecrets(context, existingValues)
+    get: (context, existingValues) => Promise.resolve(reusableJobSecrets(context, existingValues))
   },
   "runs-on": {
     kind: ValueProviderKind.SuggestedValues,
-    get: async () => stringsToValues(DEFAULT_RUNNER_LABELS)
+    get: () => Promise.resolve(stringsToValues(DEFAULT_RUNNER_LABELS))
   }
 };
-/* eslint-enable @typescript-eslint/require-await */
diff --git a/languageservice/src/value-providers/needs.ts b/languageservice/src/value-providers/needs.ts
index 6b2f7cf..9d05272 100644
--- a/languageservice/src/value-providers/needs.ts
+++ b/languageservice/src/value-providers/needs.ts
@@ -1,15 +1,13 @@
 import {WorkflowContext} from "../context/workflow-context";
 import {Value} from "./config";
 
-export function needs(context: WorkflowContext): Promise<Value[]> {
+export function needs(context: WorkflowContext): Value[] {
   if (!context.template) {
-    return Promise.resolve([]);
+    return [];
   }
 
   const uniquejobIDs = new Set(context.template.jobs.map(j => j.id)).values();
-  return Promise.resolve(
-    Array.from(uniquejobIDs)
-      .filter(x => x.value !== context.job?.id.value)
-      .map(x => ({label: x.value}))
-  );
+  return Array.from(uniquejobIDs)
+    .filter(x => x.value !== context.job?.id.value)
+    .map(x => ({label: x.value}));
 }