actions/languageservices
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #24 from github/cschleiden/best-effort-validation

Browse Source 
Use best-effort template conversion during validation
This commit is contained in:
Christopher Schleiden
2022-11-30 13:43:31 -08:00
committed by GitHub
parent 31289072c8 e630928f55
commit 12f956322b
2 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
actions-languageservice/src/context-providers/needs.ts
+1 -1
View File
@@ -1,4 +1,4 @@
import {data} from "@github/actions-expressions/.";
import {data} from "@github/actions-expressions";
import {WorkflowContext} from "../context/workflow-context";
export function getNeedsContext(workflowContext: WorkflowContext): data.Dictionary {
actions-languageservice/src/validate.ts
+3 -2
View File
@@ -9,6 +9,7 @@ import {
ParseWorkflowResult,
WorkflowTemplate
} from "@github/actions-workflow-parser";
import {ErrorPolicy} from "@github/actions-workflow-parser/model/convert";
import {splitAllowedContext} from "@github/actions-workflow-parser/templates/allowed-context";
import {BasicExpressionToken} from "@github/actions-workflow-parser/templates/tokens/basic-expression-token";
import {StringToken} from "@github/actions-workflow-parser/templates/tokens/string-token";
@@ -49,8 +50,8 @@ export async function validate(
try {
const result: ParseWorkflowResult = parseWorkflow(file.name, [file], nullTrace);
if (result.value) {
// Errors will be updated in the context
const template = convertWorkflowTemplate(result.context, result.value);
// Errors will be updated in the context. Attempt to do the conversion anyway in order to give the user more information
const template = convertWorkflowTemplate(result.context, result.value, ErrorPolicy.TryConversion);
// Validate expressions and value providers
await additionalValidations(