Commit Graph

33243 Commits

Author SHA1 Message Date
Jason Felds e4544bd3c1 Use the old style for now. 2013-04-28 17:57:11 -04:00
Jason Felds 6a7b567f82 More loops. 2013-04-28 17:54:43 -04:00
Jason Felds 609681649e Simple loops here. 2013-04-28 17:53:46 -04:00
Jason Felds dd00979309 Simple loop to handle. 2013-04-28 17:52:48 -04:00
Jason Felds 35c22dc21f Only process this loop if there is a notefield. 2013-04-28 17:52:06 -04:00
Jason Felds b82e7c18a2 Two for loops. 2013-04-28 17:50:52 -04:00
Jason Felds 2a7d290419 NoteField is handled. 2013-04-28 17:48:39 -04:00
Jason Felds d975984176 This one felt simpler. 2013-04-28 17:46:36 -04:00
Jason Felds 04b03f0b6e Handle the background changes. 2013-04-28 17:28:04 -04:00
Jason Felds 9a968a21f8 Okay, feel better about this. 2013-04-28 17:24:18 -04:00
Jason Felds b1b55a42f6 Wait...const did work? Have to fix the other. 2013-04-28 17:23:38 -04:00
Jason Felds 83dee17d2a Hmm: hard time with std::any_of in Xcode.
The other commit I was worried about worked fine though.

Go figure.
2013-04-28 17:19:26 -04:00
Jason Felds 4d01ff674d I thought it was only 10.6 and higher.
Now it is.
2013-04-28 17:11:24 -04:00
Jason Felds 1823419009 Attempt this commit on Xcode. 2013-04-28 17:04:22 -04:00
Jason Felds cb1b5f5fba Utilize std::any_of.
We have <algorithm>. Let's use it.
2013-04-28 16:50:41 -04:00
Jason Felds 201e355c12 Apply for each loops. 2013-04-28 16:46:25 -04:00
Jason Felds 181de94f3d Now the "simple" loops. 2013-04-28 16:43:50 -04:00
Jason Felds ce2cda0f85 Adjust all map loops remaining.
Two more macro loops to remove.
2013-04-28 16:42:03 -04:00
Jason Felds 581b119c5b Just use auto here. 2013-04-28 16:38:22 -04:00
Jason Felds 129e781005 Another map loop. 2013-04-28 16:34:16 -04:00
Jason Felds 3bbcff672c Another good opportunity for the standard loop.
Also another smart pointer scouting spot.
2013-04-28 16:32:52 -04:00
Jason Felds 6533bd68ef Another loop to simplify things. 2013-04-28 16:31:26 -04:00
Jason Felds 066b4d08b8 Use the foreach construct.
Hmm...another opportunity for smart pointers?
2013-04-28 16:30:06 -04:00
Jason Felds d54ae4f70c Simplify this loop while in the area. 2013-04-28 16:28:44 -04:00
Jason Felds a68e4aa3c4 Remove unused loop. 2013-04-28 16:28:11 -04:00
Jason Felds 3f8796988d Explicitly use the iterator approach.
Why should iterators be used for the buttons to erase anyway?
2013-04-28 16:27:32 -04:00
Jason Felds 8502c59ee2 Deal with the nested map loops.
...is there a better way to do this?
2013-04-28 16:24:32 -04:00
Jason Felds 9798b35a96 Bring OS X up to date. 2013-04-28 12:12:04 -04:00
Jason Felds 7a553e0aba Use portable mode with libtomcrypt for now.
Activating C++11 turned on strict ansi mode it seems:
it causes some issues with the non portable stuff.

…is there perhaps a different library to use that is more updated with the times?
2013-04-28 12:10:48 -04:00
Jason Felds 8bc0b9385c No longer auto casts to float. Do it manually. 2013-04-28 12:01:41 -04:00
Jason Felds b296bcbd4a Enforce c++11 compiling. 2013-04-28 11:28:31 -04:00
Jason Felds 7549f0dc45 Another loop. 2013-04-28 00:00:54 -04:00
Jason Felds 4eed642749 Handle the float map loop. 2013-04-28 00:00:00 -04:00
Jason Felds 85dae04da5 Again, auto can come in handy. 2013-04-27 23:58:35 -04:00
Jason Felds 7e810ef9f6 Another map loop. 2013-04-27 23:56:11 -04:00
Jason Felds a351621303 Handle the map loops here.
Little concerned on this one due to deletion.

Consider this a hopeful target for a smart pointer.
2013-04-27 23:55:16 -04:00
Jason Felds 6d57d2fbf5 Start working on the other map loops. 2013-04-27 23:50:37 -04:00
Jason Felds 9ec7272416 Restore the const nature of this variable.
Lambdas can be taken advantage of.
2013-04-27 16:06:17 -04:00
Jason Felds 2a5227afbb The last batch of WHITE SPACE loops.
...okay, enough of this running gag.
2013-04-27 15:24:55 -04:00
Jason Felds 08218a3a85 Another simplification. 2013-04-27 15:23:31 -04:00
Jason Felds 13ded3d92d Simplify the loop with auto and WHITE SPACE. 2013-04-27 15:22:27 -04:00
Jason Felds 5dfc1bf279 Log with a loop, auto, and WHITE SPACE. 2013-04-27 15:21:12 -04:00
Jason Felds b6f2bf317c Where's my hg commit --amend command? 2013-04-27 15:20:30 -04:00
Jason Felds 7d56192e97 And back to normal with these loops. 2013-04-27 15:19:43 -04:00
Jason Felds d5afc54f71 Take care of the Prefs Manager WHITE SPACE. 2013-04-27 15:17:58 -04:00
Jason Felds f710f850bf Demonstrate how auto is used for this. 2013-04-27 15:16:55 -04:00
Jason Felds 0e91e5b32d Another map to for each WHITE SPACE. 2013-04-27 15:14:08 -04:00
Jason Felds b6cbb511f8 So much to convert...
this may have worked better with auto.

Still, I'd rather be explicit when possible.
2013-04-27 15:12:47 -04:00
Jason Felds 62b6ef4bfc Utilize const with the pair of WHITE SPACE.
...sigh.
2013-04-27 14:53:31 -04:00
Jason Felds 023deca293 Remove comments that aren't WHITE SPACE.
...this is going to be a running gag.
2013-04-27 14:50:26 -04:00