actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
36,688 Commits 3 Branches 0 Tags
afa44ee4dfdd47f3ba2bef0453402613ea36f174
Commit Graph

10 Commits

Author SHA1 Message Date
teejusb a105e3bd60 Verify that PrefsTable[name] exists before indexing the pref. 2021-09-24 14:57:49 -07:00
Kyzentun Keeslala e233ea291c Change ThemePrefs to use the Theme preference instead of GetThemeDisplayName or themeInfo because GetThemeDisplayName does not work when a theme falls back on another theme. 2018-02-02 11:15:34 -07:00
Dan Guzek f0e46ecb49 fix ThemePrefs 
The ThemePrefs table contains several functions and single standalone variable, NeedsSaving.  When a themer calls ThemePrefs.Save() the system will check the status of NeedsSaved to determine whether it really needs to save or not.  This is by design to prevent unnecessary writing to disk.

As far as I am able to discern, NeedsSaved would never be anything but false due to scoping within the ThemePrefs table.  This commit properly scopes that variable as it used within the functions.

It looks like ThemePrefs.ForceSave() was added as a workaround; it didn't check the status of NeedsSaved and just always saved, "no matter what."  Though it seems safe to outright remove ForceSave(), I'm leaving it in for compatibility.  Consider it deprecated I suppose.
 2015-04-06 21:08:12 -04:00
Kyzentun bedaf07e51 Reverted some changes that should not have been part of the merge from Midiman. 2014-08-28 05:53:37 -06:00
Jonathan Payne 91581bb5f7 Fix eval summary, summary branches 
+ Fixed ScreenGameplay StepsDisplay errors
+ Fixed ScreenSelectCourse CourseContentsList masks
+ Fixed ScreenEvaluationSummary banners -- introduced a scroller.
+ Fixed showing ScreenEvaluationSummary showing after a course

(cherry picked from commit 04f7373238410c481cb79c6441fb27c55c69a447)
 2014-08-28 06:01:15 -05:00
AJ Kelly e6b4a88c56 quiet some of the logging in ThemePrefs 2012-01-16 00:36:49 -06:00
AJ Kelly 082f9f9853 nope.ogv 2012-01-11 22:07:26 -06:00
AJ Kelly 8bb6cd1569 update top comment 2012-01-10 13:50:08 -06:00
AJ Kelly 7e53835f3b add ForceSave to ThemePrefs; will save the file even if it says it doesn't need saving. this is critical to actually getting the theme preferences to be created without having to make changes first. 2012-01-10 13:29:10 -06:00
AJ Kelly cad748aebf move IniFile up to ring 01, ThemePrefs/ThemePrefsRows up to ring 02 2011-12-29 12:16:05 -06:00