All logic is moved into one section now instead of being split between two places.
This is a minor change, but I'd be more comfortable with this because it more explicitly defines the different possibilities for group/machine offset combinations than the existing code.
Revert "Reorganize machine sync bias handing in Group constructor"
This reverts commit b53d26df494aea9d7491d2410c214b146ab09034.
Reorganize machine sync bias handing in Group constructor
Currently, video banners are treated the same as still-image banners, where we assume we need to let the low-res banner fade in before swapping it out with the high-res banner. This isn't the correct way to handle video banners, since we don't make low-res placeholders for them, so we now check the banner's extension to see if it's a video or not, and directly load the video if so.
Remove this method, which only executes on Windows, which overwrites a few of your preferences based on whether or not you have at least 192MB of free RAM. The entire body of the function is wrapped in _WIN32 ifdefs. It is the only function making use of the LastSeenMemory value stored in Preferences.ini.
The original code was written the way that it was because snprintf was not
standard and didn't work consistently across many platforms. But since C++11
std::snprintf is available and can be used to get the exact size of the
required buffer. Because of that, ssprintf can be greatly simplified.
Different platforms can use different sizes for standard types, so GCC emits
a warning when using "%llu" or "%lld" for uint64_t or int64_t respectively.
Switch to using specifiers from <cinttypes> to prevent the warning.
The LOG->Warn line is being executed unconditionally due to the the lack of braces. The indentation is misleading as a result. This adds braces to ensure the intended behavior is performed.
With our new libjpeg_turbo library, a quality of 150 doesn't seem to be valid, so I'm changing this to 95. I chose 95 over 100 because the libjpeg_turbo project uses a quality of 95 for all testing and benchmarking shown in their documentation, and notes that a quality of 95 "has been determined to be perceptually lossless under most viewing conditions".
Removing the case where `StepMania::SaveScreenshot` may request to save a low quality jpeg. The file size difference between a quality 70 and quality 95 jpeg is very small by modern storage standards.
teejusb