actions/itgmania212121
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added video banner logic in ScreenSelectMusic

Browse Source 
Currently, video banners are treated the same as still-image banners, where we assume we need to let the low-res banner fade in before swapping it out with the high-res banner. This isn't the correct way to handle video banners, since we don't make low-res placeholders for them, so we now check the banner's extension to see if it's a video or not, and directly load the video if so.
This commit is contained in:
sukibaby
2025-03-18 04:49:05 -07:00
committed by teejusb
parent 2144678871
commit 07483ef6f9
1 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ScreenSelectMusic.cpp
+24 -6
View File
@@ -1743,6 +1743,15 @@ void ScreenSelectMusic::SwitchToPreferredDifficulty()
}
}
static bool IsVideoFile(const RString& path) {
const RString extension = GetExtension(path);
return extension == "mp4" ||
extension == "avi" ||
extension == "mov" ||
extension == "mkv" ||
extension == "mpg";
}
void ScreenSelectMusic::AfterMusicChange()
{
if( !m_MusicWheel.IsRouletting() )
@@ -2004,14 +2013,23 @@ void ScreenSelectMusic::AfterMusicChange()
if( bWantBanner )
{
LOG->Trace("LoadFromCachedBanner(%s)",g_sBannerPath .c_str());
if( m_Banner.LoadFromCachedBanner( g_sBannerPath ) )
if( IsVideoFile(g_sBannerPath) )
{
/* If the high-res banner is already loaded, just delay before
* loading it, so the low-res one has time to fade in. */
if( !TEXTUREMAN->IsTextureRegistered( Sprite::SongBannerTexture(g_sBannerPath) ) )
m_BackgroundLoader.CacheFile( g_sBannerPath );
// Directly load the video file.
m_Banner.LoadFromCachedBanner(g_sBannerPath);
g_bBannerWaiting = false;
}
else
{
if( m_Banner.LoadFromCachedBanner( g_sBannerPath ) )
{
/* If the high-res banner is already loaded, just delay before
* loading it, so the low-res one has time to fade in. */
if( !TEXTUREMAN->IsTextureRegistered( Sprite::SongBannerTexture(g_sBannerPath) ) )
m_BackgroundLoader.CacheFile( g_sBannerPath );
g_bBannerWaiting = true;
g_bBannerWaiting = true;
}
}
}