Commit Graph

486 Commits

Author SHA1 Message Date
Glenn Maynard 9aead72d03 CourseID 2007-08-15 21:01:23 +00:00
Glenn Maynard 7729701678 use SongID 2007-08-15 20:56:44 +00:00
Glenn Maynard 6f68b3fbaa save disabled songs 2007-08-15 20:27:11 +00:00
Glenn Maynard 3e3c1deea4 We have a lot of duplicate, redundant checks between UNLOCKMAN->SongIsLocked
and Song::GetDisplayed/Song::NormallyDisplayed, which leads to inconsistency.

Make UnlockManager::SongIsLocked() handle both.  Returns a bitfield; most
cases only need to test true or false.

(Also adds m_bEnabled; not used yet.)
2007-08-13 21:20:51 +00:00
Glenn Maynard 9284021d2a style 2007-08-13 19:21:21 +00:00
Glenn Maynard 6653a64354 style 2007-08-13 19:20:40 +00:00
Glenn Maynard a1d33f8588 use Song::GetDisplayed 2007-08-13 19:18:55 +00:00
Glenn Maynard 019ca31c0b CachedObjectPointer<Song> for StepsID 2007-08-12 22:13:25 +00:00
Glenn Maynard f2671274da don't unload edit steps while they're in use 2007-05-31 18:24:22 +00:00
Glenn Maynard 6ee33d2a33 ProfileStepEdits, ProfileCourseEdits prefs 2007-05-27 17:59:41 +00:00
Glenn Maynard 7226e5a962 #BANNER tag for course files 2007-05-25 22:26:43 +00:00
Glenn Maynard 4fab332f39 fix dumb (on a roll today) 2007-05-08 01:49:21 +00:00
Glenn Maynard 579e15dad9 revert dumb 2007-05-08 01:47:44 +00:00
Glenn Maynard c4367903ee fix songs 2007-05-08 01:46:16 +00:00
Glenn Maynard aeb8fed361 honor GetDisplayed in UpdatePreferredSort 2007-05-07 19:51:50 +00:00
Glenn Maynard 081018eedf fix bool != enum 2007-05-07 19:49:35 +00:00
Steve Checkoway f9dbb386d7 Do not use SONGMAN inside SongManager member functions. This one actually was using it inside const functions. 2007-05-05 11:12:34 +00:00
Glenn Maynard 14456ec45d simplify 2007-04-24 02:13:23 +00:00
Glenn Maynard 3c9f9c1d9e remove unused popular lists 2007-04-10 22:41:45 +00:00
Glenn Maynard 23664ade33 remove GetSongRank, GetCourseRank 2007-04-10 22:33:58 +00:00
Glenn Maynard 6e45cfb041 2, not 4 2007-04-10 18:24:34 +00:00
Glenn Maynard 20a7545a4c remove params; do this in lua 2007-04-10 18:24:06 +00:00
Glenn Maynard 2c3371687c remove 2007-04-07 22:33:55 +00:00
Glenn Maynard 83ea1a6807 bind GetSongColor 2007-04-07 22:19:12 +00:00
Steve Checkoway 0e219a16aa Add GetSongColor binding. 2007-04-07 13:00:14 +00:00
Steve Checkoway 00d44c63bc GetRandomSong() was returning songs in the same order every time using the internal RNG. Use g_RandomNumberGenerator instead. 2007-04-07 10:04:08 +00:00
Steve Checkoway 9d75ef8bf2 While I'm at it, const. 2007-04-07 06:13:00 +00:00
Steve Checkoway 72ed44a52e Don't use istring, just use a comparison object that ignores case. 2007-04-07 06:04:40 +00:00
Steve Checkoway 0cb56b6ec2 GetAllSongs() -> GetSongs(). 2007-04-07 05:36:40 +00:00
Steve Checkoway a9187f5ce4 Store the group names in the map case insensitively. 2007-04-07 05:27:29 +00:00
Steve Checkoway 54035d6334 API change. SONGMAN->GetSongs( groupName ) returns a const reference to the songs in the group. If you want a copy of the songs, just copy the return value:
vector<Song *> vSongs = SONGMAN->GetSongs( groupName );
If you don't want to change the songs, get a const reference instead to keep it from copying.
2007-04-07 05:10:29 +00:00
Steve Checkoway de3f6e0618 Working at cleaning up the n different ways to get songs. 1 is probably sufficient. 2007-04-07 02:34:17 +00:00
Steve Checkoway 1ffcdab974 Apply speed up loading patch from https://sourceforge.net/tracker/?func=detail&atid=421366&aid=1691830&group_id=37892 2007-04-03 23:04:25 +00:00
Steve Checkoway 33e69bc576 Free the courses before the songs as per prior comments. 2007-04-01 11:24:40 +00:00
Chris Danford 0160e23705 style cleanup: use FOREACH_ENUM( X, x ) everywhere instead of FOREACH_X( x ) for consistency
The FOREACH_X defines are not very useful, and they were created back before FOREACH_ENUM was convenient.
2007-02-23 22:29:42 +00:00
Chris Danford 9061e2c1c1 move stage logic out of SongManager
allow selecting between multiple StepsTypes on ScreenSelectMusic (ala Pump's combined single/double list)
2007-02-23 21:13:45 +00:00
Chris Danford f77647b5ad enum name cleanup: DIFFICULTY_* -> Difficulty_* 2007-02-22 07:18:05 +00:00
Glenn Maynard 2d0bb7955a GAME_BASE_NOTESKIN_NAME -> DEFAULT_NOTESKIN_NAME.
(This isn't the base noteskin that other noteskins derive from, just
the default preference.)
2007-02-04 04:07:14 +00:00
Glenn Maynard e4ea02f177 fix repeated slow updates
fix memory leak (apToDelete[i] was not actually being deleted)
2007-01-19 06:39:43 +00:00
Glenn Maynard 58bb20d6b3 Profile courses may refer to profile steps, so free profile courses first. 2007-01-19 06:36:49 +00:00
John Bauer 7ebfd65a9b Make it so .sm files can contain \-escaped characters. Also, make the
writer for .dwi files replace control characters with dwi-safe characters.
Other file formats are unaffected.
2006-12-01 22:15:26 +00:00
John Bauer bf6da7d8b4 Reorder some includes. 2006-11-29 14:57:21 +00:00
John Bauer dd0d56e4af Whoops! We can't revert an autogen course from disk. My bad.
TODO: is there a cheaper way to fix up the autogen courses?
2006-11-28 06:56:33 +00:00
Glenn Maynard c2581734b1 const 2006-11-13 18:28:29 +00:00
John Bauer e15285ab55 Fix SongManager::Invalidate. Call it from places it is needed:
ScreenEdit::RevertFromDisk, ScreenEdit's Save routine, and
ScreenEditMenu's Delete Steps routine.  This fixes the bug where
deleting a step chart sometimes causes interesting behavior
but usually just causes a CTD next time you run Oni mode.  It also makes
sure data precalculated from the songs is correctly recalculated when
ScreenEdit changes a song.
2006-11-13 17:07:42 +00:00
Glenn Maynard e32d59ad30 remove unused 2006-11-12 03:58:48 +00:00
Glenn Maynard c6e62ae92d revert. Need a better approach. 2006-11-12 03:26:25 +00:00
John Bauer 34ebb84f63 Remove some old, unused, unusable code. 2006-11-11 21:31:52 +00:00
John Bauer c3e39e12a3 Fix several annoying edit mode bugs, mostly by fixing the Song copy
operator and the various uses of it.

- revert file from disk: keeps old BPM.  The BPMS on disk are added to
  the existing BPM information!
- edit mode turns X stepcharts into 2X when reverting
- sometimes edit mode loses an entire stepchart: open a stepchart,
  change to a new stepchart, exit without going back, original chart gone
- edit a chart, make a change in a different chart, exit from the first chart:
  change made in different chart doesn't revert
- normally, when you create a stepchart and don't save it after editting it,
  it is deleted.  however, if you create a stepchart, don't save it, and exit
  edit mode while looking at a different chart, the chart isn't deleted.

Some existing bugs are not fixed, though:
- delete the last stepchart for a step type.  CTD.
- Edit one of the fake doubles stepcharts for a song that doesn't have
  real doubles stepcharts.  Exit without doing anything.  CTD.  This is
  probably the same problem as the previous bug.
- delete a song or a steps that happens to be part of a trail.  Trail is now
  broken.  Some other edits should affect a trail as well, but don't.
2006-11-10 07:02:27 +00:00
John Bauer 5d2bf93725 Make all uses of the Steps* in the TrailEntry class use an accessor method.
This makes it simple to switch to something else, such as using a StepsId
instead of a Steps*.
2006-11-10 05:04:09 +00:00