Commit Graph

75 Commits

Author SHA1 Message Date
teejusb 7e3789b131 Integrate C++11 branch into 5_1-new 2019-06-22 12:35:38 -07:00
Colby Klein b4e02821e8 Revert "Improve handling of errors in lua functions and speed up calls. (#1427)"
This reverts commit f10e3ae36a.

(it was a joke PR, do not fear)
2017-04-04 17:21:55 -07:00
Kyzentun f10e3ae36a Improve handling of errors in lua functions and speed up calls. (#1427) 2017-04-04 11:36:23 -07:00
Nickito12 6225e114ad Online protocol improvements (#1393)
* Chartkey generation

* Simfile filehash generation

* Read filehash on NSCRSG. Add FLU packets and friendlist vectors. Add
getserverversion method. Send chartkey, filehash and rate on start request.

* Use filehash to find the selected song if it is not empty.

* Friendlist update broadcast.

* Send note row size if it's bigger than 1

* Used for chartkey generation

* Define the ReportScore function with numNotes when WITHOUT_NETWORKING is defined
2017-02-10 04:57:59 -08:00
Kyzentun Keeslala eb3121faf9 Pass timing data to TransformNoteData so that fake notes inside warps can be removed properly. 2016-03-02 08:23:26 -07:00
Kyzentun 9314555e6d Added preference for showing multiple toasties in one song. Added IsWaiting to Transition. 2015-04-18 08:52:57 -06:00
Kyzentun 862eba8f7d Changed logic to allog ToastyTriggersAt to be a function that returns the next increment. Added ToastyMinTNS metric for controlling the TNS for a toasty. 2015-04-17 23:24:49 -06:00
Kyzentun c50b12b8c6 Changed toasty logic to trigger multiple times without requiring a W3. 2015-04-17 16:26:39 -06:00
Kyzentun 7687d5c8a1 Merge branch 'master' of https://github.com/Flameshadowxeroshin/stepmania 2015-01-28 09:52:53 -07:00
Flameshadowxeroshin e861318449 I didn't change everything that needed to change 2015-01-28 10:20:50 -06:00
Flameshadowxeroshin f230729a6f unsigned int combo and score, Player::IncrementComboOrMissCombo 2015-01-23 10:25:06 -06:00
Kyzentun 3fb36af157 Separate styles for players. Notefields positioned between margins. Edit mode works for kickbox. 2014-12-09 22:27:00 -07:00
sigatrev 82cb4a198d Enums for TapNoteType, TapNoteSubType, and TapNoteSource
I intend to make additional useful information available on judgments,
such as TapNoteType and TapNoteSubType( for hold judgments ).

I am submitting this part as a separate pull request because it is more
generally applicable to anything TapNote related.
2014-08-02 00:38:48 -07:00
sigatrev 343511f4c3 HNS_Missed
Added an HNS type to handle holds which are never initialized due to
missed taps. This fixes a long standing issue with
iCurPossibleDancePoints and allows themes to decide how to handled this
case.
2014-03-16 11:36:40 -05:00
Kyzentun 392fabc45f Hold notes were added to possible score twice. 2014-02-12 14:59:48 -07:00
Ben "root" Anderson c783009730 Un-revert. This reversion was made on a wrong assumption and it should actually be this way anyway. PercentScoreWeight* and GradeWeight* are metrics once again. 2013-12-20 18:24:00 -06:00
Ben "root" Anderson 6dcc227327 New NoteDataUtil to count hold ticks in a NoteData. Significant overhaul to make PossibleDancePoints consider hold ticks, using said function. 2013-12-19 23:46:01 -06:00
Ben "root" Anderson 53d80a8ceb CheckPointHit / CheckpointMiss equivalent to Flawless / Miss to mimic real PiU 2013-12-19 18:44:10 -06:00
Ben "root" Anderson 3185746d8a Revert "Make PercentScoreWeight* and GradeWeight* theme metrics instead of preferences"
This reverts commit 77f2b67ee1.

These must be Preferences (or hardcoded) because they affect max DP.
2013-12-19 18:18:54 -06:00
Ben "root" Anderson 77f2b67ee1 Make PercentScoreWeight* and GradeWeight* theme metrics instead of preferences 2013-12-11 19:39:14 -06:00
Jason Felds 28e5148dec The big NULL replacement party part 5.
Right. ' = NULL' would get a lot of these.
2013-05-03 23:39:52 -04:00
Jason Felds 9f24627bf9 The big NULL replacement party part 1.
This is meant to be a safer alternative since
NULL can often be 0. Let's not rely on that.

And yes, I know this is a lot of files. This is
a safer thing to do in big commits vs for loops.
2013-05-03 23:01:54 -04:00
Flameshadowxeroshin 78d5be779f Add metric [Gameplay] UseInternalScoring.
Turn it off to prevent the game from touching custom scoring stuff. It is by default on.
2013-05-01 22:11:27 -05:00
Flameshadowxeroshin 1af058e2a1 One &pSteps->mTiming was still in the imported code. 2013-03-24 12:48:34 -05:00
Flameshadowxeroshin e3e04f349f bring in changes unrelated to new score mode that were removed in the previous commit. 2013-03-24 12:44:00 -05:00
Flameshadowxeroshin d57aafa857 revert ScoreKeeperNormal to when it had Extreme scoring 2013-03-24 12:43:32 -05:00
Devin J. Pohly ce507b9800 use empty TimingData in Steps to signify fallback on Song timing.
This required using the new Steps::GetTimingData function and the allowEmpty
parameter to TimingData::TidyUpData when appropriate, as well as clearing the
TimingData to remove step timing rather than coping the song timing over it.

Fixes some odd editor behavior when changing song timing, and is overall a
slightly less hacky way of doing things.
2013-01-23 14:51:18 -05:00
Colby Klein 13c795d019 Revert "dummy out internal scoring"
This reverts commit e1b2222336.

This is pretty much guaranteed to muck with themes.
2012-12-28 13:41:41 -08:00
Flameshadowxeroshin e1b2222336 dummy out internal scoring 2012-12-28 11:22:47 -06:00
Devin J. Pohly bd0e2074ad replace ASSERT(0) with useful fail messages 2012-12-27 16:59:35 -05:00
Jason Felds 1fc16698ba War on -Werror, part 12: explicit bool usage.
It may save a few cycles, but it's best to be
explicit on boolean operations, especially with
ASSERT.
2012-12-27 11:38:53 -05:00
Jason Felds e01537405f war on -Werror, part 8: more informals.
General guide: if the parameter name and its typings
match almost exactly, the name goes away.
Otherwise, it's commented out to allow for some
documentation.
2012-12-27 00:00:28 -05:00
Flameshadowxeroshin 7c7f974668 attempt fix for too many points. 2012-08-02 00:07:05 -05:00
Flameshadowxeroshin 4af1176545 Attempted addition of brand new scoring system. 2012-08-01 23:14:14 -05:00
AJ Kelly 700a8c7837 what the flying f... 2012-04-12 11:40:34 -05:00
Jason Felds a5ac3b0b2d [sm5a2futures] Guess this was a mistake.
Always ensure an internal scoring system is in
place to avoid these problems in the future.

Note: replace the internal scoring system at
some point to be simpler. Can't always rely
on the old style formulas in C++.
2012-02-25 12:15:47 -05:00
Flameshadowxeroshin 86b990a35d Let's actually fix lifts bug 2012-01-04 14:26:08 +00:00
Flameshadowxeroshin d8c04a91cf that was easy(tm) 2012-01-04 04:56:29 +00:00
Mark Cannon f0880d6fd2 fix memory leak in TimingData, remove unnecessary structure copies in ScoreKeeperNormal 2011-09-18 19:07:39 +00:00
Jason Felds 6f5ab98dec [timing] More respect of pointers.
Again going to trust virtual functions to do the right thing.
2011-07-14 23:15:48 -04:00
Jason Felds d7afb23f5a Can't forget checkpoints. 2011-07-09 14:07:13 -04:00
Jason Felds 55870b4f99 ...wait, it was this area, wasn't it? 2011-07-09 13:09:03 -04:00
Jason Felds 08d5f8f722 Add Miss Combo support in #COMBOS tag. 2011-07-09 02:28:15 -04:00
Jason Felds fc9f07158a 99% fix scoring with warps and fakes.
Now all charts can seek 100%.

This does force yet another cache reload.

Hopefully it won't slow first loads too much.
2011-06-08 16:14:11 -04:00
Jason Felds fec932e153 More prep work for better radar calculations. 2011-06-08 15:02:54 -04:00
Jason Felds 714427f154 ComboSegments brought in.
Five to go I believe.
2011-05-31 11:45:25 -04:00
Jason Felds 78951b7f05 Introduce the MissComboIsPerRow metric.
Read the changelog for more details.
2011-05-26 22:22:55 -04:00
Jason Felds 6e72870fd0 [default -> splittiming] Caught up. 2011-05-15 01:00:05 -04:00
AJ Kelly 62964d08ff make these two asserts more helpful 2011-05-14 22:06:14 -05:00
Jason Felds 77dbafe996 [splittiming] Found the other location.
Is there perhaps more to this? Hopefully not.
2011-05-14 20:13:46 -04:00