Commit Graph

46 Commits

Author SHA1 Message Date
Steve Checkoway 725f2e7c27 Any given step can continue the combo, maintain the combo, break the combo, or outright miss. Those that break the combo aren't misses and shouldn't increase the miss counter but they should break the combo.
Fixes bug 1738253.
2007-07-22 08:25:25 +00:00
Glenn Maynard efdc53de2f don't give 3 miss combo if you hit 1 and miss 2; only give 2 miss combo 2007-06-06 06:03:32 +00:00
Glenn Maynard 8c36383c76 working on finishing checkpoint holds:
track checkpoints missed and hit
allow it to inlfuence the life meter
2007-04-06 23:25:32 +00:00
Glenn Maynard 65383a11b8 more consistent miss combo behavior 2007-03-13 07:28:42 +00:00
Chris Danford 32586f28e1 add IsStepsPlayable, make IsStepsTypePlayable take the number of stages left into account 2007-03-12 01:47:03 +00:00
Chris Danford 9061e2c1c1 move stage logic out of SongManager
allow selecting between multiple StepsTypes on ScreenSelectMusic (ala Pump's combined single/double list)
2007-02-23 21:13:45 +00:00
Chris Danford f77647b5ad enum name cleanup: DIFFICULTY_* -> Difficulty_* 2007-02-22 07:18:05 +00:00
Chris Danford dd2fef4f40 add HandleTapScoreNone() for letting LifeMeters and ScoreKeepers handle TNS_None steps 2006-12-19 01:39:57 +00:00
John Bauer 90f9a4543b I've never seen the "correct" functioning of a miss combo in an arcade,
thanks of course to my amazing abilities.  Lesser players have pointed out
that the right thing to do is in fact increment a miss combo by one regardless
of how many taps are missed at once.  This change restores the original
count and leaves a comment describing why it isn't incremented more.

Also, just kidding, Wolfman.
2006-11-27 04:36:09 +00:00
John Bauer 8707bfa798 Fix a bug where miss combos were incremented by 1, not 2 or more,
even for jumps or hands.

Perhaps this wasn't a bug, but in that case the reason for the distinction
should have been documented.
2006-11-27 01:09:32 +00:00
Jason Felds 4cd490f4e2 Fix the bug where having too many rolls can make the score go over m_iMaxPossiblePoints. 2006-11-24 14:17:13 +00:00
Glenn Maynard f0dab15f30 move AutoPlay 2006-11-21 05:02:55 +00:00
Glenn Maynard 8676a40c8c move PercentScoreWeight, GradeWeight 2006-11-21 03:27:27 +00:00
Chris Danford e224b1787c add params to AddTapRowScore for calculating score based on num taps in row
fix row scored before combo and score multiplier calculated in guitar
fix CurrentComboChanged not broadcasted on combo stopped
2006-11-16 12:25:05 +00:00
Chris Danford 86037fa6cd split AddScore into: AddTapScore, AddHoldScore, AddTapRowScore 2006-11-15 23:36:32 +00:00
Glenn Maynard cecb7a5710 simplify 2006-11-14 22:01:21 +00:00
Glenn Maynard f19852fe0f simplify 2006-11-14 21:43:44 +00:00
Chris Danford 2f7ac6aa3c Add m_ to StageStats and PlayerStageStats members. There are several methods of these classes with local variable names that are similar to the member names. m_ helps distinguish between those two types. 2006-11-14 11:13:21 +00:00
Glenn Maynard 4c406c9123 We have:
LifeMeter->IsFailing()
    -- whether the player would fail if a failure check was made right now
  bFailedEarlier
    -- whether the player was failing at some point
  bFailed
    -- whether the player actually failed

bFailedEarlier is set even in FailOff, but other than that the two
are identical.  Most of the time, use bFailed; in FailOff, the player
should never fail, so bFailedEarlier should be meaningless.
2006-11-09 08:16:34 +00:00
Glenn Maynard 6b240f51ab revert. Self-consistency over blind emulation; no rationale was given
for this change.  (I'm sort of inclined to remove this entirely and do
something new, though ...)
2006-10-29 03:58:41 +00:00
Jason Felds 3a3102debe Use the real formula for normal mode, and our own for courses. 2006-10-28 04:03:52 +00:00
Glenn Maynard 4bb479a445 standard enums for some preference types 2006-10-07 07:43:18 +00:00
Steve Checkoway fcbe0609c3 Move miss combo calculations into the ScoreKeeper. 2006-10-01 04:02:28 +00:00
Steve Checkoway c99a463f62 Cleanup. 2006-10-01 01:59:35 +00:00
Glenn Maynard a220b68c9e update bindings 2006-09-26 08:01:12 +00:00
Steve Checkoway 17c16210d1 Cleanup. 2006-08-18 00:05:50 +00:00
Steve Checkoway 886f368be2 Cleanup. 2006-08-17 20:18:19 +00:00
Chris Danford 7ac45c24e4 save Preferred, Stage, Song, and Current modifiers separately. This eliminates the fragile mods store/restore. 2006-08-05 02:38:05 +00:00
Josh Allen e38749de1b Send note result offset into ReportScore 2006-07-22 03:28:45 +00:00
Josh Allen 4e4e0dc04a HandleTapScore now sends all mine data to the server. 2006-07-21 16:24:55 +00:00
Josh Allen a7a2bb2dcc I don't think we are supposed to be incrementing the possible dance points twice. 2006-07-20 18:10:29 +00:00
Steve Checkoway 743d2b9697 Change the api to take a NoteData and a row. Let the score keepers decide what they want to do with the row. 2006-07-14 04:19:30 +00:00
Steve Checkoway 1aa51dd1d1 Change ScoreKeeper's api to take TapNotes instead of the scores. 2006-07-10 05:15:52 +00:00
Steve Checkoway 746c21f44a Use DEFAULT_FAIL. 2006-07-10 01:29:21 +00:00
Steve Checkoway 40a80c01d9 Spacing cleanup. 2006-07-10 01:24:36 +00:00
Josh Allen 6c80e0fa5a Send mine data to the server. 2006-07-06 17:53:49 +00:00
Steve Checkoway 78eb52a75c Add missing header. 2006-06-26 10:57:26 +00:00
Steve Checkoway aa2c86ce35 Cleanup. 2006-06-24 00:06:57 +00:00
Glenn Maynard 958299c734 spacing 2006-02-14 11:10:03 +00:00
Chris Danford 0b98adff15 make RadarCategory enum and Lua names consistent 2005-12-24 20:18:56 +00:00
Glenn Maynard b01308783e unused headers 2005-12-19 00:42:29 +00:00
Chris Danford e00a57e05e use Preference1D 2005-10-26 23:09:56 +00:00
Chris Danford feb1bfb0fc naming cleanup: rename scoring "Tier1"s to "W1"s (short for "Window 1")
add Preference1D so that we can index into the grading and life values
2005-10-09 04:30:59 +00:00
Chris Danford 0c458e121f Remove link. The comments text is sufficient. 2005-10-08 05:05:46 +00:00
Chris Danford 32464990af enum name cleanup to reflect the generic calculations 2005-10-08 04:50:28 +00:00
Chris Danford 0f07808ecc Use generic names for score values since they are treated genericly by the code.
Theme changes coming...
2005-10-08 02:10:32 +00:00