Commit Graph

31 Commits

Author SHA1 Message Date
Kyzentun 0dfb131291 Created SongOptions Lua interface with a similar design to the PlayerOptions interface. Moved enums that were inside SongOptions out and made them Lua accessible. Removed sAutosyncType and associated things from AdjustSync.cpp because it was unused. Added DefaultNilArgs and FArgGTEZero to LuaBinding as helpers. Moved INTERFACE defines from PlayerOptions.cpp to OptionsBinding.h. 2014-05-03 19:27:32 -06:00
Devin J. Pohly ce507b9800 use empty TimingData in Steps to signify fallback on Song timing.
This required using the new Steps::GetTimingData function and the allowEmpty
parameter to TimingData::TidyUpData when appropriate, as well as clearing the
TimingData to remove step timing rather than coping the song timing over it.

Fixes some odd editor behavior when changing song timing, and is overall a
slightly less hacky way of doing things.
2013-01-23 14:51:18 -05:00
Devin J. Pohly bd0e2074ad replace ASSERT(0) with useful fail messages 2012-12-27 16:59:35 -05:00
AJ Kelly 7edab29ad7 small formatting changes 2011-09-18 21:02:29 -05:00
Mark Cannon 8099e25dcc stage 3 of TimingData changes: changed external interface, enforce encapsulation more strictly 2011-09-15 03:28:58 +00:00
Mark Cannon 0d4e43f9e3 stage 1 of TimingSegment cleanup: consolidate genericizable code in TimingData, use a proper variable name 2011-09-10 03:08:59 +00:00
Jason Felds b711e34431 [timing] More adjustments. 2011-07-27 23:03:33 -04:00
Jason Felds 848d48d9ea [timing] More progress.
Need a lunch break.
2011-07-14 13:10:02 -04:00
Jason Felds 2ab5a4ddb8 Mostly 64 - 32 float warning fixes. 2011-06-12 03:37:10 -04:00
Jason Felds df6a00b53e Stops (and Delays) now templated.
This is all of them at this present time.

At some point in the future, we should make
DelaySegments separate from StopSegments.
2011-06-01 09:50:34 -04:00
Jason Felds f01763598d Autosync Song + Split Timing = Happy Players! :D
The solution: use actual objects, not references.

Big thanks to Edgars Klepers for the hint.
2011-05-26 22:00:37 -04:00
Jason Felds 5838313614 Gotta love dereferencing. NOT! 2011-05-26 21:33:20 -04:00
Jason Felds 87246efd07 Still moving towards proper syncing.
Still...not getting where I need to.

Stepping away a bit more.
2011-05-26 19:19:41 -04:00
Jason Felds bb5012b283 Do some refactoring...but doesn't solve it.
Line 79 is the killer one.
It's supposed to be a vector of TimingData pointers.
Yet it compiles with the address reference.

...anyone here that can take a look?
2011-05-26 18:36:30 -04:00
Jason Felds a71eb1afd2 Reverting sync seems alright.
I think the rest is cleanup,
but class is starting soon,
so that will have to wait.
2011-05-26 15:38:15 -04:00
Jason Felds 4802ea678f Storing original timing data seems fine.
Let's see what's next...
2011-05-26 15:10:22 -04:00
Jason Felds 43f0fb96e1 Reactivate ed78fa2.
Hasn't caused problems yet, but haven't saved results either.

Next step...setting up original step timing and reverting.
2011-05-26 14:57:28 -04:00
Jason Felds 0270191fef We'll need the Steps to be included first. 2011-05-26 14:46:08 -04:00
Jason Felds 102a2e7a8e empty() test confirmed.
Now, time for the looping process.
2011-05-26 14:41:52 -04:00
Jason Felds c925e687fe So far, so good: no breakage.
Debugging confirmed that I should be able to use empty().

Let's take advantage of that before we get into step looping.
2011-05-26 14:35:54 -04:00
Jason Felds 3c43429f0d Add targeted comments.
I'll be honest: I don't know how well we can handle
Sync Tempo with Split Timing. Sync Song, we should aim for at least.
2011-05-26 14:19:13 -04:00
Jason Felds 17bea0aab7 Doxygen, restart of autosync split timing.
This time, take it a step at a time...
or try to anyway.
2011-05-26 14:11:11 -04:00
Jason Felds 8cf6286207 Revert AdjustSync to 69c7cfa.
This needs more help and care than I am capable of at this point.
For now, AutoSync may not work as intended.
2011-05-19 18:56:23 -04:00
Jason Felds fdd23c1526 Why is AdjustSync even usable on the title menu? 2011-05-19 18:46:35 -04:00
Jason Felds 8143a4e0ca Take Thai's advice, update all steps on Tempo. 2011-05-19 17:24:13 -04:00
Jason Felds 3ff9a2376a AdjustSync Song is conceptually better.
Needs review and assistance.

Does NOT cover tempo adjustments yet.
2011-05-19 13:58:17 -04:00
Jason Felds ed78fa24aa Autosync work for Split Timing.
Next up: adjusting the revert.
2011-05-19 10:38:48 -04:00
Jason Felds f7d1b46f72 [splittiming] Bringing it down. (91) 2011-05-09 21:03:30 -04:00
Jason Felds a085d0d1da Line endings...be normalized! 2011-03-17 01:47:30 -04:00
AJ Kelly 3e51544930 Initial commit. 2010-01-26 21:00:30 -06:00
Devin J. Pohly 80057f53cd smsvn -> ssc-hg glue: rearrange directory structure 2013-06-10 15:38:43 -04:00