Another goto goes away.

As far as if a variable should be made in the loop
or out of it...consider that up for debate.
This commit is contained in:
Jason Felds
2013-01-24 22:54:02 -05:00
parent fbc605302d
commit fb06985b64
+12 -4
View File
@@ -1574,6 +1574,7 @@ Song *MusicWheel::GetPreferredSelectionForRandomOrPortal()
#define NUM_PROBES 1000
for( int i=0; i<NUM_PROBES; i++ )
{
bool isValid = true;
/* Maintaining difficulties is higher priority than maintaining
* the current group. */
if( i == NUM_PROBES/4 )
@@ -1595,11 +1596,18 @@ Song *MusicWheel::GetPreferredSelectionForRandomOrPortal()
continue;
FOREACH( Difficulty, vDifficultiesToRequire, d )
{
if( !pSong->HasStepsTypeAndDifficulty(st,*d) )
goto try_next;
return wid[iSelection]->m_pSong;
try_next:
;
{
isValid = false;
break;
}
}
if (isValid)
{
return wid[iSelection]->m_pSong;
}
}
LOG->Warn( "Couldn't find any songs" );
return wid[0]->m_pSong;