Forgot to utilize references.
Still compiled, but wasn't the best move.
This commit is contained in:
+1
-1
@@ -1073,7 +1073,7 @@ XNode* Profile::SaveGeneralDataCreateNode() const
|
|||||||
|
|
||||||
{
|
{
|
||||||
XNode* pUnlocks = pGeneralDataNode->AppendChild("Unlocks");
|
XNode* pUnlocks = pGeneralDataNode->AppendChild("Unlocks");
|
||||||
for (RString const unlockEntry : m_UnlockedEntryIDs)
|
for (RString const &unlockEntry : m_UnlockedEntryIDs)
|
||||||
{
|
{
|
||||||
XNode *pEntry = pUnlocks->AppendChild("UnlockEntry");
|
XNode *pEntry = pUnlocks->AppendChild("UnlockEntry");
|
||||||
pEntry->AppendAttr( "UnlockEntryID", unlockEntry );
|
pEntry->AppendAttr( "UnlockEntryID", unlockEntry );
|
||||||
|
|||||||
+1
-1
@@ -907,7 +907,7 @@ void SongUtil::GetAllSongGenres( vector<RString> &vsOut )
|
|||||||
if( !(*song)->m_sGenre.empty() )
|
if( !(*song)->m_sGenre.empty() )
|
||||||
genres.insert( (*song)->m_sGenre );
|
genres.insert( (*song)->m_sGenre );
|
||||||
}
|
}
|
||||||
for (RString const genre : genres)
|
for (RString const &genre : genres)
|
||||||
{
|
{
|
||||||
vsOut.push_back( genre );
|
vsOut.push_back( genre );
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user