From f66883aa1b397448ecaa52c38030f011b570df26 Mon Sep 17 00:00:00 2001 From: Jason Felds Date: Sat, 27 Apr 2013 13:33:05 -0400 Subject: [PATCH] Forgot to utilize references. Still compiled, but wasn't the best move. --- src/Profile.cpp | 2 +- src/SongUtil.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Profile.cpp b/src/Profile.cpp index eb2c09ba04..e2a6c8720a 100644 --- a/src/Profile.cpp +++ b/src/Profile.cpp @@ -1073,7 +1073,7 @@ XNode* Profile::SaveGeneralDataCreateNode() const { XNode* pUnlocks = pGeneralDataNode->AppendChild("Unlocks"); - for (RString const unlockEntry : m_UnlockedEntryIDs) + for (RString const &unlockEntry : m_UnlockedEntryIDs) { XNode *pEntry = pUnlocks->AppendChild("UnlockEntry"); pEntry->AppendAttr( "UnlockEntryID", unlockEntry ); diff --git a/src/SongUtil.cpp b/src/SongUtil.cpp index 2145f43e61..477eb2a882 100644 --- a/src/SongUtil.cpp +++ b/src/SongUtil.cpp @@ -907,7 +907,7 @@ void SongUtil::GetAllSongGenres( vector &vsOut ) if( !(*song)->m_sGenre.empty() ) genres.insert( (*song)->m_sGenre ); } - for (RString const genre : genres) + for (RString const &genre : genres) { vsOut.push_back( genre ); }