simplify rarely-used Load2

stepmania/src/ActorScroller.cpp

@@ -39,21 +39,13 @@ ActorScroller::ActorScroller()
 }
 
 void ActorScroller::Load2(
+	float fSecondsPerItem,
 	float fNumItemsToDraw, 
-	float fItemWidth, 
 	float fItemHeight, 
-	bool bLoop, 
-	float fSecondsPerItem, 
-	float fSecondsPauseBetweenItems )
+	bool bLoop )
 {
 	Load3( fSecondsPerItem, fNumItemsToDraw, false, 
 		ssprintf("function(self,offset,itemIndex,numItems) self:y(%f*offset) end",fItemHeight), 1, bLoop );
-
-	m_fSecondsPauseBetweenItems = fSecondsPauseBetweenItems;
-
-	ScrollThroughAllItems();
-
-	EnableMask( fItemWidth, fItemHeight );
 }
 
 void ActorScroller::Load3(

stepmania/src/ActorScroller.h

@@ -14,12 +14,10 @@ public:
 	ActorScroller();
 
 	void Load2(
+		float fSecondsPerItem,
 		float fNumItemsToDraw, 
-		float fItemWidth, 
 		float fItemHeight, 
-		bool bLoop, 
-		float fSecondsPerItem, 
-		float fSecondsPauseBetweenItems );
+		bool bLoop );
 
 	void Load3(
 		float fSecondsPerItem, 
@@ -47,6 +45,7 @@ public:
 	void ScrollThroughAllItems();
 	void ScrollWithPadding( float fItemPaddingStart, float fItemPaddingEnd );
 	void SetPauseCountdownSeconds( float fSecs )			{ m_fPauseCountdownSeconds = fSecs; }
+	void SetSecondsPauseBetweenItems( float fSeconds ) { m_fSecondsPauseBetweenItems = fSeconds; }
 	float	GetSecondsForCompleteScrollThrough() const;
 
 	//

stepmania/src/CourseContentsList.cpp

@@ -78,12 +78,13 @@ void CourseContentsList::SetFromGameState()
 	bool bLoop = pMasterTrail->m_vEntries.size() > uNumEntriesToShow;
 
 	this->Load2( 
-		(float)MAX_VISIBLE_ITEMS,
-		m_vpDisplay[0]->GetUnzoomedWidth(),
-		m_vpDisplay[0]->GetUnzoomedHeight(),
-		bLoop,
 		0.7f,
-		0.7f );
+		(float)MAX_VISIBLE_ITEMS,
+		m_vpDisplay[0]->GetUnzoomedHeight(),
+		bLoop );
+	this->EnableMask( m_vpDisplay[0]->GetUnzoomedWidth(), m_vpDisplay[0]->GetUnzoomedHeight() );
+	this->SetSecondsPauseBetweenItems( 0.7f );
+	this->ScrollThroughAllItems();
 
 	this->SetCurrentAndDestinationItem( (MAX_VISIBLE_ITEMS-1)/2 );
 	if( bLoop )

stepmania/src/ScreenRanking.cpp

@@ -365,8 +365,9 @@ void ScoreScroller::Load(
 	for( int i=0; i<iNumCopies; ++i )
 		this->AddChild( new ScoreRowItem(ItemTemplate) );
 
-	DynamicActorScroller::Load2( (float) m_metricSongScoreRowsToDraw, SCREEN_WIDTH, fItemHeight, false, SONG_SCORE_SECONDS_PER_ROW, 0 );
+	DynamicActorScroller::Load2( SONG_SCORE_SECONDS_PER_ROW, (float) m_metricSongScoreRowsToDraw, fItemHeight, false );
 	DynamicActorScroller::EnableMask( SCREEN_WIDTH, fItemHeight );
+	DynamicActorScroller::ScrollThroughAllItems();
 
 	m_iNumItems = m_vScoreRowItemData.size();
 }